[PATCH] Opcode.pm for readability

2001-09-20 Thread Pat Eyler
Below is a patch doing five things: 1) rename $nvivsiz to $sizeof_float which should be easier to understand 2) rename the inner $count to $num_params which should avoid some confusion 3) change $num_i and $num_n to $num_ints and $num_floats respectively which should help c

another silly question about Parrot::Opcode

2001-09-19 Thread Pat Eyler
I found one more bit that looks odd to me (again in _load), near the end of the while loop is this code: my $num_i = () = grep {/i/} @params; my $num_n = () = grep {/n/} @params; $opcode{$name}{RETURN_OFFSET} = 1 + $num_i + $num_n * 2; which could be reduced to:

niave question about Parrot::Opcode

2001-09-19 Thread Pat Eyler
parrot hackers, I'm not going to pretend to be a wizened hacker, but I've got a couple of questions about Parrot::Opcode that I hope you could answer. 1) _load looks like: sub _load { # # # my $count = 1; while (<$fh>) { # # # if (@params && $pa