Re: [PATCH] IO fixes for Win32

2004-02-19 Thread Melvin Smith
At 11:57 AM 2/19/2004 -0800, Goplat wrote: Failed Test Stat Wstat Total Fail Failed List of Failed imcc/t/syn/file.t1 256121 8.33% 11 t/pmc/env.t 3 768 63 50.00% 3 5-6 t/pmc/perlar

Re: [PATCH] IO fixes for Win32

2004-02-19 Thread Goplat
--- Melvin Smith <[EMAIL PROTECTED]> wrote: > At 10:02 AM 2/19/2004 -0800, Goplat wrote: > >--- Melvin Smith <[EMAIL PROTECTED]> wrote: > > > >Where is the hassle? It's just a few lines of code to check windows > > > >version. It's easier to code that than to make another configure > option. > > >

Re: [PATCH] IO fixes for Win32

2004-02-19 Thread Melvin Smith
At 10:02 AM 2/19/2004 -0800, Goplat wrote: --- Melvin Smith <[EMAIL PROTECTED]> wrote: > >Where is the hassle? It's just a few lines of code to check windows > >version. It's easier to code that than to make another configure option. > > Then submit a patch. Okay. (attached) Very good, thank you

Re: [PATCH] IO fixes for Win32

2004-02-19 Thread Goplat
--- Melvin Smith <[EMAIL PROTECTED]> wrote: > At 09:27 AM 2/19/2004 -0800, Goplat wrote: > >--- Dan Sugalski <[EMAIL PROTECTED]> wrote: > > > At 12:40 AM +0300 2/18/04, Vladimir Lipsky wrote: > > > >From: "Goplat" <[EMAIL PROTECTED]> > > > > > > > >> --- Vladimir Lipsky <[EMAIL PROTECTED]> wrote:

Re: [PATCH] IO fixes for Win32

2004-02-19 Thread Melvin Smith
At 09:27 AM 2/19/2004 -0800, Goplat wrote: --- Dan Sugalski <[EMAIL PROTECTED]> wrote: > At 12:40 AM +0300 2/18/04, Vladimir Lipsky wrote: > >From: "Goplat" <[EMAIL PROTECTED]> > > > >> --- Vladimir Lipsky <[EMAIL PROTECTED]> wrote: > >> > From: "Goplat" <[EMAIL PROTECTED]> > >> > > >> > > flag

Re: [PATCH] IO fixes for Win32

2004-02-19 Thread Goplat
--- Dan Sugalski <[EMAIL PROTECTED]> wrote: > At 12:40 AM +0300 2/18/04, Vladimir Lipsky wrote: > >From: "Goplat" <[EMAIL PROTECTED]> > > > >> --- Vladimir Lipsky <[EMAIL PROTECTED]> wrote: > >> > From: "Goplat" <[EMAIL PROTECTED]> > >> > > >> > > flags_to_win32 sets fdwShareMode to FILE_SHARE_

Re: [PATCH] IO fixes for Win32

2004-02-17 Thread Vladimir Lipsky
From: "Goplat" <[EMAIL PROTECTED]> > If you really need FILE_SHARE_DELETE that badly, the check would have to be > done at runtime. I don't think it's all that necessary though... in fact perl > 5 only uses FILE_SHARE_READ, and that only if the file's not opened for write/append. What's more, a v

Re: [PATCH] IO fixes for Win32

2004-02-17 Thread Dan Sugalski
At 12:40 AM +0300 2/18/04, Vladimir Lipsky wrote: From: "Goplat" <[EMAIL PROTECTED]> --- Vladimir Lipsky <[EMAIL PROTECTED]> wrote: > From: "Goplat" <[EMAIL PROTECTED]> > > > flags_to_win32 sets fdwShareMode to FILE_SHARE_DELETE, which is not > > supported in win98 > > A fix for that should

Re: [PATCH] IO fixes for Win32

2004-02-17 Thread Vladimir Lipsky
From: "Goplat" <[EMAIL PROTECTED]> > --- Vladimir Lipsky <[EMAIL PROTECTED]> wrote: > > From: "Goplat" <[EMAIL PROTECTED]> > > > > > flags_to_win32 sets fdwShareMode to FILE_SHARE_DELETE, which is not > > > supported in win98 > > > > A fix for that should be windows version specific and needs supp

Re: [PATCH] IO fixes for Win32

2004-02-17 Thread Goplat
--- Vladimir Lipsky <[EMAIL PROTECTED]> wrote: > From: "Goplat" <[EMAIL PROTECTED]> > > > flags_to_win32 sets fdwShareMode to FILE_SHARE_DELETE, which is not > > supported in win98 > > A fix for that should be windows version specific and needs support of the > config subsystem. If you did that,

Re: [PATCH] IO fixes for Win32

2004-02-17 Thread Vladimir Lipsky
From: "Vladimir Lipsky" <[EMAIL PROTECTED]> > A fix for that should be windows version specific and needs support of the > config subsystem. And 0f course in io_win32.c *fdwShareMode = PIO_WIN32_SHARE_MODE; > 0x4C56 0x4C56

Re: [PATCH] IO fixes for Win32

2004-02-17 Thread Vladimir Lipsky
From: "Goplat" <[EMAIL PROTECTED]> > flags_to_win32 sets fdwShareMode to FILE_SHARE_DELETE, which is not supported > in win98 and will cause the CreateFile to fail, so the ParrotIO is NULL, and A fix for that should be windows version specific and needs support of the config subsystem. The logic

[PATCH] IO fixes for Win32

2004-02-16 Thread Goplat
flags_to_win32 sets fdwShareMode to FILE_SHARE_DELETE, which is not supported in win98 and will cause the CreateFile to fail, so the ParrotIO is NULL, and subsequent PIO_read on its io PMC will return -1. When len is -1, some tests in t/src/io.t will think it's positive since it has it as a UINTVAL