On Sunday 30 September 2001 08:46 pm, Simon Cozens wrote:
> It's to do with me being confused between the size of the NV pointer
> (which is an IV)
Not necessarily.
--
Bryan C. Warnock
[EMAIL PROTECTED]
On Sun, Sep 30, 2001 at 07:07:34PM -0500, Gibbs Tanton - tgibbs wrote:
> mem_sys_memcopy( &value, cursor, sizeof(NV) )
I'm being stupid. Of course that ought to work.
(And it does, everywhere it matters.)
> does the sizeof(IV) have something to do with it?
It's to do with me being confused
BTW, Cygwin works fine (although -Wall issues a number of warnings related
to the printf flags).
-Original Message-
From: Simon Cozens
To: Gregor N. Purdy
Cc: '[EMAIL PROTECTED]'; [EMAIL PROTECTED]
Sent: 9/30/2001 3:21 PM
Subject: Re: NV Constants
On Sun, Sep 30, 2001 at
er...does the sizeof(IV) have something to do with
it?
This code does not look right at all...can you help me understand?
-Original Message-
From: Simon Cozens
To: Gregor N. Purdy
Cc: '[EMAIL PROTECTED]'; [EMAIL PROTECTED]
Sent: 9/30/2001 3:21 PM
Subject: Re: NV Constants
On Sun,
> > The memcpy() can handle alignment nicely.
>
> Not always. I tried. :(
How that could be possible? The memcpy() just does byte-by-byte
copy. It does not care anything about the alignment of source
or dest. How can it fail?
Hong
On Sun, Sep 30, 2001 at 01:37:44PM -0700, Hong Zhang wrote:
> The memcpy() can handle alignment nicely.
Not always. I tried. :(
--
"How should I know if it works? That's what beta testers are for. I only
coded it."
(Attributed to Linus Torvalds, somewhere in a posting)
> This was failing here until I made the following change:
>
> PackFile_Constant_unpack_number(struct PackFile_Constant *
> self, char * packed, IV packed_size) {
> char * cursor;
> NV value;
> NV * aligned = mem_sys_allocate(sizeof(IV));
Are you sure this is correct? Or this
On Sun, Sep 30, 2001 at 11:25:04AM -0400, Gregor N. Purdy wrote:
> * Solaris (Sparc)
This was failing here until I made the following change:
PackFile_Constant_unpack_number(struct PackFile_Constant * self, char * packed, IV
packed_size) {
char * cursor;
NV value;
NV * align
Gibbs --
> I tested the patch on CygWin, Solaris SunOS 5.8, and Tru64. It passed on
> all three systems.
Thanks!
Here's the platform status of this work:
CORE PASSED:
* Linux (x86)
* CygWin
* True64
* Solaris (Sparc)
CORE NOT TESTED:
* Win32
* OpenVMS (Alpha)
* FreeBSD (x86)
I tested the patch on CygWin, Solaris SunOS 5.8, and Tru64. It passed on
all three systems.
Tanton
In message <[EMAIL PROTECTED]>
"Gregor N. Purdy" <[EMAIL PROTECTED]> wrote:
> Sorry about that, Tom. I really need to add -N to my .cvsrc...
> I just sent the (hopefully) complete patch to the list. Please try
> it out against a fresh checkout and let me know how it works for
> you...
Tom --
> > There was trouble with the attachment on my last post, so here it
> > comes again...
>
> That patches and builds OK but the added files are not in the
> patch so Parrot/Assembler.pm at least is missing and this I can't
> run any tests.
Sorry about that, Tom. I really need to add -N t
In message <[EMAIL PROTECTED]>
"Gregor N. Purdy" <[EMAIL PROTECTED]> wrote:
> There was trouble with the attachment on my last post, so here it
> comes again...
That patches and builds OK but the added files are not in the
patch so Parrot/Assembler.pm at least is missing and this I can
Tom --
> There seems to be a lot of the patch missing:
I don't know what happened there. Maybe my mailer flaked. Anyway,
stay tuned. I'll resend to the list.
Regards,
-- Gregor
_
/ perl -e 'srand(-2091643526); print ch
In message <[EMAIL PROTECTED]>
"Gregor N. Purdy" <[EMAIL PROTECTED]> wrote:
> Let me know how this works for you...
There seems to be a lot of the patch missing:
gosford [~/src/parrot-nvconst] % patch -N < /tmp/nvconst.patch
patching file Makefile.in
patching file Types_pm.in
patching
All --
This now works on my system. This is a big change, so we really need
to see results from folks before we even think about committing this.
Also, I've probably made some style or portability missteps in a
change this large, so I'd appreciate some feedback there, too. If we
can make whatever
16 matches
Mail list logo
