On Mon Apr 09 01:17:50 2007, pcoch wrote:
In the file src/ops/io.ops there is the todo item:
all results from string_to_cstring() need freeing
but this generates ugly warnings WRT discarding the const
qualifier
free the results but also without generating the warnings
string_to_cstring() need freeing
but this generates ugly warnings WRT discarding the const
qualifier
free the results but also without generating the warnings if possible.
Jonathan Worthington wrote:
* Memory leak - string_to_cstring returns a malloced string, which isn't
freed everywhere
Thanks, applied -r8671
Note - yes, I know many of the strings are passed to
internal_excpection, but IIRC many of those will be becoming
real_exceptions in the future, so
Hi,
From docs/ROADMAP
* Memory leak - string_to_cstring returns a malloced string, which isn't
freed everywhere
A quick grep through the src folder found a few cases like this. I may have
missed some, but this patch fixes those I spotted. Compiles, passes all
tests (apart from
Gregor N. Purdy [EMAIL PROTECTED] writes:
Nicholas --
I'd be happy with that...
[...]
Instead could we just ditch the C-style put? (and make the layer table
one pointer smaller)
Thats something I wanted to do, See [RfC] Cleanup of ParrotIOLayerAPI
I just wanted to let the release pass
All --
I've got some diffs in my sandbox that I thought I had submitted
at one point, but I can't find any evidence of them being submitted,
so I'll open discussion here.
The first change is that the prototype for string_to_cstring()
becomes:
char *
string_to_cstring(struct Parrot_Interp
On Sun, Sep 21, 2003 at 08:48:55AM -0700, Gregor N. Purdy wrote:
The next change is a change to the IO layer. In include/parrot/io.h
we change struct _ParrotIOLayerAPI to have two versions of C string
writing:
INTVAL (*PutSc)(theINTERP, ParrotIOLayer * l, /* C-style string put
*/
Nicholas --
I'd be happy with that...
Regards,
-- Gregor
On Sun, 2003-09-21 at 09:12, Nicholas Clark wrote:
On Sun, Sep 21, 2003 at 08:48:55AM -0700, Gregor N. Purdy wrote:
The next change is a change to the IO layer. In include/parrot/io.h
we change struct _ParrotIOLayerAPI to have two