[perl #59532] say typeof(namespace) gives a segfault

2008-10-02 Thread NotFound via RT
The problem is that the vtable function get_class return NULL. This is easily fixable, but the root of the problem is that the _class attribute is set in init as PMCNULL, but later it contains NULL.

[perl #59544] open(null) kills parrot

2008-10-02 Thread via RT
# New Ticket Created by I Sop # Please include the string: [perl #59544] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=59544 (I'd expect an exception to be raised instead.) PIR code: ..sub 'foo' :main     $S0 =

[perl #59538] [BUG] imcc freezes (compute_dominance_frontiers) -- Possible fix

2008-10-02 Thread Stephen Weeks via RT
Attached is a possible fix of this problem. I'm fairly certain that it's correct, but I'd like review from at least one other person befor eI commit it. 0001--imcc.patch Description: Binary data

[perl #59532] say typeof(namespace) gives a segfault

2008-10-02 Thread via RT
# New Ticket Created by I Sop # Please include the string: [perl #59532] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=59532 The following PIR code causes a segfault:

[perl #59542] null hash keys give segfault

2008-10-02 Thread via RT
# New Ticket Created by I Sop # Please include the string: [perl #59542] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=59542 maybe a duplicate of #43485 PIR code to reproduce: ..sub 'foo' :main     $S0 = null    

Re: [perl #59538] [BUG] imcc freezes (compute_dominance_frontiers) -- Possible fix

2008-10-02 Thread NotFound
Looks correct. Tested on Linux i386, parrot test pass, perl6 test pass, test program in the RT does not hang and the generated pbc contains the expected opcodes. Good work! -- Salu2

[perl #59546] [PATCH] Combine hash exists/get into a new opcode (5% performance gain)

2008-10-02 Thread via RT
# New Ticket Created by Nick Glencross # Please include the string: [perl #59546] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=59546 Hi All, This patch adds two new opcodes which allow a hash exists and get to be

Re: [perl #59546] [PATCH] Combine hash exists/get into a new opcode (5% performance gain)

2008-10-02 Thread Nick Glencross
All, Sorry, I see that I said opcode a new times, when of course I meant PMC vtable entry. Nick

Re: [perl #59546] [PATCH] Combine hash exists/get into a new opcode (5% performance gain)

2008-10-02 Thread NotFound
I think will be better the other way, using the return value to flag existence, and passing a pointer to store the result. This will allow shorter and cleaner code. -- Salu2

Re: [perl #59544] open(null) kills parrot

2008-10-02 Thread NotFound
(I'd expect an exception to be raised instead.) PIR code: ..sub 'foo' :main $S0 = null $P0 = open $S0, '' ..end output: src/string.c:2106: failed assertion 's' Fixed in r31565 , but several questions opened: Where to put a test for this? There is no t/ops/io.t and creating a

Re: [perl #59546] [PATCH] Combine hash exists/get into a new opcode (5% performance gain)

2008-10-02 Thread Nick Glencross
NotFound, That would look cleaner, wouldn't it? I'll give it a go. Nick On Thu, Oct 2, 2008 at 3:35 PM, NotFound [EMAIL PROTECTED] wrote: I think will be better the other way, using the return value to flag existence, and passing a pointer to store the result. This will allow shorter and

Re: [perl #59546] [PATCH] Combine hash exists/get into a new opcode (5% performance gain)

2008-10-02 Thread Patrick R. Michaud
On Thu, Oct 02, 2008 at 04:51:32PM +0100, Nick Glencross wrote: NotFound, That would look cleaner, wouldn't it? I'll give it a go. Nick On Thu, Oct 2, 2008 at 3:35 PM, NotFound [EMAIL PROTECTED] wrote: I think will be better the other way, using the return value to flag existence,

Re: [perl #59546] [PATCH] Combine hash exists/get into a new opcode (5% performance gain)

2008-10-02 Thread NotFound
I think will be better the other way, using the return value to flag existence, and passing a pointer to store the result. This will allow shorter and cleaner code. Another possibility might be to avoid the extra parameter altogether, returning NULL (not PMCNULL) if the element doesn't

Re: [perl #59538] [BUG] imcc freezes (compute_dominance_frontiers) -- Possible fix

2008-10-02 Thread chromatic
On Wednesday 01 October 2008 21:24:39 Stephen Weeks via RT wrote: Attached is a possible fix of this problem. I'm fairly certain that it's correct, but I'd like review from at least one other person before I commit it. It makes sense to me. I wonder if we could re-enable the optimization

Re: [perl #59542] null hash keys give segfault

2008-10-02 Thread NotFound
maybe a duplicate of #43485 PIR code to reproduce: ..sub 'foo' :main $S0 = null $P0 = new 'Hash' # no crash without next line $P0['yum'] = 5 $P1 = $P0[$S0] ..end Fixed in r31566, together with a test adapted from this code. Don't know if is related to #43485 ? --

Re: [svn:parrot] r31570 - trunk/src/ops

2008-10-02 Thread chromatic
On Thursday 02 October 2008 13:37:28 [EMAIL PROTECTED] wrote: Author: julianalbo Date: Thu Oct 2 13:37:27 2008 New Revision: 31570 Modified: trunk/src/ops/io.ops Log: some fixes in the open opcode --- trunk/src/ops/io.ops (original) +++ trunk/src/ops/io.ops Thu Oct 2

[perl #59576] [PATCH] 'property' scope for PAST::Var

2008-10-02 Thread via RT
# New Ticket Created by I Sop # Please include the string: [perl #59576] # in the subject line of all future correspondence about this issue. # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=59576 I just copied the 'attribute' method, renamed everything, and changed the parameter order

[perl #59112] Failing test in t/examples/library.t

2008-10-02 Thread James Keenan via RT
Forgot to forward to list: On Thu Oct 02 18:37:05 2008, [EMAIL PROTECTED] wrote: On Wed Oct 01 16:09:41 2008, julianalbo wrote: I see a more generic problem. Several modules add lib links to the parrot executable. Makes sense to link static libraries if that is the intention, but is