Re: [perl #58988] [RFC] Parrot_get_runtime_prefix function

2008-10-21 Thread Reini Urban
2008/9/17 via RT NotFound [EMAIL PROTECTED]:
 # New Ticket Created by  NotFound
 # Please include the string:  [perl #58988]
 # in the subject line of all future correspondence about this issue.
 # URL: http://rt.perl.org/rt3/Ticket/Display.html?id=58988 


 The Parrot_get_runtime_prefix in src/library.c return a char *,
 forcing the places that currently uses it to be more complicated than
 desired for no real gain. I added and used a STRING * variant named
 Parrot_get_runtime_path (that name makes more sense to me) in r31216

prefix is the critical config entry which defines the root for the
various library searches.
And this is the only part which is changed for installables
And runtime_prefix defines the prefix to the runtime. This name makes
a lot of sense.

path is something different. There are three paths after the prefix, not one.
I recommend to keep the old name.

-- 
Reini Urban
http://phpwiki.org/  http://murbreak.at/


Re: [perl #58988] [RFC] Parrot_get_runtime_prefix function

2008-10-20 Thread NotFound
 'STRING *' is vastly preferable to 'char *' anywhere it can be used.
 Mark the old one as deprecated, replace all calls to
 'Parrot_get_runtime_prefix' with calls to 'Parrot_get_runtime_path', and
 after a standard one release deprecation cycle remove the old function.

Replaced a remaining usage and added a note in the =item of
Parrot_get_runtime_prefix about his deprecation in r32054

-- 
Salu2


Re: [perl #58988] [RFC] Parrot_get_runtime_prefix function

2008-10-19 Thread Allison Randal

NotFound (via RT) wrote:


The Parrot_get_runtime_prefix in src/library.c return a char *,
forcing the places that currently uses it to be more complicated than
desired for no real gain. I added and used a STRING * variant named
Parrot_get_runtime_path (that name makes more sense to me) in r31216

The question is: must we retain the old variant, kill it, deprecate
it, use his name for the new version, or revert the change and stay
with the char * way?


'STRING *' is vastly preferable to 'char *' anywhere it can be used. 
Mark the old one as deprecated, replace all calls to 
'Parrot_get_runtime_prefix' with calls to 'Parrot_get_runtime_path', and 
after a standard one release deprecation cycle remove the old function.


Allison


[perl #58988] [RFC] Parrot_get_runtime_prefix function

2008-09-18 Thread via RT
# New Ticket Created by  NotFound 
# Please include the string:  [perl #58988]
# in the subject line of all future correspondence about this issue. 
# URL: http://rt.perl.org/rt3/Ticket/Display.html?id=58988 


The Parrot_get_runtime_prefix in src/library.c return a char *,
forcing the places that currently uses it to be more complicated than
desired for no real gain. I added and used a STRING * variant named
Parrot_get_runtime_path (that name makes more sense to me) in r31216

The question is: must we retain the old variant, kill it, deprecate
it, use his name for the new version, or revert the change and stay
with the char * way?

-- 
Salu2