Re: [petsc-dev] proposed minor PetscPartitioner changes

On 6 November 2017 at 16:37, Matthew Knepley wrote: > On Mon, Nov 6, 2017 at 8:34 AM, Smith, Barry F. wrote: >> >>MatPartitioning is NOT about partitioning MATRICES it is about >> partitioning GRAPHS, so it can support anything related to graphs

Re: [petsc-dev] broken nightlybuilds (next vs next-tmp)

On Mon, 6 Nov 2017, Satish Balay wrote: > On Sun, 5 Nov 2017, Satish Balay wrote: > > > > origin/jed/fix-stdout-attr-delete > > > origin/jed/pastix-comm > > > origin/mark/fix-mat > > > > These are now merged to master. > > Jed, Mark, > > The above branches appear to have started from

Re: [petsc-dev] broken nightlybuilds (next vs next-tmp)

On Mon, 6 Nov 2017, Jed Brown wrote: > > $ git fetch -p && comm -12 <(git branch -r --merged origin/next-tmp | sort) > > <(git branch -r --no-merged origin/master | sort) > > origin/barry/delete-adjoint-trajectory > > origin/barry/remove-unneeded-use-of-petscdatatype > >

Re: [petsc-dev] CMake: make, install, find_package ?

On Mon, Nov 6, 2017 at 12:49 PM, Franck Houssen wrote: > - Mail original - > > De: "Satish Balay" > > À: "Franck Houssen" > > Cc: "petsc-dev" > > Envoyé: Lundi 6 Novembre 2017 16:08:55 > >

Re: [petsc-dev] broken nightlybuilds (next vs next-tmp)

Satish Balay writes: > On Sun, 5 Nov 2017, Satish Balay wrote: > >> > $ git fetch -p && comm -12 <(git branch -r --merged origin/next-tmp | >> > sort) <(git branch -r --no-merged origin/master | sort) >> > origin/hongzh/copy_l2g_stencil >> >

Re: [petsc-dev] CMake: make, install, find_package ?

- Mail original - > De: "Satish Balay" > À: "Franck Houssen" > Cc: "petsc-dev" > Envoyé: Lundi 6 Novembre 2017 16:08:55 > Objet: Re: [petsc-dev] CMake: make, install, find_package ? > > On Mon, 6 Nov 2017, Franck

Re: [petsc-dev] proposed minor PetscPartitioner changes

> 6. 11. 2017 v 14:37, Smith, Barry F. : > > > >> On Nov 6, 2017, at 7:30 AM, Vaclav Hapla wrote: >> >> >>> 6. 11. 2017 v 14:27, Matthew Knepley : >>> >>> On Mon, Nov 6, 2017 at 8:24 AM, Smith, Barry F.

Re: [petsc-dev] is this wrong?

On Mon, Nov 6, 2017 at 9:54 AM, Smith, Barry F. wrote: > >Hmm, I think this perhaps an issue of documentation. > >It seems the various PetscOptionsGetXXX() DO NOT set the value unless > the options database indicates it should be set (and when the options > database

Re: [petsc-dev] broken nightlybuilds (next vs next-tmp)

On Sun, 5 Nov 2017, Satish Balay wrote: > > $ git fetch -p && comm -12 <(git branch -r --merged origin/next-tmp | sort) > > <(git branch -r --no-merged origin/master | sort) > > origin/hongzh/copy_l2g_stencil > > origin/jed/fix-dmcoarsenhookadd-identical > >

Re: [petsc-dev] is this wrong?

On Mon, Nov 6, 2017 at 9:39 AM, Lisandro Dalcin wrote: > Did you mean > > *flg = currentvalue; > > ? > yes > > On 6 November 2017 at 17:25, Mark Adams wrote: > > This code looks wrong. I get a valgrind warning if the option is not > set. I > > think this

Re: [petsc-dev] broken nightlybuilds (next vs next-tmp)

Should this be considered standard practice for all contributors? On Mon, Nov 6, 2017 at 4:19 PM, Satish Balay wrote: > On Sun, 5 Nov 2017, Satish Balay wrote: > > > > origin/jed/fix-stdout-attr-delete > > > origin/jed/pastix-comm > > > origin/mark/fix-mat > > > > These

Re: [petsc-dev] broken nightlybuilds (next vs next-tmp)

On Sun, 5 Nov 2017, Satish Balay wrote: > > origin/jed/fix-stdout-attr-delete > > origin/jed/pastix-comm > > origin/mark/fix-mat > > These are now merged to master. Jed, Mark, The above branches appear to have started from maint. Are they destined to maint? If so it would be good to

Re: [petsc-dev] CMake: make, install, find_package ?

On Mon, 6 Nov 2017, Franck Houssen wrote: > > Yes ! Your friend let you the keys of his car. The car has no wheel. Why did > he gave you his keys ?!... :D (joking) Actually - its more akin to - friend gives you a car - and leaves the keys in the console, with instructions there. However you

Re: [petsc-dev] is this wrong?

Hmm, I think this perhaps an issue of documentation. It seems the various PetscOptionsGetXXX() DO NOT set the value unless the options database indicates it should be set (and when the options database does indicate it has been set the set flag is set). But this is only documented

Re: [petsc-dev] is this wrong?

Did you mean *flg = currentvalue; ? On 6 November 2017 at 17:25, Mark Adams wrote: > This code looks wrong. I get a valgrind warning if the option is not set. I > think this code should be added. > > PetscErrorCode PetscOptionsBool_Private(PetscOptionItems >

[petsc-dev] is this wrong?

This code looks wrong. I get a valgrind warning if the option is not set. *I think this code should be added.* PetscErrorCode PetscOptionsBool_Private(PetscOptionItems *PetscOptionsObject,const char opt[],const char text[],const char man[],PetscBool currentvalue,PetscBool *flg,PetscBool *set)

Re: [petsc-dev] proposed minor PetscPartitioner changes

On Mon, Nov 6, 2017 at 8:34 AM, Smith, Barry F. wrote: > > On Nov 6, 2017, at 7:27 AM, Matthew Knepley wrote: > > > > On Mon, Nov 6, 2017 at 8:24 AM, Smith, Barry F. > wrote: > > > >Vaclav, > > > > Actually you should not

Re: [petsc-dev] proposed minor PetscPartitioner changes

> On Nov 6, 2017, at 7:30 AM, Vaclav Hapla wrote: > > >> 6. 11. 2017 v 14:27, Matthew Knepley : >> >> On Mon, Nov 6, 2017 at 8:24 AM, Smith, Barry F. wrote: >> >>Vaclav, >> >> Actually you should not just do this!

Re: [petsc-dev] proposed minor PetscPartitioner changes

> On Nov 6, 2017, at 7:27 AM, Matthew Knepley wrote: > > On Mon, Nov 6, 2017 at 8:24 AM, Smith, Barry F. wrote: > >Vaclav, > > Actually you should not just do this! PETSc already has a full class > for managing partitioning (that Matt

Re: [petsc-dev] proposed minor PetscPartitioner changes

> 6. 11. 2017 v 14:27, Matthew Knepley : > > On Mon, Nov 6, 2017 at 8:24 AM, Smith, Barry F. > wrote: > >Vaclav, > > Actually you should not just do this! PETSc already has a full class > for managing partitioning

Re: [petsc-dev] proposed minor PetscPartitioner changes

Vaclav, Please don't do this as proposed. Please learn about all the partitioner interfaces in PETSc before attempting a refactorization. Barry > On Nov 6, 2017, at 7:25 AM, Matthew Knepley wrote: > > On Mon, Nov 6, 2017 at 8:09 AM, Vaclav Hapla

Re: [petsc-dev] proposed minor PetscPartitioner changes

On Mon, Nov 6, 2017 at 8:24 AM, Smith, Barry F. wrote: > >Vaclav, > > Actually you should not just do this! PETSc already has a full class > for managing partitioning (that Matt ignored for no good reason) Obviously, a good reason existed. All sorts of horrible

Re: [petsc-dev] proposed minor PetscPartitioner changes

On Mon, Nov 6, 2017 at 8:09 AM, Vaclav Hapla wrote: > Hello > > The whole PetscPartitioner class sources are part of > src/dm/impls/plex/plexpartition.c, > mixed together with some DMPlex* functions. > If you don't mind, I would move the PetscPartitioner* stuff into

Re: [petsc-dev] proposed minor PetscPartitioner changes

Vaclav, Actually you should not just do this! PETSc already has a full class for managing partitioning (that Matt ignored for no good reason) see MatPartitioningCreate(). Please look at all the functionality before doing anything. Any refactorization you do needs to combine,

[petsc-dev] proposed minor PetscPartitioner changes

Hello The whole PetscPartitioner class sources are part of src/dm/impls/plex/plexpartition.c, mixed together with some DMPlex* functions. If you don't mind, I would move the PetscPartitioner* stuff into the separate file petscpartitioner.c (in future, it could be even moved to a separate

Re: [petsc-dev] DMPlexCreateMedFromFile broken

> 5. 11. 2017 v 18:48, Matthew Knepley : > > On Thu, Nov 2, 2017 at 12:08 PM, Vaclav Hapla > wrote: > It seems that DMPlexCreateMedFromFile leaves out some mesh elements. I found > it out when investigating why

Re: [petsc-dev] CMake: make, install, find_package ?

Looks like you had a bad experience with CMake up to a point of no return (probably a shame, but, I can understand that !). I will use pkg-config: that's fine to me. I was just trying to help here for sake of community ! No more, no less ! Franck - Mail original - > De: "Satish Balay"