Re: [petsc-dev] [petsc-users] PetscPrintf

2018-04-15 Thread Smith, Barry F.
Very small step in the correct direction https://bitbucket.org/petsc/petsc/pull-requests/931/barry-bugfix-petscformatconvert/diff > On Apr 15, 2018, at 5:41 AM, Patrick Sanan wrote: > > How about the logic of this analysis? > > 1. We are trying to use the same

Re: [petsc-dev] [petsc-users] PetscPrintf

2018-04-15 Thread Smith, Barry F.
To me the difficulty is knowing how large an array to allocate (in both PetscVSNPrintf() and PetscVFPrintfDefault()). The macro PETSC_MAX_LENGTH_FORMAT() is used in PetscVSNPrintf() but it has nothing to do with reality. One could walk through the formats (and their string values) to get

Re: [petsc-dev] [petsc-users] PetscPrintf

2018-04-15 Thread Patrick Sanan
How about the logic of this analysis? 1. We are trying to use the same functions (in particular, PetscVFPrintf) for two purposes: a. printing error messages (don't want to malloc) b. use by public API printing functions (don't want length restrictions) 2. Right now, PetscVFPrintf works