I will open an MR then
Il giorno mar 23 mar 2021 alle ore 22:42 Matthew Knepley
ha scritto:
>
> On Tue, Mar 23, 2021 at 1:15 PM Junchao Zhang
> wrote:
>
>> Can we combine CXXPPFLAGS and CXXFLAGS into one CXXFLAGS?
>>
>
> No. There are compiler-only flags.
>
> Matt
>
>
>> --Junchao Zhang
>>
On Tue, Mar 23, 2021 at 1:15 PM Junchao Zhang
wrote:
> Can we combine CXXPPFLAGS and CXXFLAGS into one CXXFLAGS?
>
No. There are compiler-only flags.
Matt
> --Junchao Zhang
>
>
> On Tue, Mar 23, 2021 at 11:38 AM Patrick Sanan
> wrote:
>
>> I had a related (I think) issue trying to build
And I think there are some flags that can't be used at link time [so
they have to go into CPPFLAGS and not CFLAGS - as CFLAGS gets used
with CLINKER aswell]
Satish
On Tue, 23 Mar 2021, Satish Balay via petsc-dev wrote:
> I'm not sure if we can eliminate preprocessing. [mpi.h detection is
> one
I'm not sure if we can eliminate preprocessing. [mpi.h detection is
one place where its used - don't remember others - perhaps detection
of most includes? - some externalpacakges need them listed
separately?]
And as long as we need preprocessing as a separate step [and some
compile flags give
Can we combine CXXPPFLAGS and CXXFLAGS into one CXXFLAGS?
--Junchao Zhang
On Tue, Mar 23, 2021 at 11:38 AM Patrick Sanan
wrote:
> I had a related (I think) issue trying to build with Kokkos. Those headers
> throw an #error if they're expecting OpenMP and the compiler doesn't have
> the OpenMP
I had a related (I think) issue trying to build with Kokkos. Those headers
throw an #error if they're expecting OpenMP and the compiler doesn't have the
OpenMP flag. I have an open MR here (number 60^2!) which thus adds the OpenMP
flag to the CXXPPFLAGS:
The check fails within buildsystem when running mpicc -E (which uses
CXXPPFLAGS) The package header needs c++11 to be included properly. C++11
is also needed at preprocessing time
Il Mar 23 Mar 2021, 18:59 Satish Balay ha scritto:
> -std=cxx11 for sure is a compile flag. But don't really know
-std=cxx11 for sure is a compile flag. But don't really know if its
also needed at pre-process stage and/or at link stage.
And for compile stage both CXXFLAGS and CXXPPFLAGS should get
used. [PETSc makefiles make sure this is the case]
And for link stage CXXFLAGS and LDFLAGS get used [but then
I would rather directly change the project to use CXXFLAGS instead of
CXXPPFLAGS.
--Junchao Zhang
On Tue, Mar 23, 2021 at 10:01 AM Satish Balay via petsc-dev <
petsc-dev@mcs.anl.gov> wrote:
> On Tue, 23 Mar 2021, Stefano Zampini wrote:
>
> > Just tried out of main, and and the include tests of
On Tue, 23 Mar 2021, Stefano Zampini wrote:
> Just tried out of main, and and the include tests of a c++11 project fail
> Below my fix, if we agree on, I'll make a MR
>
> diff --git a/config/BuildSystem/config/compilers.py
> b/config/BuildSystem/config/compilers.py
> index c96967e..44e4657
Just tried out of main, and and the include tests of a c++11 project fail
Below my fix, if we agree on, I'll make a MR
diff --git a/config/BuildSystem/config/compilers.py
b/config/BuildSystem/config/compilers.py
index c96967e..44e4657 100644
--- a/config/BuildSystem/config/compilers.py
+++
11 matches
Mail list logo
