Re: [petsc-dev] Remove legacy tests

[Satish Balay]

Great. Thanks!

Satish

On Fri, 7 Sep 2018, Jose E. Roman wrote:

> It is in master now, so the error should be fixed.
> Jose
> 
> 
> > El 7 sept 2018, a las 3:02, Satish Balay  escribió:
> > 
> > I see the relvent slepc changes are in alex/test-harness
> > 
> > I've merged balay/remove-Regression.py branch into petsc master. So current 
> > slepc master [with petsc master] gives:
> > 
> > 
> > Checking environment... done
> > Checking PETSc installation... done
> > Checking ARPACK... done
> > Checking LAPACK library... Traceback (most recent call last):
> >  File "./configure", line 10, in 
> >execfile(os.path.join(os.path.dirname(__file__), 'config', 
> > 'configure.py'))
> >  File "./config/configure.py", line 321, in 
> >testruns = set(petsc.test_runs.split())
> > AttributeError: PETSc instance has no attribute 'test_runs'
> > 
> > 
> > This issue comes up with xsdk@develop - but I can work arround it.
> > 
> > Satish
> > 
> > On Wed, 5 Sep 2018, Jose E. Roman wrote:
> > 
> >> It works for us. Thanks.
> >> Jose
> >> 
> >> 
> >>> El 5 sept 2018, a las 15:15, Satish Balay  escribió:
> >>> 
> >>> I pushed the change to balay/remove-Regression.py
> >>> 
> >>> Satish
> >>> 
> >>> On Mon, 3 Sep 2018, Jose E. Roman wrote:
> >>> 
>  We are almost done with migrating SLEPc tests to the new test harness. 
>  If you want, you can remove Regression.py from PETSc, as well as any 
>  makefile rules that might remain for legacy tests.
>  
>  Jose
>  
> >>> 
> >> 
> 

Re: [petsc-dev] Remove legacy tests

[Jose E. Roman]

It is in master now, so the error should be fixed.
Jose


> El 7 sept 2018, a las 3:02, Satish Balay  escribió:
> 
> I see the relvent slepc changes are in alex/test-harness
> 
> I've merged balay/remove-Regression.py branch into petsc master. So current 
> slepc master [with petsc master] gives:
> 
> 
> Checking environment... done
> Checking PETSc installation... done
> Checking ARPACK... done
> Checking LAPACK library... Traceback (most recent call last):
>  File "./configure", line 10, in 
>execfile(os.path.join(os.path.dirname(__file__), 'config', 'configure.py'))
>  File "./config/configure.py", line 321, in 
>testruns = set(petsc.test_runs.split())
> AttributeError: PETSc instance has no attribute 'test_runs'
> 
> 
> This issue comes up with xsdk@develop - but I can work arround it.
> 
> Satish
> 
> On Wed, 5 Sep 2018, Jose E. Roman wrote:
> 
>> It works for us. Thanks.
>> Jose
>> 
>> 
>>> El 5 sept 2018, a las 15:15, Satish Balay  escribió:
>>> 
>>> I pushed the change to balay/remove-Regression.py
>>> 
>>> Satish
>>> 
>>> On Mon, 3 Sep 2018, Jose E. Roman wrote:
>>> 
 We are almost done with migrating SLEPc tests to the new test harness. If 
 you want, you can remove Regression.py from PETSc, as well as any makefile 
 rules that might remain for legacy tests.
 
 Jose
 
>>> 
>> 

Re: [petsc-dev] Remove legacy tests

[Satish Balay]

I see the relvent slepc changes are in alex/test-harness

I've merged balay/remove-Regression.py branch into petsc master. So current 
slepc master [with petsc master] gives:


Checking environment... done
Checking PETSc installation... done
Checking ARPACK... done
Checking LAPACK library... Traceback (most recent call last):
  File "./configure", line 10, in 
execfile(os.path.join(os.path.dirname(__file__), 'config', 'configure.py'))
  File "./config/configure.py", line 321, in 
testruns = set(petsc.test_runs.split())
AttributeError: PETSc instance has no attribute 'test_runs'


This issue comes up with xsdk@develop - but I can work arround it.

Satish

On Wed, 5 Sep 2018, Jose E. Roman wrote:

> It works for us. Thanks.
> Jose
> 
> 
> > El 5 sept 2018, a las 15:15, Satish Balay  escribió:
> > 
> > I pushed the change to balay/remove-Regression.py
> > 
> > Satish
> > 
> > On Mon, 3 Sep 2018, Jose E. Roman wrote:
> > 
> >> We are almost done with migrating SLEPc tests to the new test harness. If 
> >> you want, you can remove Regression.py from PETSc, as well as any makefile 
> >> rules that might remain for legacy tests.
> >> 
> >> Jose
> >> 
> > 
> 

Re: [petsc-dev] Remove legacy tests

[Jose E. Roman]

It works for us. Thanks.
Jose


> El 5 sept 2018, a las 15:15, Satish Balay  escribió:
> 
> I pushed the change to balay/remove-Regression.py
> 
> Satish
> 
> On Mon, 3 Sep 2018, Jose E. Roman wrote:
> 
>> We are almost done with migrating SLEPc tests to the new test harness. If 
>> you want, you can remove Regression.py from PETSc, as well as any makefile 
>> rules that might remain for legacy tests.
>> 
>> Jose
>> 
> 

Re: [petsc-dev] Remove legacy tests

[Satish Balay]

I pushed the change to balay/remove-Regression.py

Satish

On Mon, 3 Sep 2018, Jose E. Roman wrote:

> We are almost done with migrating SLEPc tests to the new test harness. If you 
> want, you can remove Regression.py from PETSc, as well as any makefile rules 
> that might remain for legacy tests.
> 
> Jose
> 

Re: [petsc-dev] Remove legacy tests?

[Satish Balay]

Or is the issue with the name "lib/petsc/conf/test"?

I guess it could be renamed lib/petsc/conf/rules_examples [or something else]

Satish


On Sat, 7 Jul 2018, Satish Balay wrote:

> Sorry - I don't quiet understand what you are suggesting here. 
> 
> On Thu, 5 Jul 2018, Jed Brown wrote:
> 
> > "Smith, Barry F."  writes:
> > 
> > >> On Jul 5, 2018, at 5:36 PM, Jed Brown  wrote:
> > >> 
> > >> When can we delete the legacy test system?  Are we currently using it
> > >> anywhere?
> > >
> > >   Make test currently requires the test include file
> > 
> > Surely this indirection and logging isn't needed in all the
> > */examples/tutorials/makefile.
> 
> Are you suggesting the following change?
> 
> diff --git a/lib/petsc/conf/test b/lib/petsc/conf/test
> index 3942d879ad..8cd6fcd238 100644
> --- a/lib/petsc/conf/test
> +++ b/lib/petsc/conf/test
> @@ -11,7 +11,3 @@ ex%f: ex%f.o | chkopts
> -${FLINKER} -o $@ $^  ${PETSC_LIB}
>  ex%: ex%.o | chkopts
> -${CLINKER} -o $@ $^  ${PETSC_LIB}
> -
> -
> -include ${PETSC_DIR}/lib/petsc/conf/test.common
> -
> 
> > 
> > TESTMODE = testexamples
> > ALLTESTS_CHECK_FAILURES = no
> > ALLTESTS_MAKEFILE = gmakefile.test
> > alltests:
> > -@${RM} -rf ${PETSC_ARCH}/lib/petsc/conf/alltests.log alltests.log
> > +@if [ -f ${PETSC_DIR}/share/petsc/examples/gmakefile.test ] ; then 
> > \
> > 
> > ALLTESTS_MAKEFILE=${PETSC_DIR}/share/petsc/examples/gmakefile.test ; \
> > ALLTESTSLOG=alltests.log ;\
> >   else \
> > ALLTESTS_MAKEFILE=gmakefile.test; \
> > ALLTESTSLOG=${PETSC_ARCH}/lib/petsc/conf/alltests.log ;\
> > ln -s $${ALLTESTSLOG} alltests.log ;\
> >   fi; \
> >   ${OMAKE} allgtest ALLTESTS_MAKEFILE=$${ALLTESTS_MAKEFILE} 
> > PETSC_ARCH=${PETSC_ARCH} PETSC_DIR=${PETSC_DIR} MPIEXEC="${MPIEXEC}" 
> > DATAFILESPATH=${DATAFILESPATH} 2>&1 | tee $${ALLTESTSLOG};\
> >   if [ x${ALLTESTS_CHECK_FAILURES} = xyes -a ${PETSC_PRECISION} != 
> > single ]; then \
> > cat $${ALLTESTSLOG} | egrep '(^not ok|not remade because of 
> > errors|^# No tests run)' | wc -l | grep '^[ ]*0$$' > /dev/null; \
> >   fi;
> > 
> > allgtest-tap:
> > +@MAKEFLAGS="-j$(MAKE_TEST_NP) -l$(MAKE_LOAD) $(MAKEFLAGS)" 
> > ${OMAKE} -f gmakefile.test test V=0
> > 
> > allgtest:
> > +@MAKEFLAGS="-j$(MAKE_TEST_NP) -l$(MAKE_LOAD) $(MAKEFLAGS)" 
> > ${OMAKE} -k -f ${ALLTESTS_MAKEFILE} test V=0 2>&1 | egrep -v '^(ok [^#]*(# 
> > SKIP|# TODO|$$)|[A-Za-z][A-Za-z0-9_]*\.(c|F|cxx|F90).$$)'
> > 
> > 
> > 
> > We could use static pattern rules of the form
> > 
> >   $(EXAMPLESC) : % : %.c
> 
> Sorry - I don't understand this nottation. What does this do? And what is it 
> a replacement for?
> 
> 
> > and add them to lib/petsc/conf/rules.  It isn't really for testing at
> > this point, just for one-off building.
> 
> We have some rules [for examples] in lib/petsc/conf/test. Are you
> objecting to having this separate file for this? [since you are
> recommending having them in lib/petsc/conf/rules]
> 
> One of the reason I kept it separate is - it has gnumake syntax so
> didn't want it included from the toplevel makefile - [which is free of
> gnumake syntax]
> 
> satish
> 

Re: [petsc-dev] Remove legacy tests?

[Satish Balay]

Sorry - I don't quiet understand what you are suggesting here. 

On Thu, 5 Jul 2018, Jed Brown wrote:

> "Smith, Barry F."  writes:
> 
> >> On Jul 5, 2018, at 5:36 PM, Jed Brown  wrote:
> >> 
> >> When can we delete the legacy test system?  Are we currently using it
> >> anywhere?
> >
> >   Make test currently requires the test include file
> 
> Surely this indirection and logging isn't needed in all the
> */examples/tutorials/makefile.

Are you suggesting the following change?

diff --git a/lib/petsc/conf/test b/lib/petsc/conf/test
index 3942d879ad..8cd6fcd238 100644
--- a/lib/petsc/conf/test
+++ b/lib/petsc/conf/test
@@ -11,7 +11,3 @@ ex%f: ex%f.o | chkopts
-${FLINKER} -o $@ $^  ${PETSC_LIB}
 ex%: ex%.o | chkopts
-${CLINKER} -o $@ $^  ${PETSC_LIB}
-
-
-include ${PETSC_DIR}/lib/petsc/conf/test.common
-

> 
> TESTMODE = testexamples
> ALLTESTS_CHECK_FAILURES = no
> ALLTESTS_MAKEFILE = gmakefile.test
> alltests:
> -@${RM} -rf ${PETSC_ARCH}/lib/petsc/conf/alltests.log alltests.log
> +@if [ -f ${PETSC_DIR}/share/petsc/examples/gmakefile.test ] ; then \
> 
> ALLTESTS_MAKEFILE=${PETSC_DIR}/share/petsc/examples/gmakefile.test ; \
> ALLTESTSLOG=alltests.log ;\
>   else \
> ALLTESTS_MAKEFILE=gmakefile.test; \
> ALLTESTSLOG=${PETSC_ARCH}/lib/petsc/conf/alltests.log ;\
> ln -s $${ALLTESTSLOG} alltests.log ;\
>   fi; \
>   ${OMAKE} allgtest ALLTESTS_MAKEFILE=$${ALLTESTS_MAKEFILE} 
> PETSC_ARCH=${PETSC_ARCH} PETSC_DIR=${PETSC_DIR} MPIEXEC="${MPIEXEC}" 
> DATAFILESPATH=${DATAFILESPATH} 2>&1 | tee $${ALLTESTSLOG};\
>   if [ x${ALLTESTS_CHECK_FAILURES} = xyes -a ${PETSC_PRECISION} != 
> single ]; then \
> cat $${ALLTESTSLOG} | egrep '(^not ok|not remade because of 
> errors|^# No tests run)' | wc -l | grep '^[ ]*0$$' > /dev/null; \
>   fi;
> 
> allgtest-tap:
> +@MAKEFLAGS="-j$(MAKE_TEST_NP) -l$(MAKE_LOAD) $(MAKEFLAGS)" ${OMAKE} 
> -f gmakefile.test test V=0
> 
> allgtest:
> +@MAKEFLAGS="-j$(MAKE_TEST_NP) -l$(MAKE_LOAD) $(MAKEFLAGS)" ${OMAKE} 
> -k -f ${ALLTESTS_MAKEFILE} test V=0 2>&1 | egrep -v '^(ok [^#]*(# SKIP|# 
> TODO|$$)|[A-Za-z][A-Za-z0-9_]*\.(c|F|cxx|F90).$$)'
> 
> 
> 
> We could use static pattern rules of the form
> 
>   $(EXAMPLESC) : % : %.c

Sorry - I don't understand this nottation. What does this do? And what is it a 
replacement for?


> and add them to lib/petsc/conf/rules.  It isn't really for testing at
> this point, just for one-off building.

We have some rules [for examples] in lib/petsc/conf/test. Are you
objecting to having this separate file for this? [since you are
recommending having them in lib/petsc/conf/rules]

One of the reason I kept it separate is - it has gnumake syntax so
didn't want it included from the toplevel makefile - [which is free of
gnumake syntax]

satish

Re: [petsc-dev] Remove legacy tests?

[Smith, Barry F.]

   I'm fine with stripping out as much of the old test stuff as reasonably 
possible.

   Barry


> On Jul 5, 2018, at 8:36 PM, Jed Brown  wrote:
> 
> "Smith, Barry F."  writes:
> 
>>> On Jul 5, 2018, at 5:36 PM, Jed Brown  wrote:
>>> 
>>> When can we delete the legacy test system?  Are we currently using it
>>> anywhere?
>> 
>>  Make test currently requires the test include file
> 
> Surely this indirection and logging isn't needed in all the
> */examples/tutorials/makefile.
> 
> TESTMODE = testexamples
> ALLTESTS_CHECK_FAILURES = no
> ALLTESTS_MAKEFILE = gmakefile.test
> alltests:
>-@${RM} -rf ${PETSC_ARCH}/lib/petsc/conf/alltests.log alltests.log
>+@if [ -f ${PETSC_DIR}/share/petsc/examples/gmakefile.test ] ; then \
>ALLTESTS_MAKEFILE=${PETSC_DIR}/share/petsc/examples/gmakefile.test 
> ; \
>ALLTESTSLOG=alltests.log ;\
>  else \
>ALLTESTS_MAKEFILE=gmakefile.test; \
>ALLTESTSLOG=${PETSC_ARCH}/lib/petsc/conf/alltests.log ;\
>ln -s $${ALLTESTSLOG} alltests.log ;\
>  fi; \
>  ${OMAKE} allgtest ALLTESTS_MAKEFILE=$${ALLTESTS_MAKEFILE} 
> PETSC_ARCH=${PETSC_ARCH} PETSC_DIR=${PETSC_DIR} MPIEXEC="${MPIEXEC}" 
> DATAFILESPATH=${DATAFILESPATH} 2>&1 | tee $${ALLTESTSLOG};\
>  if [ x${ALLTESTS_CHECK_FAILURES} = xyes -a ${PETSC_PRECISION} != 
> single ]; then \
>cat $${ALLTESTSLOG} | egrep '(^not ok|not remade because of 
> errors|^# No tests run)' | wc -l | grep '^[ ]*0$$' > /dev/null; \
>  fi;
> 
> allgtest-tap:
>+@MAKEFLAGS="-j$(MAKE_TEST_NP) -l$(MAKE_LOAD) $(MAKEFLAGS)" ${OMAKE} 
> -f gmakefile.test test V=0
> 
> allgtest:
>+@MAKEFLAGS="-j$(MAKE_TEST_NP) -l$(MAKE_LOAD) $(MAKEFLAGS)" ${OMAKE} 
> -k -f ${ALLTESTS_MAKEFILE} test V=0 2>&1 | egrep -v '^(ok [^#]*(# SKIP|# 
> TODO|$$)|[A-Za-z][A-Za-z0-9_]*\.(c|F|cxx|F90).$$)'
> 
> 
> 
> We could use static pattern rules of the form
> 
>  $(EXAMPLESC) : % : %.c
> 
> and add them to lib/petsc/conf/rules.  It isn't really for testing at
> this point, just for one-off building.

Re: [petsc-dev] Remove legacy tests?

[Jed Brown]

"Smith, Barry F."  writes:

>> On Jul 5, 2018, at 5:36 PM, Jed Brown  wrote:
>> 
>> When can we delete the legacy test system?  Are we currently using it
>> anywhere?
>
>   Make test currently requires the test include file

Surely this indirection and logging isn't needed in all the
*/examples/tutorials/makefile.

TESTMODE = testexamples
ALLTESTS_CHECK_FAILURES = no
ALLTESTS_MAKEFILE = gmakefile.test
alltests:
-@${RM} -rf ${PETSC_ARCH}/lib/petsc/conf/alltests.log alltests.log
+@if [ -f ${PETSC_DIR}/share/petsc/examples/gmakefile.test ] ; then \
ALLTESTS_MAKEFILE=${PETSC_DIR}/share/petsc/examples/gmakefile.test 
; \
ALLTESTSLOG=alltests.log ;\
  else \
ALLTESTS_MAKEFILE=gmakefile.test; \
ALLTESTSLOG=${PETSC_ARCH}/lib/petsc/conf/alltests.log ;\
ln -s $${ALLTESTSLOG} alltests.log ;\
  fi; \
  ${OMAKE} allgtest ALLTESTS_MAKEFILE=$${ALLTESTS_MAKEFILE} 
PETSC_ARCH=${PETSC_ARCH} PETSC_DIR=${PETSC_DIR} MPIEXEC="${MPIEXEC}" 
DATAFILESPATH=${DATAFILESPATH} 2>&1 | tee $${ALLTESTSLOG};\
  if [ x${ALLTESTS_CHECK_FAILURES} = xyes -a ${PETSC_PRECISION} != 
single ]; then \
cat $${ALLTESTSLOG} | egrep '(^not ok|not remade because of 
errors|^# No tests run)' | wc -l | grep '^[ ]*0$$' > /dev/null; \
  fi;

allgtest-tap:
+@MAKEFLAGS="-j$(MAKE_TEST_NP) -l$(MAKE_LOAD) $(MAKEFLAGS)" ${OMAKE} -f 
gmakefile.test test V=0

allgtest:
+@MAKEFLAGS="-j$(MAKE_TEST_NP) -l$(MAKE_LOAD) $(MAKEFLAGS)" ${OMAKE} -k 
-f ${ALLTESTS_MAKEFILE} test V=0 2>&1 | egrep -v '^(ok [^#]*(# SKIP|# 
TODO|$$)|[A-Za-z][A-Za-z0-9_]*\.(c|F|cxx|F90).$$)'



We could use static pattern rules of the form

  $(EXAMPLESC) : % : %.c

and add them to lib/petsc/conf/rules.  It isn't really for testing at
this point, just for one-off building.

Re: [petsc-dev] Remove legacy tests?

[Satish Balay]

I think SLEPc primarily  relies on regression.py in configure.

${PETSC_DIR}/lib/petsc/conf/test has targets to support:
cd src/ksp/ksp/examples/tutorials
make ex2

and ${PETSC_DIR}/lib/petsc/conf/test.common has targets to support:

make alltests [used by nightlybuilds]

Satish

On Fri, 6 Jul 2018, Jose E. Roman wrote:

> Well, if you want to remove it, I can just insert 
> ${PETSC_DIR}/lib/petsc/conf/test in SLEPc's repository, so not a big problem.
> 
> 
> > El 6 jul 2018, a las 7:46, Jose E. Roman  escribió:
> > 
> > SLEPc still uses the legacy test system. I have not had time to move to the 
> > new test harness.
> > Jose
> > 
> > 
> >> El 6 jul 2018, a las 2:42, Smith, Barry F.  escribió:
> >> 
> >> 
> >> 
> >>> On Jul 5, 2018, at 5:36 PM, Jed Brown  wrote:
> >>> 
> >>> When can we delete the legacy test system?  Are we currently using it
> >>> anywhere?
> >> 
> >> Make test currently requires the test include file
> >> 
> >>  Barry
> >> 
> >> 
> > 
> 

Re: [petsc-dev] Remove legacy tests?

[Jose E. Roman]

Well, if you want to remove it, I can just insert 
${PETSC_DIR}/lib/petsc/conf/test in SLEPc's repository, so not a big problem.


> El 6 jul 2018, a las 7:46, Jose E. Roman  escribió:
> 
> SLEPc still uses the legacy test system. I have not had time to move to the 
> new test harness.
> Jose
> 
> 
>> El 6 jul 2018, a las 2:42, Smith, Barry F.  escribió:
>> 
>> 
>> 
>>> On Jul 5, 2018, at 5:36 PM, Jed Brown  wrote:
>>> 
>>> When can we delete the legacy test system?  Are we currently using it
>>> anywhere?
>> 
>> Make test currently requires the test include file
>> 
>>  Barry
>> 
>> 
> 

Re: [petsc-dev] Remove legacy tests?

[Jose E. Roman]

SLEPc still uses the legacy test system. I have not had time to move to the new 
test harness.
Jose


> El 6 jul 2018, a las 2:42, Smith, Barry F.  escribió:
> 
> 
> 
>> On Jul 5, 2018, at 5:36 PM, Jed Brown  wrote:
>> 
>> When can we delete the legacy test system?  Are we currently using it
>> anywhere?
> 
>  Make test currently requires the test include file
> 
>   Barry
> 
> 

Re: [petsc-dev] Remove legacy tests?

[Smith, Barry F.]

> On Jul 5, 2018, at 5:36 PM, Jed Brown  wrote:
> 
> When can we delete the legacy test system?  Are we currently using it
> anywhere?

  Make test currently requires the test include file

   Barry

Re: [petsc-dev] Remove legacy tests?

[Matthew Knepley]

On Thu, Jul 5, 2018 at 6:07 PM Satish Balay  wrote:

> Ok - there is some confusion here.
>
> The test harness does not use targets in
> examples/[tests,tutorials]/makefile.
>
> However we want to keep the functionality of us/users compiling
> individual examples manually - without going through the test harness.
>
> i.e the following should continue to work:
>
> cd src/ksp/ksp/examples/tutorials
> make ex2
>

I believe that only relies on

  a) Having compile targets, or a generic example compile target

  b) the compile rules in the toplevel makefiles

I do not think Jed objects to either.

   Matt


> On Thu, 5 Jul 2018, Jed Brown wrote:
>
> > Satish Balay  writes:
> >
> > > On Thu, 5 Jul 2018, Jed Brown wrote:
> > >
> > >> When can we delete the legacy test system?  Are we currently using it
> > >> anywhere?
> > >
> > > [Don't know exactly which parts we would delete] - but the new targets
> > > cover ex*[f,f90] type examples - and not anything else.
> >
> > Which targets are you referring to?  I don't see any build targets in
> > the source directories.
>
> ex%f90: etc targets in lib/petsc/conf/test
>
> >  There are a few run targets that I don't
> > understand.  We could delete lib/petsc/conf/test and any top-level
> > legacy targets.
>
> well lib/petsc/conf/test enables the above feature of 'make ex2'
>
> >
> > > So all other examples that don't fit this string format still use the
> > > old targets.
> >
> > Where are those?  They evidently aren't part of the nightly tests, thus
> > need to be updated.
>
> [With the above context] - I was refering to - say
> spectraladjointassimilation, burgers_spectral etc targes in
> src/tao/unconstrained/examples/tutorials/makefile
>
> Sure - this is not part of the test harness and nightlybilds.
>
>
> > > Also they are still useful to users [to create their own makefiles] -
> > > as we don't have an equivalent simiple replacement yet..
> >
> > I don't mind makefiles sitting in source directories.  They're basically
> > just includes and a list of source files right now, and we can remove
> > the lists of source files.
>
> They also list dependencies compile dependencies [for the above purpose]
>
> Satish
>


-- 
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener

https://www.cse.buffalo.edu/~knepley/ 

Re: [petsc-dev] Remove legacy tests?

[Satish Balay]

Ok - there is some confusion here.

The test harness does not use targets in
examples/[tests,tutorials]/makefile.

However we want to keep the functionality of us/users compiling
individual examples manually - without going through the test harness.

i.e the following should continue to work:

cd src/ksp/ksp/examples/tutorials
make ex2

On Thu, 5 Jul 2018, Jed Brown wrote:

> Satish Balay  writes:
> 
> > On Thu, 5 Jul 2018, Jed Brown wrote:
> >
> >> When can we delete the legacy test system?  Are we currently using it
> >> anywhere?
> >
> > [Don't know exactly which parts we would delete] - but the new targets
> > cover ex*[f,f90] type examples - and not anything else.
> 
> Which targets are you referring to?  I don't see any build targets in
> the source directories.

ex%f90: etc targets in lib/petsc/conf/test

>  There are a few run targets that I don't
> understand.  We could delete lib/petsc/conf/test and any top-level
> legacy targets.

well lib/petsc/conf/test enables the above feature of 'make ex2'

> 
> > So all other examples that don't fit this string format still use the
> > old targets.
> 
> Where are those?  They evidently aren't part of the nightly tests, thus
> need to be updated.

[With the above context] - I was refering to - say
spectraladjointassimilation, burgers_spectral etc targes in
src/tao/unconstrained/examples/tutorials/makefile

Sure - this is not part of the test harness and nightlybilds.


> > Also they are still useful to users [to create their own makefiles] -
> > as we don't have an equivalent simiple replacement yet..
> 
> I don't mind makefiles sitting in source directories.  They're basically
> just includes and a list of source files right now, and we can remove
> the lists of source files.

They also list dependencies compile dependencies [for the above purpose]

Satish

Re: [petsc-dev] Remove legacy tests?

[Jed Brown]

Satish Balay  writes:

> On Thu, 5 Jul 2018, Jed Brown wrote:
>
>> When can we delete the legacy test system?  Are we currently using it
>> anywhere?
>
> [Don't know exactly which parts we would delete] - but the new targets
> cover ex*[f,f90] type examples - and not anything else.

Which targets are you referring to?  I don't see any build targets in
the source directories.  There are a few run targets that I don't
understand.  We could delete lib/petsc/conf/test and any top-level
legacy targets.

> So all other examples that don't fit this string format still use the
> old targets.

Where are those?  They evidently aren't part of the nightly tests, thus
need to be updated.

> Also they are still useful to users [to create their own makefiles] -
> as we don't have an equivalent simiple replacement yet..

I don't mind makefiles sitting in source directories.  They're basically
just includes and a list of source files right now, and we can remove
the lists of source files.

Re: [petsc-dev] Remove legacy tests?

[Satish Balay]

On Thu, 5 Jul 2018, Jed Brown wrote:

> When can we delete the legacy test system?  Are we currently using it
> anywhere?

[Don't know exactly which parts we would delete] - but the new targets
cover ex*[f,f90] type examples - and not anything else.

So all other examples that don't fit this string format still use the
old targets.

Also they are still useful to users [to create their own makefiles] -
as we don't have an equivalent simiple replacement yet..

Satish

Re: [petsc-dev] Remove legacy tests?

[Matthew Knepley]

On Thu, Jul 5, 2018 at 5:37 PM Jed Brown  wrote:

> When can we delete the legacy test system?  Are we currently using it
> anywhere?
>

Not I said the fox.

   Matt

-- 
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which their
experiments lead.
-- Norbert Wiener

https://www.cse.buffalo.edu/~knepley/