Re: [petsc-dev] dm/interface directory files should NOT have DMPlex code in them. Shudder!

2018-03-11 Thread Matthew Knepley
On Mon, Mar 12, 2018 at 9:07 AM, Smith, Barry F. wrote: > > On Mar 11, 2018, at 6:49 PM, Matthew Knepley wrote: > > > > On Mon, Mar 12, 2018 at 8:33 AM, Smith, Barry F. > wrote: > > Please implement things properly with subclasses (subtypes) and get this > crap out of the public interface files

Re: [petsc-dev] dm/interface directory files should NOT have DMPlex code in them. Shudder!

2018-03-11 Thread Smith, Barry F.
> On Mar 11, 2018, at 6:49 PM, Matthew Knepley wrote: > > On Mon, Mar 12, 2018 at 8:33 AM, Smith, Barry F. wrote: > Please implement things properly with subclasses (subtypes) and get this crap > out of the public interface files > > See below. I don't understand See Below. why are there

Re: [petsc-dev] dm/interface directory files should NOT have DMPlex code in them. Shudder!

2018-03-11 Thread Matthew Knepley
On Mon, Mar 12, 2018 at 8:33 AM, Smith, Barry F. wrote: > Please implement things properly with subclasses (subtypes) and get this > crap out of the public interface files > See below. Matt > dm/interfaces should be able to be compiled and linked even if dm/impls > stuff did not exist. Thi

Re: [petsc-dev] dm/interface directory files should NOT have DMPlex code in them. Shudder!

2018-03-11 Thread Smith, Barry F.
Please implement things properly with subclasses (subtypes) and get this crap out of the public interface files dm/interfaces should be able to be compiled and linked even if dm/impls stuff did not exist. This mixing of particular subclass implementations and public interface functions is disgu

Re: [petsc-dev] dm/interface directory files should NOT have DMPlex code in them. Shudder!

2018-03-11 Thread Matthew Knepley
This stuff is in DM because two concepts need to be promoted to DM. They are already both in DA and Plex: 1) GlobalToNatural, which is in dmi.c 2) Coordinates, in particular periodic coordinates, which is in dm.c Removing these means adding 1 or 2 functions to dmimpl Matt On Mon, Mar 12, 2