Re: [petsc-users] Bug report LMVM matrix class

2023-05-09 Thread Matthew Knepley
On Tue, May 9, 2023 at 4:15 AM Stephan Köhler < stephan.koeh...@math.tu-freiberg.de> wrote: > Dear PETSc/Tao team, > > it seems to be that there is a bug in the LMVM matrix class: > > The function MatMultAdd_LMVM, see, e.g., > https://petsc.org/release/src/ksp/ksp/utils/lmvm/lmvmimpl.c.html at

[petsc-users] Bug report LMVM matrix class

2023-05-09 Thread Stephan Köhler
Dear PETSc/Tao team, it seems to be that there is a bug in the LMVM matrix class: The function MatMultAdd_LMVM, see, e.g., https://petsc.org/release/src/ksp/ksp/utils/lmvm/lmvmimpl.c.html at line 114, if the vectors Y and Z are the same, then the result is wrong, since the first MatMult

Re: [petsc-users] Bug report LMVM matrix class

2022-11-02 Thread Barry Smith
Thanks for the bug report with reproducing example. I have a fix in https://gitlab.com/petsc/petsc/-/merge_requests/5797 Barry > On Nov 2, 2022, at 6:52 AM, Stephan Köhler > wrote: > > Dear PETSc/Tao team, > > it seems to be that there is a bug in the LMVM matrix class: > > In the

[petsc-users] Bug report LMVM matrix class

2022-11-02 Thread Stephan Köhler
Dear PETSc/Tao team, it seems to be that there is a bug in the LMVM matrix class: In the function MatCreateVecs_LMVM, see, e.g., https://petsc.org/release/src/ksp/ksp/utils/lmvm/lmvmimpl.c.html at line 214. it is not checked if the vectors  *L, or *R are NULL.  This is, in particular, a