Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

Hi Dave, Please find updated version attached. Regards, Atul On Fri, Jun 23, 2017 at 8:49 PM, Dave Page wrote: > Hi, > > I'm getting: > > (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM_2191_ver2.patch > error: cannot apply binary patch to > 'docs/en_US/images/server_advanced.png' w

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi Harshal, When can we expect an updated version of this patch? I think it's important to get this into the next release. Thanks! On Fri, Jun 16, 2017 at 10:55 AM, Dave Page wrote: > Hi, > > That's better - the failures are far less random now :-). I got the > following two though, on both PG

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

Hi, I'm getting: (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM_2191_ver2.patch error: cannot apply binary patch to 'docs/en_US/images/server_advanced.png' without full index line error: docs/en_US/images/server_advanced.png: patch does not apply when trying to apply. If memory serve

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

Hi, Please find updated patch. Regards, Atul On Thu, Jun 22, 2017 at 5:02 PM, Dave Page wrote: > Hi > > On Thu, Jun 22, 2017 at 11:05 AM, Atul Sharma > wrote: > > Hi, > > > > Please find attached patch for RM #2191 : Add support for hostaddr > > connection parameter > > Unfortunately there ar

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Hi I'm unable to properly test this, as the debugger doesn't even seem to launch for a non-superuser. I just get a white tab, and a whole lot of polling indefinitely. Can you debug if you're not a superuser, but you own the function? Looking at the patch itself, I wonder if the logic is still a l

Jenkins build is back to normal : pgadmin4-master-python33 #196

See

pgAdmin 4 commit: Wait for the Tools menu to be populated when running

Wait for the Tools menu to be populated when running the feature tests, instead of failing. Fix by Khushboo, based on Harshal's previous work. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b6d3369b31547f5042428a579aa92a1726ba7b5 Author: Kh

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Hi Dave, Please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 2:38 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, I'm looking into it, I will send updated patch. >

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

On Fri, Jun 23, 2017 at 4:21 PM, Dave Page wrote: > > > On Fri, Jun 23, 2017 at 11:47 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Sorry, I forgot to attach screenshot. >> I looked into Query tool HTML using inspect tool. >> >> > That's code that's part of SlickGrid isn't i

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

On Fri, Jun 23, 2017 at 11:47 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Sorry, I forgot to attach screenshot. > I looked into Query tool HTML using inspect tool. > > That's code that's part of SlickGrid isn't it? If there are improvements to be made there, patches should be se

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

Hi On Fri, Jun 23, 2017 at 11:33 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > On latest git pull, couple of issues: > > 1. The edit grid font(text-12) is overriden by 'ui-widget' font - Verdana. > 2. The dotted border around cell appears again. > > The class 'ui-widget' i

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

Hi On latest git pull, couple of issues: 1. The edit grid font(text-12) is overriden by 'ui-widget' font - Verdana. 2. The dotted border around cell appears again. The class 'ui-widget' is added dynamically which i don't know why it is added. Also, Cascaded style is used(i.e. CSS is embedded in

Build failed in Jenkins: pgadmin4-master-python33 #195

See Changes: [Dave Page] Tidy up About box formatting, 'cos it's been annoying me for ages. -- [...truncated 288.93 KB...] runTest (pgadmin.browser.server_groups

pgAdmin 4 commit: Tidy up About box formatting, 'cos it's been annoying

Tidy up About box formatting, 'cos it's been annoying me for ages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92b1b1365e9b82bcc7ff201f94496b94f1ae8759 Modified Files -- web/pgadmin/about/templates/about/index.html | 10 +--

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Yes, I'm looking into it, I will send updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 2:32 PM, Dave Page wrote: > On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala > wrote: > > Yes Dave, > > > > Y

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala wrote: > Yes Dave, > > You are right, I tested and found that indirect debugging is not working. > But otherwise for direct debugging it works properly. Does the patch take that into account, or are you modifying it? > On Fri, Jun 23, 2017 at 1:

pgAdmin 4 commit: Add access keys for top level menus.

Add access keys for top level menus. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fabf4764b51c9978c896ce93733b474a3c3a8ff Modified Files -- web/pgadmin/browser/templates/browser/index.html | 12 ++-- 1 file changed, 6 in

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Yes Dave, You are right, I tested and found that indirect debugging is not working. But otherwise for direct debugging it works properly. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 1:20 PM, Dave Page wrote:

pgAdmin 4 commit: Fix removal of sizes from column definitions. Fixes #

Fix removal of sizes from column definitions. Fixes #2155 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a4945ff9e9a3cb7cf9dc0c4f042f5502d76464f Author: Murtuza Zabuawala Modified Files -- .../databases/schemas/tables/templates/

Re: [pgAdmin4][Patch] To fix the issue in Column module

Thanks, patch applied. On Fri, Jun 23, 2017 at 6:55 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in Column module where clearing the length of a > character(or any other type as well) generates empty SQL. > RM#2155 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

Thanks - all applied! On Thu, Jun 22, 2017 at 8:00 PM, Matthew Kleiman wrote: > Hello Dave, > > We noticed that the makefile is not installing node_modules dependencies, > so we created a new patch that changes the makefile to install > node_modules first and then execute the tasks. > > Thanks >

pgAdmin 4 commit: Fix cell selection window alignment for the updated S

Fix cell selection window alignment for the updated SlickGrid. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9af29364c7414128d091d57b020750657946cc8c Author: Matthew Kleiman Modified Files -- web/pgadmin/static/js/selection/xcel

pgAdmin 4 commit: Update Slickgrid to 2.3.7. As this version includes a

Update Slickgrid to 2.3.7. As this version includes all the features we need, it can be moved out of the vendor directory and we'll use yarn to pull it in. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94aa5487fb9c4e24b3b06e02e40bd3f9829b543

pgAdmin 4 commit: Ensure the relevant Makefile targets install node mod

Ensure the relevant Makefile targets install node modules before running. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b98fcaa829aa71493af8419d6d97a5c8a3b74302 Author: Matthew Kleiman Modified Files -- Makefile | 11 +++

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in Debugger module where it was unable to start > debugging if 'plugin_debugger' can not found in shared_preload_libraries. > RM#2162 > > Original patch by: Kit Yam Tse > (who reported the issue) > > I j