Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-10 Thread Harshal Dhumal
On Thu, Jan 11, 2018 at 12:06 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > User can open Query tool in new browser window where we'll not have > wcDocker panel. > In that case we can use window onfocus and onblur events

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-10 Thread Murtuza Zabuawala
User can open Query tool in new browser window where we'll not have wcDocker panel. On Thu, Jan 11, 2018 at 12:00 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Murtuza, I think we should only poll if sqleditor/datagrid is visible. > We've *wcDocker.EVENT.VISIBILITY_CHANGED *event

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-10 Thread Harshal Dhumal
Murtuza, I think we should only poll if sqleditor/datagrid is visible. We've *wcDocker.EVENT.VISIBILITY_CHANGED *event when panel visibility changes. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jan 10, 201

pgAdmin 4 commit: No longer using the 'get_own_javascripts' method for

2018-01-10 Thread Ashesh Vashi
No longer using the 'get_own_javascripts' method for refering the javascript modules exposed through a module, instead added them in the webpack (shim) configuration directly. Instead - exposed a new method - 'get_javascript_entries' to be used later by the new implementation of the webpack config

pgAdmin 4 commit: Improve icon alignment.

2018-01-10 Thread Ashesh Vashi
Improve icon alignment. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1012bcff5232d53124066736501c0f1294045fb Author: Chethana Kumar Modified Files -- .../browser/server_groups/servers/databases/casts/static/img/cast.sv

pgAdmin 4 commit: Ensure the switch animation is consistent on the tabl

2018-01-10 Thread Ashesh Vashi
Ensure the switch animation is consistent on the table dialogue and avoid displaying an error incorrectly. Fixes #2624 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf17bbeaa591772360fe03bad64f7853528c36a2 Author: Murtuza Zabuawala

pgAdmin 4 commit: Update copyright notices for 2018.

2018-01-10 Thread Ashesh Vashi
Update copyright notices for 2018. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28fac6755bf45ae6868e1825373035c8069e395c Author: Dave Page Modified Files -- LICENSE| 38 +

pgAdmin 4 commit: Resolved the logo issue.

2018-01-10 Thread Ashesh Vashi
Resolved the logo issue. For some unknown reason, font-mfizz was showing the slonik icon in italic. Even after upgrading it to the latest version of font-mfizz, the problem was not resolved. So - instead of using the vector font, using the PostgreSQL SVG logo as the application icon, and document

pgAdmin 4 commit: Add ALT tags to images for accessibility. Fixes #2902

2018-01-10 Thread Ashesh Vashi
Add ALT tags to images for accessibility. Fixes #2902 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b832a2fa3a0706fb7f84b2214bcb476baf02387 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/about/templates/about/i

pgAdmin 4 commit: Clarify how virtual envs can be used in WSGI mode, an

2018-01-10 Thread Ashesh Vashi
Clarify how virtual envs can be used in WSGI mode, and ensure we ship the required bits on Windows. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d71d258caa0de84b4cb15c8d651af7736044e95f Author: Surinder Kumar Modified Files --

pgAdmin 4 commit: Allow connections to be coloured in the treeview and

2018-01-10 Thread Ashesh Vashi
Allow connections to be coloured in the treeview and query tool. Fixes #1383. Fixes #2802 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2458f3c4517b9b102411044a85f4903f2ebea849 Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: Allow selection of SSL certificates and pgpass files

2018-01-10 Thread Ashesh Vashi
Allow selection of SSL certificates and pgpass files in connection properties. Fixes #2649. Fixes #2650 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a20715047abb21f2c31ad299bea4727685bd36cb Author: Murtuza Zabuawala Modified Files

pgAdmin 4 commit: Close user language preference drop down when it lose

2018-01-10 Thread Ashesh Vashi
Close user language preference drop down when it loses focus. Fixes #2956 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f11e5260f412968263bb69807bcc509ec0c00d87 Author: Khushboo Vashi Modified Files -- web/pgadmin/prefer

pgAdmin 4 commit: Prevent multiple connections to new slow-to-respond s

2018-01-10 Thread Ashesh Vashi
Prevent multiple connections to new slow-to-respond servers being initiated in error. Fixes #2928 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=149e651fc6cc90e69307d1689c7a3263a04671d7 Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2018-01-10 Thread Ashesh Vashi
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=517cf177ceee1762d7573a9ba1d59e2fbe1796be Author: Harshal Dhumal Mod

pgAdmin 4 commit: Upgraded the font-mfizz to latest version (v:2.4.1) t

2018-01-10 Thread Ashesh Vashi
Upgraded the font-mfizz to latest version (v:2.4.1) to resolve an issue, about showing the PostgreSQL logo in italic in runtime on windows. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=66383c13fa850866a051366a9f99a3f1e79cb036 Modifi

pgAdmin 4 commit: Show complete SQL for FTS dictionaries. Fixes #2949

2018-01-10 Thread Ashesh Vashi
Show complete SQL for FTS dictionaries. Fixes #2949 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8dcf6dc1363d13fab1a0a00b289ffb1f83ecaf86 Author: Khushboo Vashi Modified Files -- .../servers/databases/schemas/fts_dictio

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2018-01-10 Thread Ashesh Vashi
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9ac6f77ff17ea78ab9fe766cae82dc5038e2fa9 Author: Harshal Dhumal Mod

pgAdmin 4 commit: Allow use of transition tables in PG 10 triggers. Fix

2018-01-10 Thread Ashesh Vashi
Allow use of transition tables in PG 10 triggers. Fixes #2933 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1eb18b6529f06bd78497e782b820ba0a216ddb8f Author: Khushboo Vashi Modified Files -- .../templates/trigger/sql/10_p

pgAdmin 4 commit: Fixing the on the javascript files - 'web/pgadmin/sta

2018-01-10 Thread Ashesh Vashi
Fixing the on the javascript files - 'web/pgadmin/static/js/*.js' for the errors reported by the eslint. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=204a7113dee5a802cc5c951b144b602b6a6c3055 Modified Files -- web/pgadmin

pgAdmin 4 commit: Fix user manager role handling. Fixes #2641

2018-01-10 Thread Ashesh Vashi
Fix user manager role handling. Fixes #2641 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1dcf12675055b2e2f39cfd6a0c0881a91bdaf7e3 Author: Harshal Dhumal Modified Files -- web/pgadmin/tools/user_management/static/js/user

pgAdmin 4 commit: Do not decrypt the password when the password is 'Non

2018-01-10 Thread Ashesh Vashi
Do not decrypt the password when the password is 'None'. Fixes #2765 This should avoid the common but harmless exception "ValueError: IV must be 16 bytes long while decrypting the password." Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdi

pgAdmin 4 commit: Enable webpackaging the pgadmin javascript files in d

2018-01-10 Thread Ashesh Vashi
Enable webpackaging the pgadmin javascript files in different small modules, which can be referred from other modules. We can have two types of webpack modules. 1. Reference (using the dll plugin of webpack) This type of webpack module can be referred from the other webpack modules. And, it

pgAdmin 4 commit: Add the ability to build a basic Docker container.

2018-01-10 Thread Ashesh Vashi
Add the ability to build a basic Docker container. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a8a35533d7f4836f5636e4a0aff40f8acd2708a Author: Dave Page Modified Files -- pkg/docker/pgadmin4.conf | 22

pgAdmin 4 commit: Ensure invalid options can't be selected on triggers

2018-01-10 Thread Ashesh Vashi
Ensure invalid options can't be selected on triggers on views. Fixes #2945 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06634715c879f04eedd51a7a8ef706e007a964ce Author: Khushboo Vashi Modified Files -- .../tables/templa

pgAdmin 4 commit: Only allow specification of a pgpass file if libpq >=

2018-01-10 Thread Ashesh Vashi
Only allow specification of a pgpass file if libpq >= 10. Fixes #2768 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6fb536cb6429cc89234e7236e1ea9961f9dc1c7 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser

pgAdmin 4 commit: Correct alignment of the X button on dismissable aler

2018-01-10 Thread Ashesh Vashi
Correct alignment of the X button on dismissable alerts. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e18711ac224410c9d4e765c02f385440d6231d8 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/bootstrap

pgAdmin 4 commit: Clear the messages tab when running EXPLAIN/EXPLAIN A

2018-01-10 Thread Ashesh Vashi
Clear the messages tab when running EXPLAIN/EXPLAIN ANALYZE. Fixes #2974 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47db3a2d71a0db8c4c3286a6fbafba828cc0e2ef Author: Murtuza Zabuawala Modified Files -- web/pgadmin/stat

pgAdmin 4 commit: Use the correct lexer in the Apache/Windows docs.

2018-01-10 Thread Ashesh Vashi
Use the correct lexer in the Apache/Windows docs. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c53212b886de348ead2c04392bd1ed2c15649899 Author: Dave Page Modified Files -- docs/en_US/server_deployment.rst | 9 -

Re: ESLINT: On pgAdmin static javascripts

2018-01-10 Thread Ashesh Vashi
Hi Murtuza, On Tue, Jan 9, 2018 at 4:08 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > All patches looks good to me except one issue as shown in screenshot which > I observed while opening Preferences dialog subsequently. > I was able to reproduce the issue on 'master' branc

Jenkins build is back to normal : pgadmin4-master-python33 #437

2018-01-10 Thread pgAdmin 4 Jenkins
See

Build failed in Jenkins: pgadmin4-master-python33 #436

2018-01-10 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update version number for release. [Dave Page] Add release notes for 2.1 [Dave Page] Add release notes for 2.1 -- [...truncated 372.40

pgAdmin 4 commit: Fix name of release notes.

2018-01-10 Thread Dave Page
Fix name of release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=405de592985448bad4365cb238e9f4aa142e7528 Modified Files -- docs/en_US/release_notes_2.1.rst | 91 docs/en_US/release

pgAdmin 4 commit: Add release notes for 2.1

2018-01-10 Thread Dave Page
Add release notes for 2.1 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e8c05fbaa5c0c2ac2c0f76cd00f8faec90ae6400 Author: Karen Blatchley Modified Files -- docs/en_US/release_notes_2.1.rst | 91 +++

pgAdmin 4 commit: Add release notes for 2.1

2018-01-10 Thread Dave Page
Add release notes for 2.1 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57f4131dfe782f77e0c5013d9a90bed44e302688 Author: Karen Blatchley Modified Files -- docs/en_US/release_notes.rst | 1 + 1 file changed, 1 insertion(+)

pgAdmin 4 commit: Update version number for release.

2018-01-10 Thread Dave Page
Update version number for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1e39dd20cab904dfe687e2ce7b4b486ea54a4ee Modified Files -- web/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

2018-01-10 Thread Harshal Dhumal
Hi, Please find rebased patch. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jan 9, 2018 at 9:21 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch where

Re: [pgAdmin4][Patch]: RM #2993 : - [Web Based] User can not view data for View and MATERIALIZED View object.

2018-01-10 Thread Dave Page
Thanks, patch applied. On Wed, Jan 10, 2018 at 9:10 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the patch to fix RM #2993 : [Web Based] User can not view data > for View and MATERIALIZED View object. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgs

pgAdmin 4 commit: Fix view data for views/mat views. Fixes #2993

2018-01-10 Thread Dave Page
Fix view data for views/mat views. Fixes #2993 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=def2df9028f2cee1be7f8d20ed8c107c7c0b Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/sqleditor/__init__.py | 6 -- 1

[pgAdmin4][Patch]: RM #2993 : - [Web Based] User can not view data for View and MATERIALIZED View object.

2018-01-10 Thread Khushboo Vashi
Hi, Please find the patch to fix RM #2993 : [Web Based] User can not view data for View and MATERIALIZED View object. Thanks, Khushboo diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py index 84c98d3..aeca5cc 100644 --- a/web/pgadmin/tools/sqleditor/__i

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-10 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. On Tue, Jan 9, 2018 at 7:57 PM, Dave Page wrote: > Hi > > On Tue, Jan 9, 2018 at 6:33 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find updated patch. >> > > I turned off the status option, but polling is still happe