Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

2018-01-12 Thread Joao De Almeida Pereira
Thanks for the help Murtuza Attached you can find the revisited patch that now displayed all the information about functions in GreenPlum Thanks Joao On Fri, Jan 12, 2018 at 9:51 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi, > > We ​create collection of existing para

[pgadmin4][Patch] Access Database properties

2018-01-12 Thread Joao De Almeida Pereira
Hi Hackers, This patch tackles the visualization of properties on a GreenPlum Database. Previously when you tried to access these properties a SQL error was displayed. Also in the patch we made some correction to feature tests, and skipped other test that were failing against GreenPlum Thanks Joa

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

2018-01-12 Thread Murtuza Zabuawala
​Hi, We ​create collection of existing parameters using function 'def _format_arguments_from_db(...)' in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py' @ line 454, and on client side we have backbone collection mapped with same id on line 304

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

2018-01-12 Thread Joao De Almeida Pereira
Hello, I changed that function to make the retrieval quicker because the return type of all the types in the database for GreenPlum can be quite big. Nevertheless the "Data Types" in the front end do not get filled up with the values. Where is the Javascript code that does the mapping between the

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-12 Thread Murtuza Zabuawala
Sure, I'll do that. On Fri, Jan 12, 2018 at 8:05 PM, Dave Page wrote: > Thanks - patch applied! > > Can you please update the docs for the new config options, and any > screenshot updates that are required? > > On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> ​Hi

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-12 Thread Dave Page
Thanks - patch applied! Can you please update the docs for the new config options, and any screenshot updates that are required? On Fri, Jan 12, 2018 at 2:10 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > PFA updated patch with additional checks to prevent unn

pgAdmin 4 commit: Monitor connection and transaction status in the quer

2018-01-12 Thread Dave Page
Monitor connection and transaction status in the query tool. Fixes #2475 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8520871bc612b25c8d8b193846c3cb34e5f2c6da Author: Murtuza Zabuawala Modified Files -- .../browser/server_group

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-12 Thread Murtuza Zabuawala
​Hi Dave, PFA updated patch with additional checks to prevent unnecessary ​polling added as suggested. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jan 11, 2018 at 2:33 PM, Dave Page wrote: > > > On Thu, Jan 1

pgAdmin 4 commit: Refer users who want to build themselves from scratch

2018-01-12 Thread Dave Page
Refer users who want to build themselves from scratch to the README. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82aa8035c2b058b4574cba3950670ff835525351 Modified Files -- docs/en_US/desktop_deployment.rst | 25 +++-

pgAdmin 4 commit: Make the title a little more appropriate.

2018-01-12 Thread Dave Page
Make the title a little more appropriate. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=852a2fce849226ac369a0fe0872888b266d9a032 Modified Files -- docs/en_US/change_user_password.rst | 8 1 file changed, 4 insertions(+),

pgAdmin 4 commit: Fix typo

2018-01-12 Thread Dave Page
Fix typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=601a7b1a5c417d37a167d77e0b32487c942394dc Author: Magnus Hagander Modified Files -- pkg/docker/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgadmin4 container docs bug

2018-01-12 Thread Dave Page
Thanks, patch applied. On Fri, Jan 12, 2018 at 11:45 AM, Magnus Hagander wrote: > Looks like a simple copy/paste bug. > > //Magnus > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgadmin4 container docs bug

2018-01-12 Thread Magnus Hagander
Looks like a simple copy/paste bug. //Magnus diff --git a/pkg/docker/README b/pkg/docker/README index ba04dfa8..7d4ea890 100644 --- a/pkg/docker/README +++ b/pkg/docker/README @@ -38,7 +38,7 @@ This is the password used when setting up the initial administrator account to l PGADMIN_ENABLE_TLS --

Re: [pgAdmin4][Patch] Statistics button not working for GreenPlum

2018-01-12 Thread Dave Page
Thanks, patch applied. On Thu, Jan 11, 2018 at 9:58 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > Find attached a patch that enables the retrieval of statistics for > databases and servers on GreenPlum databases. > > > Thanks > Joao > -- Dave Page Blog:

pgAdmin 4 commit: Support server and database statistics on Greenplum.

2018-01-12 Thread Dave Page
Support server and database statistics on Greenplum. Fixes #3004 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed3e374df6a2927cadba20cc3cebe7cee8c33c51 Author: Joao Pedro De Almeida Pereira Modified Files -- .../servers/database

Re: RM2815: Relogin to pgAdmin from sqleditor/datadrid if session exprires

2018-01-12 Thread Dave Page
Can you rebase this please? On Wed, Jan 10, 2018 at 9:47 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find rebased patch. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >