pgAdmin 4 commit: Use shared memory for process locking instead of QLoc

2018-01-29 Thread Dave Page
Use shared memory for process locking instead of QLockFile which isn't available in QT4. Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c8d88974894c09f0efda46a7ce17cee962a5f1aa Modified Files -- runtime/pgAdmin4.cpp | 49

pgAdmin 4 commit: Quiet a warning in GCC

2018-01-29 Thread Dave Page
Quiet a warning in GCC Branch -- runtime-revamp Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c54a90f0874fee21bd311448f5c21f242245bf41 Modified Files -- runtime/LogWindow.cpp | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python34 #452

2018-01-29 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4][RM#3054] F5 Keyboard shortcut doesn't work after cancelling query

2018-01-29 Thread Dave Page
Thanks, patch applied. On Mon, Jan 29, 2018 at 12:36 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where user were not able to execute query by > pressing F5 key after cancelling the query. > RM#3054 > > Also fixed the similar issue when u

pgAdmin 4 commit: Ensure the user can use keyboard shortcuts after usin

2018-01-29 Thread Dave Page
Ensure the user can use keyboard shortcuts after using button controls such as Cancel, Open and Save. Fixes #3054 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc836aa37421a13ecb00fda907f34f4356c23803 Author: Murtuza Zabuawala Modified Fil

Jenkins build is back to normal : pgadmin4-master-python35 #462

2018-01-29 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python27 #462

2018-01-29 Thread pgAdmin 4 Jenkins
See

Build failed in Jenkins: pgadmin4-master-python34 #451

2018-01-29 Thread pgAdmin 4 Jenkins
See -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variab

Build failed in Jenkins: pgadmin4-master-python35 #461

2018-01-29 Thread pgAdmin 4 Jenkins
See -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspac

Build failed in Jenkins: pgadmin4-master-python27 #461

2018-01-29 Thread pgAdmin 4 Jenkins
See -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment variables. Building in workspac

Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module

2018-01-29 Thread Dave Page
Thanks - applied. I added a Makefile rule for running the check (make check-pep8), but haven't included it in "make check" yet as it's failing at present. On Mon, Jan 29, 2018 at 10:36 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > On Mon,

pgAdmin 4 commit: Add tools for checking PEP8 compliance. Fixes #3063

2018-01-29 Thread Dave Page
Add tools for checking PEP8 compliance. Fixes #3063 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=489349b4e9aacc59132cc32ed6f39530b1f1ef28 Author: Murtuza Zabuawala Modified Files -- Makefile| 3 +++ web/

[pgAdmin4][RM#3054] F5 Keyboard shortcut doesn't work after cancelling query

2018-01-29 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where user were not able to execute query by pressing F5 key after cancelling the query. RM#3054 Also fixed the similar issue when user press open/save dialog & clear editor window options. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The

Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module

2018-01-29 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. On Mon, Jan 29, 2018 at 3:23 PM, Dave Page wrote: > Hi > > On Sun, Jan 28, 2018 at 4:42 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> On Fri, Jan 26, 2018 at 10:33 PM, Dave Page wrote: >> >>> Hi >>> >>> On Fri, Jan 26, 2018 at 1:26 PM, Murtuza

Re: [pgAdmin4][Patch]: RM # 2895 - All the controls and display elements in the main window to be accessible using the tab key in an appropriate order

2018-01-29 Thread Dave Page
Hi On Mon, Jan 29, 2018 at 9:00 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for RM #2895: As a keyboard user who has > difficulty using a mouse, I need all the controls and display elements in > the main window to be accessible using the t

Re: [pgAdmin4][RM#3063] Add 'pycodestyle ' Python PEP-8 checker module

2018-01-29 Thread Dave Page
Hi On Sun, Jan 28, 2018 at 4:42 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Jan 26, 2018 at 10:33 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jan 26, 2018 at 1:26 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>>

Re: Request for feedback: Alternate desktop runtime architecture

2018-01-29 Thread Dave Page
Hi On Mon, Jan 29, 2018 at 2:31 AM, Anthony DeBarros wrote: > > Hi, Dave, > > I've been testing this on macOS High Sierra for a few days. Overall, very > positive feedback. The app seems fast, and I've experience no glitches yet. > Great, thanks for testing. > > One minor point: > > In the de