Re: [pgadmin4][patch] External Tables for GreenPlum #3168

Thanks, patch applied. On Fri, Mar 2, 2018 at 4:37 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > Attached you can find the patch that remove the External Tables from the > Tables node and create a new node at the database level for GreenPlum. > - Do not

pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168

Support for external tables in GPDB. Fixes #3168 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=427314cfdfeb96c3a7835eab5a4d638903bc6dc3 Author: Joao Pedro De Almeida Pereira Modified Files --

[pgadmin4][patch] External Tables for GreenPlum #3168

Hello Hackers, Attached you can find the patch that remove the External Tables from the Tables node and create a new node at the database level for GreenPlum. - Do not display External Tables in the Tables node - Create a new node under databases for External Tables - Generate DDL for external

Re: [pgAdmin4][RM#3153] Fix the issue in Debugger module

Thanks, patch applied. On Fri, Mar 2, 2018 at 11:05 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > I have fixed below issues, > 1) Fixed typo in accesskey assignment in html template. > 2) Edit value in Grid using Tab key was not working and added test case > for

pgAdmin 4 commit: Ensure we can edit grid values in the debugger using

Ensure we can edit grid values in the debugger using keyboard shortcuts. Fixes #3153 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92a0bb605d1351ff5bacdd68e17b08738390ec5f Author: Murtuza Zabuawala

pgAdmin 4 commit: Fix typo/thinko in access key definition.

Fix typo/thinko in access key definition. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efcf87636d3f428f8111c60043a5a8a36d085cb9 Author: Murtuza Zabuawala Modified Files --

Re: [pgAdmin4][Patch]: PEP-8 fixes in the foreign data wrapper module

Thanks, applied. On Fri, Mar 2, 2018 at 4:56 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao, > > On Thu, Mar 1, 2018 at 8:13 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Khushboo, >> I applied this patch and here is the result: >> >>

pgAdmin 4 commit: PEP8 changes for the FDW modules.

PEP8 changes for the FDW modules. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=905cdafe9041324b31d3aaa56d7bdde2f33abd39 Author: Khushboo Vashi Modified Files --

pgAdmin 4 commit: Allow copying of SQL from the dashboard tables. Fixes

Allow copying of SQL from the dashboard tables. Fixes #3137 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c48b79ce7ed459033a36d86b014052105a0b7df Author: Neethu Mariya Joy Modified Files --

Re: Bug #2309 fix

Thanks, applied. On Fri, Mar 2, 2018 at 9:05 AM, Neethu Mariya Joy wrote: > Hi, > > A similar workaround fixed #3137 too. I'm attaching the patch below. > > Sincerely, > Neethu > > On Fri, Mar 2, 2018 at 9:45 AM, Murtuza Zabuawala

Re: Bug #2309 fix

Hi Thank you both. I've committed this with a minor tweak to include a space before the { in the CSS, to match the existing formatting. Welcome to the project Neethu! On Thu, Mar 1, 2018 at 10:05 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Neethu, > > We run the

pgAdmin 4 commit: Allow text selection/copying from disabled CodeMirror

Allow text selection/copying from disabled CodeMirror instances. Fixes #2309 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7471dea45816443ce5c146ae636f84c0a902f5a9 Author: Neethu Mariya Joy Modified Files

pgAdmin 4 commit: Undo previous thinko - there's already a check-pep8 t

Undo previous thinko - there's already a check-pep8 target. D'oh. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d072ff7818852a5f00b984dd2d7402505452301 Modified Files -- Makefile | 3 --- 1 file changed, 3 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python27 #505

See

Re: [pgAdmin4][RM#3129] handle encoding issue in File manager

Thanks guys, patch applied. On Thu, Mar 1, 2018 at 10:11 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Joao, > The pipeline is green and I believe the change is good to be merged. > > Thanks > Joao > > On Thu, Mar 1, 2018 at 10:56 AM Murtuza Zabuawala

pgAdmin 4 commit: Handle opening of non-UTF8 compatible files. Fixes #3

Handle opening of non-UTF8 compatible files. Fixes #3129 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da7f088508b538651db7a1aee48b3efea593ecd5 Author: Murtuza Zabuawala Modified Files --

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

On Thu, Mar 1, 2018 at 3:21 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > The patch runs successfully in our CI with all tests passing. > > I see the test that you created, and I do not understand why we need to > create tests that do HTTP requests in

Jenkins build is back to normal : pgadmin4-master-python35 #505

See

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

Could you rebase this please? It no longer applies. Thanks. On Thu, Mar 1, 2018 at 5:56 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Joao, > > Thanks for reviewing. > > On Wed, Feb 28, 2018 at 8:55 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >>

Jenkins build is back to normal : pgadmin4-master-python33 #501

See

Jenkins build is back to normal : pgadmin4-master-python34 #495

See

Jenkins build is back to normal : pgadmin4-master-python36 #496

See

Jenkins build is back to normal : pgadmin4-master-python26 #631

See

Build failed in Jenkins: pgadmin4-master-python27 #504

See Changes: [Dave Page] PEP8 fixes for the Casts, Event triggers, Extensions and Languages [Dave Page] Add a makefile target for running PEP8 checks. --

Build failed in Jenkins: pgadmin4-master-python33 #500

See Changes: [Dave Page] Fix handling of tie/datetime array types when adding columns to a table. [Dave Page] PEP8 fixes for the Casts, Event triggers, Extensions and Languages [Dave Page] Add a

pgAdmin 4 commit: Stupid Makefile syntax

Stupid Makefile syntax Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=803eadd5a11c82b3545d8d41871f0f55c289af21 Modified Files -- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Build failed in Jenkins: pgadmin4-master-python34 #494

See Changes: [Dave Page] Fix handling of tie/datetime array types when adding columns to a table. [Dave Page] PEP8 fixes for the Casts, Event triggers, Extensions and Languages [Dave Page] Add a

Build failed in Jenkins: pgadmin4-master-python26 #630

See Changes: [Dave Page] Fix handling of tie/datetime array types when adding columns to a table. [Dave Page] PEP8 fixes for the Casts, Event triggers, Extensions and Languages [Dave Page] Add a

Build failed in Jenkins: pgadmin4-master-python35 #504

See Changes: [Dave Page] Ensure the pgAgent job start/end time grid fields synchronise with the [Dave Page] Fix handling of tie/datetime array types when adding columns to a table. [Dave Page] PEP8

pgAdmin 4 commit: Add a makefile target for running PEP8 checks.

Add a makefile target for running PEP8 checks. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=31f50634c729b48dae65ffd86469635058608467 Modified Files -- Makefile | 3 +++ 1 file changed, 3 insertions(+)

pgAdmin 4 commit: PEP8 fixes for the Casts, Event triggers, Extensions

PEP8 fixes for the Casts, Event triggers, Extensions and Languages modules. Fixes #3161 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8964e511bf2352f7e89454cecc4c1bb3b1af3dd2 Author: Murtuza Zabuawala

Re: RM3079 fix for wrong sql datetime/time related datatypes

Thanks, applied. On Wed, Feb 28, 2018 at 3:00 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Great, thanks! > > On Feb 28, 2018 8:15 PM, "Joao De Almeida Pereira" < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Harshal, >> >> I tried the example you showed and it works. Also

Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

Thanks, applied. On Wed, Feb 28, 2018 at 10:35 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > I have found the issue, it was in Backform control itself :) > Issue: We were passing today's date value as minDate option in pgAgent > schedule schema while rendering

pgAdmin 4 commit: Ensure the pgAgent job start/end time grid fields syn

Ensure the pgAgent job start/end time grid fields synchronise with the subnode control and validate correctly. Fixes #3073 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=78e2ff4f562e7353cf5452ec4be965aecd6434aa Author: Murtuza Zabuawala

[pgAdmin4][RM#3153] Fix the issue in Debugger module

Hi, I have fixed below issues, 1) Fixed typo in accesskey assignment in html template. 2) Edit value in Grid using Tab key was not working and added test case for the same. I have created sub task for auto scrolling while step in and step over button. https://redmine.postgresql.org/issues/3166

Re: [pgAdmin4][Patch]: PEP-8 issue fixes

Thanks, applied. On Wed, Feb 28, 2018 at 4:19 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Feb 26, 2018 at 9:19 PM, Dave Page wrote: > >> Can you rebase this please? It doesn't apply against master. >> >> Please find the updated patch excluding

pgAdmin 4 commit: PEP8 fixes.

PEP8 fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4124c24967c045a1fb512733e3804a0e9b3c24a Author: Khushboo Vashi Modified Files -- web/pgadmin/about/__init__.py

Re: Bug #2309 fix

Hi, A similar workaround fixed #3137 too. I'm attaching the patch below. Sincerely, Neethu On Fri, Mar 2, 2018 at 9:45 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Neethu, > > Patch looks good. > > We are facing similar issue on dashboard as well where users are not