Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.

Hi, Please find the attached patch to fix below issues: 1. #2963 - Backup database, Restore database and Maintenance Database failed for é object 2. #3157 - Process viewer doesn't show complete command executed. Test cases are not included for these fixes as we don't have test cases for these mo

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

Hi Joao, On Thu, Mar 8, 2018 at 7:52 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > Completely forgot about this python "feature"... > Attached is the fix. > > Patch looks good to me and also passed the test cases on PY 2.7 and PY 3.5. > Just as a side

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Thank you Joao Regards, Murtuza On Thu, Mar 8, 2018 at 10:19 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza/Dave, > > Nice splitting of some of the functionality into functions, removing some > of the complexity of the initial function. Good job. > > I made s

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Hello Murtuza/Dave, Nice splitting of some of the functionality into functions, removing some of the complexity of the initial function. Good job. I made some changes because the linter was failing and also changed some variable names. These changes pass our CI and the linter. Thanks Joao On Th

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

Hello Khushboo, Completely forgot about this python "feature"... Attached is the fix. Just as a side question, does anyone else feel the pain of wanting to run a single test using a IDE or the command line and not being able to? We an HandRolled the loader, and that as some implications. Did a

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Hi Dave, Please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Mar 8, 2018 at 6:10 PM, Dave Page wrote: > Can you rebase this please? > > Thanks. > > On Thu, Mar 8, 2018 at 9:00 AM, Murtuza Zabuawala enter

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Can you rebase this please? Thanks. On Thu, Mar 8, 2018 at 9:00 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch & updated test case to cover that as well. > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb

Jenkins build is back to normal : pgadmin4-master-python27 #515

See

pgAdmin 4 commit: Minor formatting fix

Minor formatting fix Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0283f68d7f91df6966a804662304031980b320bd Author: Khushboo Vashi Modified Files -- web/pgAdmin4.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[pgAdmin4][Patch]: PEP-8 fix

Hi, Please find a small pep-8 fix. Thanks, Khushboo diff --git a/web/pgAdmin4.py b/web/pgAdmin4.py index 138ce69..6d0453b 100644 --- a/web/pgAdmin4.py +++ b/web/pgAdmin4.py @@ -55,7 +55,7 @@ if not os.path.isfile(config.SQLITE_PATH): os.path.dirname(os.path.realpath(u(__file__, fs_encodi

Jenkins build is back to normal : pgadmin4-master-python26 #642

See

pgAdmin 4 commit: Fix test case for Python 2.

Fix test case for Python 2. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7796a47b127a73313ad83bac8241b48c1076730c Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/sqleditor/utils/tests/test_start_running_query.py | 4

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Thu, Mar 8, 2018 at 3:35 PM, Dave Page wrote: > > > On Thu, Mar 8, 2018 at 9:47 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 8, 2018 at 3:08 PM, Dave Page wrote: >> >>> Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't >>> though (whi

Build failed in Jenkins: pgadmin4-master-python27 #514

See Changes: [Dave Page] Final PEP-8 fixes [Dave Page] Always run PEP-8 checks! -- [...truncated 643.57 KB...] Detach par

Jenkins build is back to normal : pgadmin4-master-python36 #505

See

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Thu, Mar 8, 2018 at 9:47 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Mar 8, 2018 at 3:08 PM, Dave Page wrote: > >> Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't >> though (which is odd, as it passed on my local 2.7). >> >> I am looking into

Jenkins build is back to normal : pgadmin4-master-python33 #511

See

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Thu, Mar 8, 2018 at 3:08 PM, Dave Page wrote: > Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't though > (which is odd, as it passed on my local 2.7). > > I am looking into this. Btw, which command do you use to run tests? > On Thu, Mar 8, 2018 at 9:13 AM, Dave Page wrote

Jenkins build is back to normal : pgadmin4-master-python34 #504

See

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't though (which is odd, as it passed on my local 2.7). On Thu, Mar 8, 2018 at 9:13 AM, Dave Page wrote: > Thanks, applied. > > On Thu, Mar 8, 2018 at 4:26 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> O

Build failed in Jenkins: pgadmin4-master-python26 #641

See Changes: [Dave Page] More hardening of the query tool tests. -- [...truncated 644.50 KB...] Detach partition from exis

Re: Last PEP-8 changes

Thanks, applied! I also modified the Makefile to include PEP-8 checks in the check target, and the ci runner scripts to run them before the Python tests. On Wed, Mar 7, 2018 at 9:16 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > Attached you can find the last

pgAdmin 4 commit: Final PEP-8 fixes

Final PEP-8 fixes Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a6994f719ed89460be00175debcd6af297c4d0e Author: Joao Pedro De Almeida Pereira Modified Files -- web/config.py | 8 +- web/pgA

pgAdmin 4 commit: Always run PEP-8 checks!

Always run PEP-8 checks! Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e577859ed24e18fec1481c844cb652d3d5e93c2c Modified Files -- Makefile | 2 +- ci/run_python_tests.sh | 5 + 2 files changed, 6 insertions(+), 1

Build failed in Jenkins: pgadmin4-master-python27 #513

See Changes: [Dave Page] More hardening of the query tool tests. -- [...truncated 643.08 KB...] Detach partition from exis

Jenkins build is back to normal : pgadmin4-master-python35 #514

See

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Thanks, applied. On Thu, Mar 8, 2018 at 4:26 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Mar 7, 2018 at 11:13 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the patch to fix this. >> I have fixed this issue in the Star

pgAdmin 4 commit: More hardening of the query tool tests.

More hardening of the query tool tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f86c313c184aa8851bd3097c9c6a3dd3a0b50eb8 Author: Khushboo Vashi Modified Files -- .../tools/sqleditor/utils/tests/test_start_running_query.py

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Hi Dave, Please find updated patch & updated test case to cover that as well. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 7, 2018 at 9:59 PM, Dave Page wrote: > Hi > > On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala