[pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

Hi, Please find the attached patch to fix RM #3122 : Backup not working on certificate (SSL) protected servers. The attached patch fixes the issue in the following modules: 1. Backup 2. Restore 3. Import/Export 4. Maintenance Thanks, Khushboo diff --git a/web/migrations/versions/12958d9f4970_.p

Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an

Thanks - fixed. That begs the question of why Jenkins didn't catch it though :-/ On Tue, Mar 13, 2018 at 4:54 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Dave, Khushboo > > Looks like there is a linting issue with this commit: > > Successfully installed pycodestyle-2.3

pgAdmin 4 commit: PEP-8 fixes

PEP-8 fixes Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c686d3fbe1bedad6e7744ca61e3b75dba07fcdc Modified Files -- web/pgadmin/misc/bgprocess/processes.py | 2 +- web/pgadmin/tools/backup/__init__.py| 1 - 2 files changed, 1

Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an

Hi Dave, Khushboo Looks like there is a linting issue with this commit: Successfully installed pycodestyle-2.3.1 /tmp/build/4a5630c2/pgadmin-master/web /tmp/b

pgAdmin 4 commit: Fix unicode handling in the external process tools an

Fix unicode handling in the external process tools and show the complete command in the process viewer. Fixes #2963. Fixes #3157. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=802269910c37a52aa57479bbcc1d8d078f6a88e1 Author: Khushboo Vashi

Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190)

Thanks, applied. On Tue, Mar 13, 2018 at 2:19 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi > > Attached you can find the patch that instead of using the json > configuration, connects to the database to retrieve the type and then check > if the test should be skipped or

pgAdmin 4 commit: Skip tests where appropriate on GPDB. Fixes #3190

Skip tests where appropriate on GPDB. Fixes #3190 Victoria & Joao @ Pivotal. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=876ce1799a115b5f67c35d8ff6d39a1428a6 Author: Joao Pedro De Almeida Pereira Modified Files -- .../ser

Re: [pgAdmin4][RM#3140] Add service parameter

Thanks, patches applied! On Tue, Mar 13, 2018 at 9:53 AM, Victoria Henry wrote: > Hi Dave, > > We've made updated our previous patch to fix the error messages. Attached > are our updated patches. > > On Mon, Mar 12, 2018 at 8:48 PM, Dave Page wrote: > >> Hi >> >> On Mon, Mar 12, 2018 at 5:18 P

pgAdmin 4 commit: Refactor server dialogue validation for better unit t

Refactor server dialogue validation for better unit testing. Victoria & Joao @ Pivotal. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b03cb78af607b04c75de44d635bf201babb4c5a Author: Victoria Henry Modified Files -- web/package

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

Thanks, applied. On Tue, Mar 13, 2018 at 9:27 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch which Joao sent along with RM#3139 fix. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise Post

pgAdmin 4 commit: Fix template paths for Windows. Fixes #3139

Fix template paths for Windows. Fixes #3139 Joint work from Joao and Murtuza. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=156b308fd326c5021cfbf0ed064629efd1d84c86 Modified Files -- .../servers/databases/external_tables/__init_

v3.0 Release

FYI for the list; we're planning to cut the 3.0 release on Tuesday next week, for release on Thursday. Please get any must-fix patches in ASAP! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM#3140] Add service parameter

Hi Dave, We've made updated our previous patch to fix the error messages. Attached are our updated patches. On Mon, Mar 12, 2018 at 8:48 PM, Dave Page wrote: > Hi > > On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Dave and Murtuza, >>

Jenkins build is back to normal : pgadmin4-master-python33 #518

See

Jenkins build is back to normal : pgadmin4-master-python36 #512

See

Jenkins build is back to normal : pgadmin4-master-python34 #511

See

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

Hi Dave, Please find updated patch which Joao sent along with RM#3139 fix. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Mar 13, 2018 at 6:24 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > I

Jenkins build is back to normal : pgadmin4-master-python26 #648

See

Jenkins build is back to normal : pgadmin4-master-python27 #522

See

Jenkins build is back to normal : pgadmin4-master-python35 #521

See

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

Hi Dave, I have already replied on another thread regarding the failure of these tests, Joao has already sent a patch for the same. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Mar 13, 2018 at 6:20 PM, Dave Page wrote: > And

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

And... reverted. It seems this makes Jenkins very unhappy. On Tue, Mar 13, 2018 at 7:58 AM, Dave Page wrote: > OK, thanks. Patch applied. > > On Tue, Mar 13, 2018 at 12:32 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> We are not joining template path with os.path.join becau

pgAdmin 4 commit: Revert "Fix template path generation for Windows. Fix

Revert "Fix template path generation for Windows. Fixes #3139" This reverts commit 695d4e648cd4cd3a086b407e471932537a793d4b. It's borked! Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9365ab62fee14c570d0e37fa4f0cac3b79a66e72 Modified Files

Build failed in Jenkins: pgadmin4-master-python34 #510

See Changes: [Dave Page] Fix template path generation for Windows. Fixes #3139 -- [...truncated 726.23 KB...] Create parti

Build failed in Jenkins: pgadmin4-master-python33 #517

See Changes: [Dave Page] Fix template path generation for Windows. Fixes #3139 -- [...truncated 724.77 KB...] Attach parti

Build failed in Jenkins: pgadmin4-master-python36 #511

See Changes: [Dave Page] Fix template path generation for Windows. Fixes #3139 -- [...truncated 725.88 KB...] PackagePutTestCase (Fetch Package No

Build failed in Jenkins: pgadmin4-master-python26 #647

See Changes: [Dave Page] Fix template path generation for Windows. Fixes #3139 -- [...truncated 754.48 KB...] PackagePutTestCase (Fetch Package No

Build failed in Jenkins: pgadmin4-master-python27 #521

See Changes: [Dave Page] Fix template path generation for Windows. Fixes #3139 -- [...truncated 750.94 KB...] PackagePutTestCase (Fetch Package No

Build failed in Jenkins: pgadmin4-master-python35 #520

See Changes: [Dave Page] Fix template path generation for Windows. Fixes #3139 -- [...truncated 725.88 KB...] SynonymPutTestCase (Fetch synonym No

Re: [pgAdmin4][RM#3139] Create proper template path if Windows

OK, thanks. Patch applied. On Tue, Mar 13, 2018 at 12:32 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > We are not joining template path with os.path.join because we are passing > prefix paths in render_template(..) at many places, > we are passing them as below

pgAdmin 4 commit: Fix template path generation for Windows. Fixes #3139

Fix template path generation for Windows. Fixes #3139 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=695d4e648cd4cd3a086b407e471932537a793d4b Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/compile_template_name.py

Re: [pgAdmin4][RM#3140] Add service parameter

On Tue, Mar 13, 2018 at 12:12 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > I haven't implemented that intentionally because Khushboo is working on > the same for SSL and our code will conflict, So once Khushboo's patch gets > committed, I'll make changes for