Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hello Murtuza/Dave, Yes now the extracted functions are spread into different files. The intent would be to make the files as small as possible, and also to group and name them in a way that would be easy to understand what each file is doing without the need of opening it. As a example:

pgAdmin 4 commit: Branch refs/heads/REL-2_X was created

Branch refs/heads/REL-2_X was created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=shortlog;h=refs/heads/REL-2_X

pgAdmin 4 commit: Update developer docs to note that ES6 should be used

Update developer docs to note that ES6 should be used and tests should be included. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a97e4c76e4aeac26fe9b37e0466b3d5a619bd04a Modified Files -- docs/en_US/code_review.rst | 3

pgAdmin 4 commit: Add a (configurable) limit to the number of pgAgent j

Add a (configurable) limit to the number of pgAgent job history rows displayed on the statistics tab. Fixes #3072 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ec51412c34df5d27501d618e18f90883a023f14 Author: Murtuza Zabuawala

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

Thanks, applied. On Fri, Apr 6, 2018 at 5:53 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find updated patch which fixes PEP8 issue, added help string for > preference dialog option & updated screenshot. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Joao, Patch looks good and working as expected. I also agree with Dave, Can we please add some comments in each file which can help us to understand the flow, I'm saying because now the code is segregated in so many separate files it will be hard to keep track of the flow from one file to

Re: [pgAdmin4][RM#3154] Update modules to latest version

On Fri, Apr 6, 2018 at 8:52 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > I checked and found that the issue was in wcDocker which was causing > problem while opening query tool, > I have logged an issue on github: https://github.com/ >

Re: [pgAdmin4][RM#3154] Update modules to latest version

Hi Dave, I checked and found that the issue was in wcDocker which was causing problem while opening query tool, I have logged an issue on github: https://github.com/WebCabin/wcDocker/issues/124 Query tool, Debugger etc are working properly when open in new Browser Tab and not in Panel. I'm also