pgAdmin 4 commit: Using the latest version (v2.3.0) of jquery.event.dra

2018-05-09 Thread Ashesh Vashi
Using the latest version (v2.3.0) of jquery.event.drag to fix the jasmine testsuite. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a02a4eb51ab082f5e9799ebd3bf0d4d28aa04c0f Author: Murtuza Zabuawala Modified Files -- web/webpack.

Build failed in Jenkins: pgadmin4-master-python34 #592

2018-05-09 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Using the 'webcabin-docker' from new repository, which contains fixed [Ashesh Vashi] Change the order of the shims in the shims file. --

Build failed in Jenkins: pgadmin4-master-python33 #605

2018-05-09 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Using the 'webcabin-docker' from new repository, which contains fixed [Ashesh Vashi] Change the order of the shims in the shims file. --

Build failed in Jenkins: pgadmin4-master-python36 #598

2018-05-09 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Using the 'webcabin-docker' from new repository, which contains fixed -- [...truncated 663.11 KB...] SynonymAddTestCa

pgAdmin 4 commit: Change the order of the shims in the shims file.

2018-05-09 Thread Ashesh Vashi
Change the order of the shims in the shims file. Patch by: Victoria && Joao Reviweb by: Khushboo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b8f49daeb800d02ed6c4dc5905d00ce4d9e7ae34 Author: Joao De Almeida Pereira Modified Files

pgAdmin 4 commit: Using the 'webcabin-docker' from new repository, whic

2018-05-09 Thread Ashesh Vashi
Using the 'webcabin-docker' from new repository, which contains fixed for supporting jQuery 3.0+. Also - updated the jquery version to '^3.0'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b8d0db7e7afe153ffc08c2f5dfbddf8e0716a58b Modified F

Re: [pgAdmin4][Patch]: Fixed RM #3295 - Shortcut key conflict issue

2018-05-09 Thread Dave Page
Thanks, applied. On Wed, May 9, 2018 at 2:10 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #3295: Shortcut key conflict issue > > After opening the debugger, the shift+alt+o short-cut opens the Object > menu as well as perform the

pgAdmin 4 commit: Release notes update.

2018-05-09 Thread Dave Page
Release notes update. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=26ae8318f26eee9d98167e3eeb32b785bc3f3435 Modified Files -- docs/en_US/release_notes_3_1.rst | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

pgAdmin 4 commit: Ensure the debugger container has focus when loaded.

2018-05-09 Thread Dave Page
Ensure the debugger container has focus when loaded. Fixes #3295 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ba23ba9b8b50f826d7cfc1db4e1f6632e4bd9370 Author: Khushboo Vashi Modified Files -- web/pgadmin/tools/debugger/static/j

[pgAdmin4][Patch]: Fixed RM #3295 - Shortcut key conflict issue

2018-05-09 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM #3295: Shortcut key conflict issue After opening the debugger, the shift+alt+o short-cut opens the Object menu as well as perform the step over to the debugger. This issue has been fixed in this patch. Thanks, Khushboo diff --git a/web/pgadmin/tools/d

pgAdmin 4 commit: Update release notes

2018-05-09 Thread Dave Page
Update release notes Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ffd3d0451aa6282a01c0d5750c17918334e5484 Modified Files -- docs/en_US/release_notes_3_1.rst | 1 + 1 file changed, 1 insertion(+)

pgAdmin 4 commit: Set SESSION_COOKIE_SAMESITE='Lax' per Flask recommend

2018-05-09 Thread Dave Page
Set SESSION_COOKIE_SAMESITE='Lax' per Flask recommendation to prevents sending cookies with CSRF-prone requests from external sites, such as submitting a form. Fixes #3342 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a68dac97c4e7610beb6587

Re: [pgAdmin4] To make session cookie more secure (Server mode)

2018-05-09 Thread Dave Page
Thanks, patch applied. On Wed, May 9, 2018 at 8:33 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to make to make session cookie more secure in Server mode. > We will set SESSION_COOKIE_SAMESITE >

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-09 Thread Dave Page
Hi On Wed, May 9, 2018 at 8:10 AM, Akshay Joshi wrote: > Thanks Anthony for fixing those two test cases. I have verified it and > patch looks good to me. > Attached is the modified patch where I have remove "import time" which is > not required and update the retry message from 10 to 60. > > To

Re: [pgAdmin4][RM#3298] Query tool shortcut issue

2018-05-09 Thread Akshay Joshi
Thanks patch applied. On Tue, May 8, 2018 at 7:29 PM, Victoria Henry wrote: > Hi Aditya, > > The patch looks fine and the tests are passing. > > Sincerely, > > Victoria & Anthony > > On Tue, May 8, 2018 at 8:22 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> PFA patch for q

pgAdmin 4 commit: Fixed query tool keyboard issue where arrow keys were

2018-05-09 Thread Akshay Joshi
Fixed query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Fixes #3298 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b86a67a412b9d170ce3ce886adb5aa4f63388b1 Author: Aditya Toshniwal Modifi

[pgAdmin4] To make session cookie more secure (Server mode)

2018-05-09 Thread Murtuza Zabuawala
Hi, PFA minor patch to make to make session cookie more secure in Server mode. We will set SESSION_COOKIE_SAMESITE ='Lax' in the config file. 'Lax' option prevents sending cookies with CSRF-prone requests from external sites, such as

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-09 Thread Akshay Joshi
Thanks Anthony for fixing those two test cases. I have verified it and patch looks good to me. Attached is the modified patch where I have remove "import time" which is not required and update the retry message from 10 to 60. To be honest I have seen some intermittent "Timeout" issues on *Chrome*