Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Joao On Tue, May 29, 2018 at 9:10 PM, Joao De Almeida Pereira wrote: > Hello Akshay, > > The code looks good, we do have some minor notes for next time: > > . To make the code easier to understand we should decide on 1 term and not > have notifies and notifications to reference the same

Re: [pgadmin4][Patch]: Test cases for the backup module

On Wed, May 30, 2018 at 1:05 AM, Dave Page wrote: > Hi > > On Mon, May 28, 2018 at 8:09 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> please find the attached updated patch for the test cases of Backup, >> Restore and Maintenance modules which includes: >> >> 1.

Re: [pgAdmin4][Patch] RM #3355 User can not perform operation of backup,Backup all, Backup global and Maintenance DB with ssh tunneling

Hi Joao On Tue, May 29, 2018 at 9:24 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Akshay, > > Looks like the tests failed, but it is just flakes. We assume no > regression was made with this code, despite the fact that no tests were > added to ensure the new code is

Re: [pgAdmin4][Patch] RM #3355 User can not perform operation of backup,Backup all, Backup global and Maintenance DB with ssh tunneling

Hello Akshay, Looks like the tests failed, but it is just flakes. We assume no regression was made with this code, despite the fact that no tests were added to ensure the new code is working. Thanks Anthony && Joao On Tue, May 29, 2018 at 6:41 AM Akshay Joshi wrote: > Hi Hackers, > > Attached

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hello Akshay, The code looks good, we do have some minor notes for next time: . To make the code easier to understand we should decide on 1 term and not have notifies and notifications to reference the same thing. . It would be nice if we tried not to use XPATH to get the HTML components that we

pgadmin, docker and ipv6

Hello, I was running my pgadmin4 v2 on my ipv6-only subnet using docker image. After the update, I noticed, that you have changed your webserver from Apache to gunicorn, and it is configured to listen only on ipv4 network (0.0.0.0), so it is unreachable from my network without using docker-proxy

[pgAdmin4][Patch] RM #3355 User can not perform operation of backup,Backup all, Backup global and Maintenance DB with ssh tunneling

Hi Hackers, Attached is the patch to fix RM #3355 User can not perform operation of backup, Backup all, Backup global and Maintenance DB with ssh tunneling. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3355_v1.patch