Re: [pgadmin4][Patch]: Test cases for the backup module

Hi there, We've been noticing some issues with the tests on both our CI and local Mac workstations. 1. When the following code blocks are invoked - we get plenty of app.context() issues. It must not be valid when running tests. ​ from pgadmin.utils.driver import get_driver driver = get_dr

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Rob, My sincere apologies for the delay - I have told the team to prioritise getting patch 0003 agreed and committed, and to get an understanding of 0004 and to ask any questions etc. they may have. This *will* get done ASAP. On Thu, May 31, 2018 at 10:39 AM, Robert Eckhardt wrote: > All, > >

Re: Container build hanging

Hi Victoria Thanks for investigating - that seems to fix the problem. I've committed the fix. Regards, Dave. On Thu, May 31, 2018 at 10:32 AM, Victoria Henry wrote: > Hey Dave, > > The reason that it was taking so long was because the linter was acting on > the javascript in the ycache directo

pgAdmin 4 commit: Ignore the ycache directory when linting.

Ignore the ycache directory when linting. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=98f84e5f34a5e95ec968a0d2b70162f5dce305b8 Modified Files -- web/.eslintignore | 1 + 1 file changed, 1 insertion(+)

pgAdmin 4 commit: Include libffi-devel in the Docker build.

Include libffi-devel in the Docker build. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4372dd051e11644ff71d223843323fade3a115c7 Modified Files -- pkg/docker/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Correct package name

Correct package name Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6719ff141bc1f3095082143b2420486351da7ab6 Modified Files -- pkg/docker/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Fix Gunicorn binding for IPv4.

Fix Gunicorn binding for IPv4. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2860e82c632e3c3a04664da3e83795eb6db7209c Modified Files -- pkg/docker/entrypoint.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

All, These patches were first proposed on April 2 and the meaningful changes have yet to be committed. ~8 weeks is long enough that my assumption now is that these aren't going to be committed. The goal of these patches is to begin to separate out the ACI tree in order to allow us to do feature w

Re: Container build hanging

Hey Dave, The reason that it was taking so long was because the linter was acting on the javascript in the ycache directory in the container. The fix is to add the ycache directory to the .eslintignore file. We can send a patch file, if you’d like: diff --git a/web/.eslintignore b/web/.eslintigno

pgAdmin 4 commit: Update the release notes.

Update the release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=985e089c232d7afd21c6c00814a2a1cb0290bdf5 Modified Files -- docs/en_US/release_notes_3_1.rst | 1 + 1 file changed, 1 insertion(+)

pgAdmin 4 commit: Bind the container server to ipv6 as well as ipv4 por

Bind the container server to ipv6 as well as ipv4 ports. Fixes #3392 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eec97141917ad9868480d77041efe7e4829aa983 Modified Files -- pkg/docker/entrypoint.sh | 4 ++-- 1 file changed, 2 ins

Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

Thanks, patch pushed. On Wed, May 30, 2018 at 9:26 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue when you change any field in server > dialog 'tunnel_identity_file' model value get included unnecessarily in the > update request. > >

pgAdmin 4 commit: Fix an issue where a change to any field in server di

Fix an issue where a change to any field in server dialog causes the 'tunnel_identity_file' model value to get included unnecessarily in the update request. Fixes #3389 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f877de6a1f24a65975492bc23

Re: [pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

Thanks, applied. On Thu, May 31, 2018 at 4:52 AM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch file to fix RM #3277 Runtime startup error handling > is broken on Windows. I have figure out the crash at the following call of > Server.cpp(line no 326): > > PyRun_SimpleFile(fdopen(Py

pgAdmin 4 commit: Cleanup Python 3 server startup code. Fixes #3277

Cleanup Python 3 server startup code. Fixes #3277 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5f0799714d0e13ff89d0b7a366fbf5176c05ce12 Author: Akshay Joshi Modified Files -- runtime/Server.cpp | 4 +--- 1 file changed, 1 insert

Re: [pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

Hi Akshay, Thanks for the patch. It looks good to me as long as it also works on windows. Sincerely, Victoria & Anthony On Thu, May 31, 2018 at 4:53 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch file to fix RM #3277 Runtime startup error handling > is broken on Windows. I ha

Re: [pgAdmin4][Patch#3389] To prevent unwanted model changes in Server dialog

Hey Murtuza, Thanks for the explanation. That seems fine. This patch can be submitted. Sincerely, Victoria & Anthony On Thu, May 31, 2018 at 2:22 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello Victoria & Joao, > > > On Thu, May 31, 2018 at 2:17 AM, Joao De Almeida

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Thu, May 31, 2018 at 1:20 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Victoria/Joao, > > On Thu, May 31, 2018 at 2:06 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Aditya, >> >> It looks ok and it passes CI. >> >> We have some reco

pgAdmin 4 commit: Remove bug 3357 from the release notes. As it was a f

Remove bug 3357 from the release notes. As it was a fix to a feature that will be in the next release, users will never have seen the bug so we shouldn't list it in the notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc63b278be36e991cf

pgAdmin 4 commit: Fixed ordering of changes in release note and added o

Fixed ordering of changes in release note and added one missing entry. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55232b0944b11b954b9611acf7add801736725a7 Modified Files -- docs/en_US/release_notes_3_1.rst | 9 + 1 file

[pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

Hi Hackers, Attached is the patch file to fix RM #3277 Runtime startup error handling is broken on Windows. I have figure out the crash at the following call of Server.cpp(line no 326): PyRun_SimpleFile(fdopen(PyObject_AsFileDescriptor(PyFileObject),"r"), m_ appfile_utf8.data()) When application