Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi On Tue, Jun 5, 2018 at 1:08 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Aditya, > >> >> >> There is no change related to notifications in this patch. >> The below code is minor fix related to connection status of sql editor. >> Can you please share the code snipp

[pgAdmin4][patch] sqleditor connection status minor patch

Hi Hackers, PFA a minor patch for sqleditor. When you disconnect the server with an open sqleditor tab, exception occurs at the back end. Also, after connecting server, the sqleditor is not able to connect back because of the exception. The patch is to handle it. Kindly review. Thanks and Regards

Re: pgAgent 4.0 patch

On Mon, Jun 4, 2018 at 10:04 PM, Dave Page wrote: > Hi > > Can you review the attached please Ashesh? > Hi Dave, Due to the wrong pattern in '.gitignore', it was ignoring the new file 'sql/pgagent--3.4--4.0.sql'. We should ignore only the '*.sql' in the root directory. Something like this. *$ g

Re: [pgadmin4][Patch]: Test cases for the backup module

On Mon, Jun 4, 2018 at 8:41 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Khushboo, > > Some tests are failing in greenplum: > https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/ > pipelines/pgadmin-patch/jobs/run-tests/builds/108 > The piece of code responsible for the e

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hello Aditya, > > > There is no change related to notifications in this patch. > The below code is minor fix related to connection status of sql editor. > Can you please share the code snippet if it is not the below. > > -# Check for the asynchronous notifies statements. > -conn.ch

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Victoria/Joao, There is no change related to notifications in this patch. The below code is minor fix related to connection status of sql editor. Can you please share the code snippet if it is not the below. -# Check for the asynchronous notifies statements. -conn.check_notifie

pgAgent 4.0 patch

Hi Can you review the attached please Ashesh? Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company pgagent-4.0-update.diff Description: Binary data

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Aditya, Looks like there are changes in this patch that are related to notifications, these should go into a separate commit as they are not related to encoding. Also the tests are failing in our pipeline: https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/

Re: [pgadmin4][Patch]: Test cases for the backup module

Hi Khushboo, Some tests are failing in greenplum: https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/108 The piece of code responsible for the error is: if server['default_binary_paths'] is not None: test_utils.set_preference(server['default_binar

Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.

Hi Hackers, Please ignore previous patch. Fixed some linter issues. PFA updated patch. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Mon, Jun 4, 2018 at 10:53 AM, Aditya Toshniwal < aditya.toshni...@en

Re: [pgAdmin4][RM#3307]User interface unable to connect to database running on port range 1-1024

Missed the attachment. Apologies :( PFA. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Mon, Jun 4, 2018 at 3:12 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I mis

Re: [pgAdmin4][RM#3307]User interface unable to connect to database running on port range 1-1024

Hi Hackers, I missed one part here. There is a constraint on port in in sqlite config database also, and is not allowing ports below 1024. PFA patch - part2 which includes constraint change and migration script for the db file. Kindly review. Thanks and Regards, Aditya Toshniwal Software Engineer