[pgadmin4][Patch]: Remove extra space from create script for Procedures.

2018-06-14 Thread Akshay Joshi
Hi Hackers, Attached is the patch to remove extra space from create script for Procedures. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Remove_Extra_Space_Procedure.patch Description: Binary data

[pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL

2018-06-14 Thread Akshay Joshi
Hi Hackers, Attached is the patch for RM #3356 pgAdmin 4 does not include schema name in generated package SQL. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3356.patch Description: Binary data

Re: pgadmin_page functions updated

2018-06-14 Thread Khushboo Vashi
Hi Shubham, On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > > I have modified following two functions in pgadmin_page.py :- > > 1. click_tab() -> Added wait till element is clickable, test cases are > failing since the function attempts to

Re: RM#3294 - User need to reset the layout to see the changed preferences parameters

2018-06-14 Thread Khushboo Vashi
On Thu, Jun 14, 2018 at 6:54 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Victoria/Hackers, > > On Tue, Jun 12, 2018 at 9:52 PM, Victoria Henry wrote: > >> Hi Aditya, >> >> >> It is not possible to fire event in another tab/new browser window. For > example, query too

pgAdmin 4 commit: Don't pipe the list of binaries through uniq.

2018-06-14 Thread Dave Page
Don't pipe the list of binaries through uniq. It seems to be overflowing a buffer and truncating output with Python 3, plus it's being fed a single line only so isn't actually doing anything. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9654

pgAdmin 4 commit: Enable building of the appbundle with Python 3.6.

2018-06-14 Thread Dave Page
Enable building of the appbundle with Python 3.6. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1d322e2cd9bca78429225bc8e2c46564f1333be7 Modified Files -- pkg/mac/build.sh | 43 +++ 1 file c

pgadmin_page functions updated

2018-06-14 Thread Shubham Agarwal
Hi Team, I have modified following two functions in pgadmin_page.py :- 1. click_tab() -> Added wait till element is clickable, test cases are failing since the function attempts to click the tab which is not yet in the state to be clicked. 2. add_server() -> Replaced the sleep statement with wai

Re: RM#3294 - User need to reset the layout to see the changed preferences parameters

2018-06-14 Thread Aditya Toshniwal
Hi Victoria/Hackers, On Tue, Jun 12, 2018 at 9:52 PM, Victoria Henry wrote: > Hi Aditya, > > > It is not possible to fire event in another tab/new browser window. For example, query tool can be open in another tab. And thus, changes are not reflected there. There are solutions availabl

Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted

2018-06-14 Thread Khushboo Vashi
On Thu, Jun 14, 2018 at 3:48 PM, Dave Page wrote: > > > On Thu, Jun 14, 2018 at 11:11 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 14, 2018 at 1:20 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi < >>> khushboo.va...

Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted

2018-06-14 Thread Dave Page
On Thu, Jun 14, 2018 at 11:11 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Jun 14, 2018 at 1:20 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the fix for

Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted

2018-06-14 Thread Khushboo Vashi
On Thu, Jun 14, 2018 at 1:20 PM, Dave Page wrote: > Hi > > On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the fix for #3411 - pgAdmin 4, Mac. The application server >> could not be contacted >> >> The issue is with french tra

Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion

2018-06-14 Thread Dave Page
On Thu, Jun 14, 2018 at 10:06 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > > > On Thu, Jun 14, 2018 at 1:14 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch fo

Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion

2018-06-14 Thread Akshay Joshi
On Thu, Jun 14, 2018 at 1:14 PM, Dave Page wrote: > Hi > > On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for the Feature #2686 Property to switch >> lower/upper case auto completion. I have added new preference

pgAgent commit: Update file header comment.

2018-06-14 Thread Dave Page
Update file header comment. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=5792a003c9da8c212b4b70d929cdf0abd33647c8 Author: Rushabh Lathia Modified Files -- sql/pgagent--unpackaged--4.0.sql | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PGAGENT] Upgrade pgAgent from unpackaged version

2018-06-14 Thread Dave Page
Thanks Rushabh - patch applied! On Thu, Jun 14, 2018 at 5:49 AM, Rushabh Lathia < rushabh.lat...@enterprisedb.com> wrote: > Thanks Ashesh and Dave. > > I verified the changes and it looks good to me. I found that newly > added unpackaged file still have old file header comment. Which > require

Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted

2018-06-14 Thread Dave Page
Hi On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the fix for #3411 - pgAdmin 4, Mac. The application server > could not be contacted > > The issue is with french translation which has been taken care in the > attached patch. > We'

Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion

2018-06-14 Thread Dave Page
Hi On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch for the Feature #2686 Property to switch lower/upper > case auto completion. I have added new preferences settings "Keywords in > uppercase" if it is set to True then all the keywords are shown in upp

[pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion

2018-06-14 Thread Akshay Joshi
Hi Hackers, Attached is the patch for the Feature #2686 Property to switch lower/upper case auto completion. I have added new preferences settings "Keywords in uppercase" if it is set to True then all the keywords are shown in upper case in auto completion. I have also implemented the second requ