Re: [pgAdmin4][Patch]: Fixed Feature #3503 and RM #3347

2018-08-21 Thread Akshay Joshi
On Tue, Aug 21, 2018 at 4:23 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > In restore, if I focus on "No of Jobs" and then click restore, I get an > error as "object of type 'bool' has no len()" (looks like an existing issue) > Apart from this, all looks good to

pgAdmin 4 commit: 1. Added new backup/restore options for PostgreSQL 11

2018-08-21 Thread Akshay Joshi
1. Added new backup/restore options for PostgreSQL 11. Fixes #3503 2. Ensure backup should work with '--data-only' and '--schema-only' for any format. Fixes #3347 3. Added supported "Dump Options" for "pg_dumpall" which was not there since pgAdmin 3. 4. Fixed issue where "--clean" should not club

Re: Fix for RM3547

2018-08-21 Thread Ashesh Vashi
On Wed, Aug 22, 2018 at 12:56 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix RM3547 > Thanks - committed! -- Thanks, Ashesh > > Thanks, > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com

pgAdmin 4 commit: Make the session thread safe.

2018-08-21 Thread Ashesh Vashi
Make the session thread safe. As sessions in pgAdmin4 are filesystem based session, they need locking for avoiding the access from multiple threads, specially running as an WSGI application. Fixes #3547 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=comm

Fix for RM3547

2018-08-21 Thread Harshal Dhumal
Hi, Please find attached patch to fix RM3547 Thanks, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/utils/session.py b/web/pgadmin/utils/session.py index fa313e0..cdf39ce 100644 --- a/web/pga

Re: [pgAdmin4][RM3136] Stabilise feature tests for continuous running on CI sytems

2018-08-21 Thread Akshay Joshi
Thanks patch applied with following changes: - Remove "*self._screenshot()" *method from each feature test as it will take screenshot every time even though test case will execute successfully. - Fix pep8 issues. - Remove unnecessary blank lines. - Change function name from "setT

pgAdmin 4 commit: Stabilise feature tests for continuous running on CI

2018-08-21 Thread Akshay Joshi
Stabilise feature tests for continuous running on CI systems. Fixes #3136. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=70c95fcdd54923ca173e9e83116616cbcfa221b2 Author: Usman Muzaffar Modified Files -- docs/en_US/release_notes_

Re: [pgAdmin4][Patch]: Fixed Feature #3503 and RM #3347

2018-08-21 Thread Aditya Toshniwal
Hi Akshay, In restore, if I focus on "No of Jobs" and then click restore, I get an error as "object of type 'bool' has no len()" (looks like an existing issue) Apart from this, all looks good to me. Test cases run successfully. On Tue, Aug 21, 2018 at 12:15 PM, Akshay Joshi < akshay.jo...@ente

[pgAdmin4][RM #3313] "Select All" & "Unselect All" not working in Select2 control

2018-08-21 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue where "Select All"/"Unselect All" option is not working as expected. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3313.diff Description: Binary data

[pgAdmin4][RM3561] Can't edit Sort/Filter Options after losing database connection

2018-08-21 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix filter dialog issue where it was not opening at all when server is disconnected. The patch will make filter button behaviour similar to Execute query button and will ask to connect. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB

Re: [pgAdmin4][RM3558] Sort/Filter dialog editing is broken

2018-08-21 Thread Akshay Joshi
Thanks patch applied. On Mon, Aug 20, 2018 at 5:12 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the cursor size issue where the cursor size > is very small even if text is larger. > > Kindly review. > > -- > Thanks and Regards, >

pgAdmin 4 commit: 1) Fix sort/filter dialog editing issue. Fixes #3558.

2018-08-21 Thread Akshay Joshi
1) Fix sort/filter dialog editing issue. Fixes #3558. 2) Fix sort/filter dialog issue where it incorrectly requires ASC/DESC. Fixes #3325. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57660d131f2ec6356f9d5bee2add91886d9329be Author: Aditya