Build failed in Jenkins: pgadmin4-master-python27 #758

2018-09-14 Thread pgAdmin 4 Jenkins
See -- [...truncated 813.47 KB...] EDB Postgres AS 9.6: 361 tests passed 0 tests failed 14 tests skipped: MaintenanceJobTest (When main

Build failed in Jenkins: pgadmin4-master-python33 #758

2018-09-14 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Chance an update to Node 8. Let's see how Jenkins likes this. -- [...truncated 811.40 KB...] BackupCreateJobTest (When ba

Build failed in Jenkins: pgadmin4-master-python26 #894

2018-09-14 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Chance an update to Node 8. Let's see how Jenkins likes this. -- [...truncated 815.03 KB...] EDB Postgres AS 9.6: 361 tests pas

Build failed in Jenkins: pgadmin4-master-python27 #757

2018-09-14 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update some of the JS dependencies to ensure we can use Node 10. Fixes [Dave Page] Chance an update to Node 8. Let's see how Jenkins likes this. --

Build failed in Jenkins: pgadmin4-master-python35 #748

2018-09-14 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update some of the JS dependencies to ensure we can use Node 10. Fixes [Dave Page] Chance an update to Node 8. Let's see how Jenkins likes this. --

Build failed in Jenkins: pgadmin4-master-python34 #747

2018-09-14 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update some of the JS dependencies to ensure we can use Node 10. Fixes [Dave Page] Chance an update to Node 8. Let's see how Jenkins likes this. --

Build failed in Jenkins: pgadmin4-master-python36 #750

2018-09-14 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update some of the JS dependencies to ensure we can use Node 10. Fixes [Dave Page] Chance an update to Node 8. Let's see how Jenkins likes this. --

Build failed in Jenkins: pgadmin4-master-python33 #757

2018-09-14 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update some of the JS dependencies to ensure we can use Node 10. Fixes -- [...truncated 811.68 KB...]

pgAdmin 4 commit: Chance an update to Node 8. Let's see how Jenkins lik

2018-09-14 Thread Dave Page
Chance an update to Node 8. Let's see how Jenkins likes this. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2258c83e9656d007b3febf58a2ced51e643527f Modified Files -- pkg/docker/Dockerfile | 4 ++-- 1 file changed, 2 insertions(+)

Build failed in Jenkins: pgadmin4-master-python26 #893

2018-09-14 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update some of the JS dependencies to ensure we can use Node 10. Fixes -- [...truncated 814.94 KB...] EDB Postgres AS 9.6: 361

Re: RM #3649 hard-source-webpack-plugin causes hard-source-webpack-plugin to fail on node v. 10.x

2018-09-14 Thread Dave Page
Thanks - patch applied. FYI for others - Node 8 or later is required. Let's see if this breaks any of the build systems :-) On Fri, Sep 14, 2018 at 2:00 PM, Atle Frenvik Sveen wrote: > Hi list! > > Attached fix for #3649. > > Hopefully I did everything right here regarding the patch. > > Everyt

pgAdmin 4 commit: Update some of the JS dependencies to ensure we can u

2018-09-14 Thread Dave Page
Update some of the JS dependencies to ensure we can use Node 10. Fixes #3649 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=370d9c72eccf069613aa3a5d7feb1409a11f9f08 Author: Atle Frenvik Sveen Modified Files -- web/package.json |

Re: [pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly

2018-09-14 Thread Dave Page
Sidenote: This does seem like something we should have a test for. On Fri, Sep 14, 2018 at 3:32 PM, Dave Page wrote: > Hi > > On Fri, Sep 14, 2018 at 12:48 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #3551 pgAdmin4 doesn't han

Re: [pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly

2018-09-14 Thread Dave Page
Hi On Fri, Sep 14, 2018 at 12:48 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix RM #3551 pgAdmin4 doesn't handle \'s in data > fields correctly. > This doesn't work for me. If I add a new row and enter: \\server\path\to\file as a value,

Re: [pgAdmin4][Patch]: Added basic start up logs for RunTime

2018-09-14 Thread Dave Page
Thanks, applied with a couple of tweaks: - Changed the logfile name to ~/.pgAdmin4.startup.log (for greater consistency with the runtime log). - Secured the permissions of the logfile as soon as it's created, to avoid key leaks. On Thu, Sep 13, 2018 at 2:06 PM, Akshay Joshi wrote: > Hi Hackers,

pgAdmin 4 commit: Add a startup logger to the runtime to aid with debug

2018-09-14 Thread Dave Page
Add a startup logger to the runtime to aid with debugging. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=026969e3d1ae47a4bfb810c8ceb419f068c2c238 Author: Akshay Joshi Modified Files -- runtime/Logger.cpp | 59 +

Re: [pgAdmin4][Patch]: RM #3607 Edit Data: Not able to remove filter SQL condition

2018-09-14 Thread Dave Page
Thanks, patch applied! On Thu, Sep 13, 2018 at 7:10 AM, Akshay Joshi wrote: > > > On Wed, Sep 12, 2018 at 10:38 PM, Dave Page wrote: > >> >> >> On 12 Sep 2018, at 17:30, Akshay Joshi >> wrote: >> >> >> >> On Wed, 12 Sep 2018, 20:34 Dave Page, wrote: >> >>> >>> >>> On Wed, Sep 12, 2018 at 3:42

pgAdmin 4 commit: Fix logic around validation and highlighting of Sort/

2018-09-14 Thread Dave Page
Fix logic around validation and highlighting of Sort/Filter in the Query Tool. Fixes #3607 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ec3224212f1505eef43a840be6b72b1261e51b0 Author: Akshay Joshi Modified Files -- docs/en_US

RM #3649 hard-source-webpack-plugin causes hard-source-webpack-plugin to fail on node v. 10.x

2018-09-14 Thread Atle Frenvik Sveen
Hi list! Attached fix for #3649. Hopefully I did everything right here regarding the patch. Everything seems to work as expected after upgrading hard-source-webpack-plugin -a -- Atle Frenvik Sveen a...@frenviksveen.net 45278689 atlefren.net From 834c7a3d97875410521f2bd73de5cb371601c

[pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly

2018-09-14 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3551.patch Description: Binary data

Re: Custom layers in PgAdmin IV Mapview

2018-09-14 Thread Dave Page
On Fri, Sep 14, 2018 at 10:43 AM, Atle Frenvik Sveen wrote: > Thanks! > > > Another question: > > I had issues running make install-node using node 10.x. The issue was > related to an old version of the leveldown package ( > https://github.com/Level/leveldown/issues/455). > > The dependency on le

Re: Custom layers in PgAdmin IV Mapview

2018-09-14 Thread Atle Frenvik Sveen
Thanks! Another question: I had issues running make install-node using node 10.x. The issue was related to an old version of the leveldown package (https://github.com/Level/leveldown/issues/455). The dependency on leveldown was introduced by the hard-source-webpack-plugin, which was requir

Re: Custom layers in PgAdmin IV Mapview

2018-09-14 Thread Dave Page
Hi On Fri, Sep 14, 2018 at 8:44 AM, Atle Frenvik Sveen wrote: > Dave, Khushboo: > > Thanks for your replies. I've created an issue here: > https://redmine.postgresql.org/issues/3646 > > Please feel free to comment and suggest changes. > > Thank you both for your input! > > I guess I will spend s

Re: Custom layers in PgAdmin IV Mapview

2018-09-14 Thread Atle Frenvik Sveen
Dave, Khushboo: Thanks for your replies. I've created an issue here: https://redmine.postgresql.org/issues/3646 Please feel free to comment and suggest changes. Thank you both for your input! I guess I will spend some time getting to know this code-base, and when time comes I think I will ne