Re: [pgAdmin4][Patch]: RM #3551 pgAdmin4 doesn't handle \'s in data fields correctly

2018-09-18 Thread Akshay Joshi
Hi Dave On Fri, Sep 14, 2018 at 8:02 PM, Dave Page wrote: > Hi > > On Fri, Sep 14, 2018 at 12:48 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #3551 pgAdmin4 doesn't handle \'s in data >> fields correctly. >> > > This doesn't wo

Re: Custom layers in PgAdmin IV Mapview

2018-09-18 Thread Atle Frenvik Sveen
On Tue, Sep 18, 2018, at 17:39, Dave Page wrote: > Hi > > On Tue, Sep 18, 2018 at 11:09 AM, Atle Frenvik Sveen > wrote: > > > Hello again! > > > > I think I've accomplished this task now, see last screenshot and attached > > patch. > > > > I hope I did this patch right? > > git checkout maste

Re: Custom layers in PgAdmin IV Mapview

2018-09-18 Thread Dave Page
Hi On Tue, Sep 18, 2018 at 11:09 AM, Atle Frenvik Sveen wrote: > Hello again! > > I think I've accomplished this task now, see last screenshot and attached > patch. > > I hope I did this patch right? > git checkout master > git fetch upstream > git merge upstream/master > git checkout mapviewer_

Re: [pgAdmin4][Patch]: RM #3464 pgAdmin 4 won't start on windows

2018-09-18 Thread Dave Page
Thanks - patch applied. Great work figuring this one out! On Tue, Sep 18, 2018 at 12:18 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > Recently we have added basic startup logs and because of that we came to > know that pgAdmin4 is not able to open the log file if the

pgAdmin 4 commit: Ensure the runtime can startup properly if there are

2018-09-18 Thread Dave Page
Ensure the runtime can startup properly if there are wide characters in the logfile path on Windows. Fixes #3464 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a46e4356757c9b990cfd12e3378464aa4362fa1 Author: Akshay Joshi Modified Files ---

Re: [pgAdmin4][Patch]: RM #3464 pgAdmin 4 won't start on windows

2018-09-18 Thread Akshay Joshi
On Tue, Sep 18, 2018 at 4:52 PM, Dave Page wrote: > Hi > > On Tue, Sep 18, 2018 at 12:18 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Recently we have added basic startup logs and because of that we came to >> know that pgAdmin4 is not able to open the log fil

Re: [pgAdmin4][Patch]: RM #3464 pgAdmin 4 won't start on windows

2018-09-18 Thread Dave Page
Hi On Tue, Sep 18, 2018 at 12:18 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > Recently we have added basic startup logs and because of that we came to > know that pgAdmin4 is not able to open the log file if the file path > contains Cyrillic alphabet or Special chara

[pgAdmin4][Patch]: RM #3464 pgAdmin 4 won't start on windows

2018-09-18 Thread Akshay Joshi
Hi Hackers, Recently we have added basic startup logs and because of that we came to know that pgAdmin4 is not able to open the log file if the file path contains Cyrillic alphabet or Special characters. *fopen* fails to open the file, so I have used *_wfopen *for Windows operating system. Attach

Re: Custom layers in PgAdmin IV Mapview

2018-09-18 Thread Aditya Toshniwal
Hi, On Tue, Sep 18, 2018 at 2:25 PM Atle Frenvik Sveen wrote: > Thanks for the suggestion! It seems that the style was indeed loaded, it > just did not do what I expected it to do :/ > > But, when using the module/static/css/module.css file-approach, I guess > web\pgadmin\preferences\static\css\

Re: Custom layers in PgAdmin IV Mapview

2018-09-18 Thread Atle Frenvik Sveen
Thanks for the suggestion! It seems that the style was indeed loaded, it just did not do what I expected it to do :/ But, when using the module/static/css/module.css file-approach, I guess web\pgadmin\preferences\static\css\preferences.css is the right path for css related to the preferences-ta

Re: Custom layers in PgAdmin IV Mapview

2018-09-18 Thread Dave Page
On Tue, Sep 18, 2018 at 9:06 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Sep 18, 2018 at 1:32 PM Aditya Toshniwal enterprisedb.com> wrote: > >> Hi, >> >> >> On Tue, Sep 18, 2018 at 12:43 AM Atle Frenvik Sveen < >> a...@frenviksveen.net> wrote: >> >>> Hi agai

Re: Custom layers in PgAdmin IV Mapview

2018-09-18 Thread Aditya Toshniwal
Hi, On Tue, Sep 18, 2018 at 1:32 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > > On Tue, Sep 18, 2018 at 12:43 AM Atle Frenvik Sveen > wrote: > >> Hi again! >> >> I started digging around in the code used to display the Grid in the >> table dialogue, this worked a lot

Re: Custom layers in PgAdmin IV Mapview

2018-09-18 Thread Aditya Toshniwal
Hi, On Tue, Sep 18, 2018 at 12:43 AM Atle Frenvik Sveen wrote: > Hi again! > > I started digging around in the code used to display the Grid in the table > dialogue, this worked a lot better. Now most things works as expected, > although I decided to re-write the Grid-using code rather than re-