Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

Hi Some relatively minor details to fix please: - There's no doc update. - I think fa-trash-alt might be better for the Drop icon. - I don't like the Drop Cascade icon. Maybe have Chethana create one based on fa-trash-alt, shrunken a little with a downwards pointing arrow on the bottom right.

Re: fixes for browser.tests api test cases

On Wed, Oct 17, 2018 at 1:56 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > > > On Wed, Oct 17, 2018 at 4:02 PM, Dave Page wrote: > >> Hi >> >> On Tue, Oct 16, 2018 at 1:35 PM Usman Muzaffar < >> usman.muzaf...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find here at

Re: fixes for browser.tests api test cases

On Wed, Oct 17, 2018 at 4:02 PM, Dave Page wrote: > Hi > > On Tue, Oct 16, 2018 at 1:35 PM Usman Muzaffar < > usman.muzaf...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find here attached patch for the following test cases,(in package >> pgadmin.browser.tests) which were failing. >> >>

Re: [pgAdmin4][RM3703] Clear user connections on logout

Thanks, patch applied. On Mon, Oct 15, 2018 at 10:25 AM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find patch to clear user connections on logout. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterpris

pgAdmin 4 commit: Purge connections from the cache on logout. Fixes #37

Purge connections from the cache on logout. Fixes #3703 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=822d38474621bef9e5587873661b21735de0bb2b Author: Harshal Dhumal Modified Files -- docs/en_US/release_notes_3_5.rst

pgAdmin 4 commit: Fix connection garbage collector. Fixes #3700

Fix connection garbage collector. Fixes #3700 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce31726af5badd4fbc419e157ecea7cb6de9df92 Author: Harshal Dhumal Modified Files -- docs/en_US/release_notes_3_5.rst | 1 + we

Re: [pgAdmin4][Patch] RM #3700 fix connection garbage collector

Thanks, patch applied. On Fri, Oct 12, 2018 at 1:24 PM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > This issues caused as we were iterating over manager keys (which contains > server ids) and > not on server managers. > > Attached patch fixes this issue. > > > -- > *Harshal

pgAdmin 4 commit: Release note update

Release note update Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=494a8ac3fe81f3ee1132c312f0cfaf6abb6a17d8 Modified Files -- docs/en_US/release_notes_3_5.rst | 1 + 1 file changed, 1 insertion(+)

Re: [pgAdmin4][Patch]: RM #3638 Syntax Error displayed when user try to create new Schedule and select start date and time in Exception

Thanks, patch applied. On Fri, Oct 12, 2018 at 12:18 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM 3638 "Syntax Error displayed when user > try to create new Schedule and select start date and time in Exception". > Patch contains following fixes: > >- Fixed syn

pgAdmin 4 commit: Fix syntax error when creating new pgAgent schedules

Fix syntax error when creating new pgAgent schedules with a start date/time and exception. Fixes #3638 - Fixed syntax error. - Update/Delete exceptions are not working, SQL is wrong. - Wrong exception time is shown, it should shown in UTC as datatype of the column is timestamp with out timezone.

Re: fixes for browser.tests api test cases

Hi On Tue, Oct 16, 2018 at 1:35 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for the following test cases,(in package > pgadmin.browser.tests) which were failing. > >- test_change_password >- test_gravatar_image_display >

Re: [pgAdmin4][patch] Changes to stabilise feature tests

Hi On Tue, Oct 16, 2018 at 12:41 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Oct 16, 2018 at 3:00 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to stabilise feature tests. Major changes includes

pgAdmin 4 commit: Additional feature test fixes:

Additional feature test fixes: 1) Changes required for working with Bootstrap 4. 2) Change to fix the timeout exception when waiting for element (tested multiple times on multiple server, did not occur to me thereafter) 3) Removed reset layout after each test case. Instead, delete the layout entr