[pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

2019-01-09 Thread Harshal Dhumal
Hi, This patch fixes Dialog tabset keyboard navigation. This regression was caused due to bootstrap 4 changes. Also I have added jasmine test cases for the same -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --g

Re: [pgAdmin4][Patch] - RM 3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11

2019-01-09 Thread Akshay Joshi
Hi Attached is the modified patch. I have fixed the similar code for Backup and Restore as well along with this patch. On Thu, Jan 10, 2019 at 12:26 PM Dave Page wrote: > Hi > > On Wed, Jan 9, 2019 at 6:46 PM Akshay Joshi > wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #3836 VA

Build failed in Jenkins: pgadmin4-master-python35 #849

2019-01-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure the context menu works after a server is renamed. Fixes #3575 -- [...truncated 1012.93 KB...] HeadlessChrome 0.0.0 (Linux

Re: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help

2019-01-09 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix jasmine test cases failures. Kindly review. On Thu, Jan 10, 2019 at 11:21 AM Dave Page wrote: > Thanks, applied. > > On Wed, Jan 9, 2019 at 6:31 PM Aditya Toshniwal > wrote: > > > > Hi Hackers, > > > > Attached is a tiny patch to fix the Postgres help f

Build failed in Jenkins: pgadmin4-master-python27 #863

2019-01-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Don't show system catalogs in the schemas property list unless show [Dave Page] Ensure the context menu works after a server is renamed. Fixes #3575 ---

Re: [pgAdmin4][Patch] - RM 3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11

2019-01-09 Thread Dave Page
Hi On Wed, Jan 9, 2019 at 6:46 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #3836 VACUUM FULL FREEZE ANALYZE VERBOSE > syntax error on PostgreSQL 11. Order of commands has been changed in > PostgreSQL 11 "https://github.com/postgres/postgres > /commit/921059bd66c7fb12

Build failed in Jenkins: pgadmin4-master-python34 #851

2019-01-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Don't show system catalogs in the schemas property list unless show [Dave Page] Ensure the context menu works after a server is renamed. Fixes #3575 ---

Build failed in Jenkins: pgadmin4-master-python36 #853

2019-01-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Don't show system catalogs in the schemas property list unless show [Dave Page] Ensure the context menu works after a server is renamed. Fixes #3575 ---

Build failed in Jenkins: pgadmin4-master-python37 #96

2019-01-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix help for the backup/restore dialogues. Fixes #3861 [Dave Page] Don't show system catalogs in the schemas property list unless show [Dave Page] Ensure the context menu works

Build failed in Jenkins: pgadmin4-master-python35 #848

2019-01-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix help for the backup/restore dialogues. Fixes #3861 [Dave Page] Don't show system catalogs in the schemas property list unless show -

Re: [pgAdmin4][RM3575] Right click does not work on database node if server name changed

2019-01-09 Thread Dave Page
Thanks - patch applied. On Wed, Jan 9, 2019 at 4:16 PM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is the patch to fix the issue where changing the name (or any > visible property on tree) of the server node breaks the context menu on the > database nodes. > > The user information of t

pgAdmin 4 commit: Ensure the context menu works after a server is renam

2019-01-09 Thread Dave Page
Ensure the context menu works after a server is renamed. Fixes #3575 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f7fa18f8272e92dcb97242e7ac2550d464df6976 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_1.

Build failed in Jenkins: pgadmin4-master-python27 #862

2019-01-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix help for the backup/restore dialogues. Fixes #3861 -- [...truncated 1014.87 KB...] HeadlessChrome 0.0.0 (Linux 0.0.0): Execut

Re: [pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab

2019-01-09 Thread Dave Page
Hi On Wed, Jan 9, 2019 at 4:09 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM #3842 pg_catalogs schema should not > displayed in properties tab. > > Please review it. > Thanks, applied. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK

pgAdmin 4 commit: Don't show system catalogs in the schemas property li

2019-01-09 Thread Dave Page
Don't show system catalogs in the schemas property list unless show system objects is enabled. Fixes #3842 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=01b87d48341148c0c0a8264eef017154185c5f64 Author: Akshay Joshi Modified Files -

Build failed in Jenkins: pgadmin4-master-python34 #850

2019-01-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix help for the backup/restore dialogues. Fixes #3861 -- [...truncated 1012.86 KB...] HeadlessChrome 0.0.0 (Linux 0.0.0): Execut

Re: Build failed in Jenkins: pgadmin4-master-python36 #852

2019-01-09 Thread Aditya Toshniwal
I'm looking into this. On Thu, Jan 10, 2019 at 11:32 AM pgAdmin 4 Jenkins wrote: > See < > https://jenkins.pgadmin.org/job/pgadmin4-master-python36/852/display/redirect?page=changes > > > > Changes: > > [Dave Page] Fix help for the backup/restore dialogues. Fixes #3861 > > --

Build failed in Jenkins: pgadmin4-master-python36 #852

2019-01-09 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix help for the backup/restore dialogues. Fixes #3861 -- [...truncated 1012.70 KB...] HeadlessChrome 0.0.0 (Linux 0.0.0): Execut

Re: [pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help

2019-01-09 Thread Dave Page
Thanks, applied. On Wed, Jan 9, 2019 at 6:31 PM Aditya Toshniwal wrote: > > Hi Hackers, > > Attached is a tiny patch to fix the Postgres help for backup and restore > dialog. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Com

pgAdmin 4 commit: Fix help for the backup/restore dialogues. Fixes #386

2019-01-09 Thread Dave Page
Fix help for the backup/restore dialogues. Fixes #3861 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=868622912ed22673f59b791af30ce8e6f577c837 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes.rst

[pgAdmin4][Patch] - RM 3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11

2019-01-09 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11. Order of commands has been changed in PostgreSQL 11 "https://github.com/postgres/postgres /commit/921059bd66c7fb1230c705d3b1a65940800c4cbb" Please review it. -- *Akshay Joshi* *S

[pgAdmin4][patch] Fixes Backup Restore Dialog Postgres help

2019-01-09 Thread Aditya Toshniwal
Hi Hackers, Attached is a tiny patch to fix the Postgres help for backup and restore dialog. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" backup_restore_help.patch Description: Binary data

[pgAdmin4][RM3575] Right click does not work on database node if server name changed

2019-01-09 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix the issue where changing the name (or any visible property on tree) of the server node breaks the context menu on the database nodes. The user information of the server is updated on successful connection. Here, the data is updated on the aciTreeNode(domNo

[pgAdmin4][Patch] - RM 3842 pg_catalogs schema should not displayed in properties tab

2019-01-09 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3842 pg_catalogs schema should not displayed in properties tab. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3842.patch Description: Binary data