Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."

Hi Dave/Hackers On Fri, Mar 29, 2019 at 7:50 PM Akshay Joshi wrote: > > > On Fri, Mar 29, 2019 at 7:41 PM Dave Page wrote: > >> Hi >> >> On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> I have started working on RM #4110 "Updatin

pgAdmin 4 commit: Remove unnecessary print statement in the regression

Remove unnecessary print statement in the regression tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2aabf6270a22cd7e3005f315cd9315c61ba7efa Author: Usman Muzaffar Modified Files -- web/pgadmin/feature_tests/query_tool_jou

Re: Feature Tests query tool: unnecessary print statement removal

Thanks - applied. On Fri, Mar 29, 2019 at 2:11 PM Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for feature tests. It contains following > fix > >- removal of unnecessary print statement from Query_tool_test > > > > -- > > > Thanks,

Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not present when seeing generated SQL from a table

Thanks - applied. On Fri, Mar 29, 2019 at 7:42 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I missed few SQLs for partition tables, gpdb, ppas and other pg versions :( > Attached is the patch to include those. > > Kindly review. > > On Thu, Mar 28, 2019 at 9:5

pgAdmin 4 commit: Add some SQL updates to handle inherited column marke

Add some SQL updates to handle inherited column markers/comments that were missed in the previous commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55c6f5205d9891ab9972bc1238c2f26a9d19869d Author: Aditya Toshniwal Modified Files --

pgAdmin 4 commit: Remove a debug statement.

Remove a debug statement. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5965bc9107d261eecc217d584f0a51b708f0cd21 Author: Khushboo Vashi Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 1 - 1 file changed, 1 deletion

Re: [pgAdmin4][Patch] - Minor patch to remove javascript debugger

Thanks, applied. On Fri, Mar 29, 2019 at 6:43 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to remove the javascript debugger from the > code. > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake Enter

pgAdmin 4 commit: Missed a bug :-(

Missed a bug :-( Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be313bb17b321bfc684205c6131493fe4f75e604 Modified Files -- docs/en_US/release_notes_4_4.rst | 1 + 1 file changed, 1 insertion(+)

Re: [pgAdmin4][Patch] - RM 4082 - Download CSV error displayed for procedure and functions with create script

Sorry Khushboo - I went with Aditya's patch. On Thu, Mar 28, 2019 at 1:18 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #4082 - Download CSV error > displayed for procedure and functions with create script. > > The error message

Re: [pgAdmin4][RM4085] CSV download should show error messages in messages tab and not in the CSV file

Thanks, patch applied. On Fri, Mar 29, 2019 at 4:50 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to handle Postgres or other errors gracefully when > clicked on download CSV. PostgresSQL errors will be shown in messages tab > similar to n

pgAdmin 4 commit: Display errors during CSV download from the Query Too

Display errors during CSV download from the Query Tool in the UI rather than putting them in the CSV file. Fixes #4085 Ensure the toolbar buttons are properly reset following a CSV download in the Query Tool. Fixes #4096 Branch -- master Details --- https://git.postgresql.org/gitweb?p=p

Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."

On Fri, Mar 29, 2019 at 7:41 PM Dave Page wrote: > Hi > > On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I have started working on RM #4110 "Updating 'Custom auto-vacuum?' >> property throws error for Materialized View." and while wor

Re: [pgAdmin4][Patch]: RM #4110 "Updating 'Custom auto-vacuum?' property throws error for Materialized View."

Hi On Thu, Mar 28, 2019 at 1:15 PM Akshay Joshi wrote: > Hi Hackers, > > I have started working on RM #4110 "Updating 'Custom auto-vacuum?' > property throws error for Materialized View." and while working I have > figured out following issues: > >- Reset some/all the parameter for table and

Feature Tests query tool: unnecessary print statement removal

Hi Hackers, Please find here attached patch for feature tests. It contains following fix - removal of unnecessary print statement from Query_tool_test -- Thanks, Usman Muzaffar QA Team EnterpriseDB Corporation query_tool_test_v1.patch Description: Binary data

Re: [pgAdmin4][RM4037] COMMENTS from inherited fields are not present when seeing generated SQL from a table

Hi Hackers, I missed few SQLs for partition tables, gpdb, ppas and other pg versions :( Attached is the patch to include those. Kindly review. On Thu, Mar 28, 2019 at 9:54 PM Dave Page wrote: > Thanks, applied. > > On Thu, Mar 28, 2019 at 2:00 AM Aditya Toshniwal < > aditya.toshni...@enterpris