Re: [pgAdmin][RM4171] Can not display sql of foreign table when used character = in options

2019-06-09 Thread Akshay Joshi
Thanks patch applied. On Mon, Jun 10, 2019 at 11:13 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to fix an issue where reverse engineered SQL was > failing for foreign tables, if it had "=" in the options. > Kindly review. > > -- > Tha

pgAdmin 4 commit: Fix issue where reverse engineered SQL was failing fo

2019-06-09 Thread Akshay Joshi
Fix issue where reverse engineered SQL was failing for foreign tables, if it had = in the options. Fixes #4171 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7ff85903e4fe95f4dd918152e2577d80b0c577e8 Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin][RM4253] create new column with default value

2019-06-09 Thread Akshay Joshi
Thanks patch applied. On Mon, Jun 10, 2019 at 11:36 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a patch to fix default value issue while creating column. This > issue occurs only when a false value like 0 or False is used as default > value. > > -

pgAdmin 4 commit: Fix issue where new column should be created with Def

2019-06-09 Thread Akshay Joshi
Fix issue where new column should be created with Default value. Fixes #4235 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b9c50ee5c60fbb9eda0b7004194b5e477b4ea12 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_no

[pgAdmin][RM4253] create new column with default value

2019-06-09 Thread Aditya Toshniwal
Hi Hackers, Attached is a patch to fix default value issue while creating column. This issue occurs only when a false value like 0 or False is used as default value. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"

[pgAdmin][RM4171] Can not display sql of foreign table when used character = in options

2019-06-09 Thread Aditya Toshniwal
Hi Hackers, Attached is a tiny patch to fix an issue where reverse engineered SQL was failing for foreign tables, if it had "=" in the options. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4171.