Re: Is requirements.txt up2date?

2019-06-10 Thread Devrim Gündüz
Hi, On Wed, 2019-06-05 at 13:02 +0100, Dave Page wrote: > Yes. They're indirect dependencies, so don't appear in the list we > maintain. Not sure about Blinker, but Werkzeug will be defined in the > requirements.txt file for Flask. Ack, thanks! Cheers, -- Devrim Gündüz Open Source Solution Ar

[GSoC] Check if a query resultset is update-able

2019-06-10 Thread Yosry Muhammad
Dear all, After some research and review of the code, I have arrived at this method to check whether a query resultset is update-able. I would like to know your feedback before I start implementing this technique: - Query results are not be update-able (initially at least) except if all the prima

Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs

2019-06-10 Thread Dave Page
Thanks, patch applied. On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch with fixes. > > On Mon, Jun 10, 2019 at 12:58 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> Followin

pgAdmin 4 commit: Fix an initialisation error when two functions with p

2019-06-10 Thread Dave Page
Fix an initialisation error when two functions with parameters are debugged in parallel. Fixes #4329 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5437a8adabaf199b63759923975145ba4d2e3676 Author: Aditya Toshniwal Modified Files ---

Re: [pgAdmin4][Patch]: Feature #4283 pgAdmin4 support for v12

2019-06-10 Thread Dave Page
Thanks, applied. On Fri, Jun 7, 2019 at 11:39 AM Akshay Joshi wrote: > Hi Hackers, > > Today I have read the https://www.postgresql.org/docs/release/12.0/ release > note. I have created some new feature request and fixed one issue. > Following are the issues that I have fixed: > >- Fixed exi

pgAdmin 4 commit: Initial support for PostgreSQL 12. Fixes #4283. Fixes

2019-06-10 Thread Dave Page
Initial support for PostgreSQL 12. Fixes #4283. Fixes #4288. Fixes #4290. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d52f2b91162daea055b40be019e5d4564c29c38 Modified Files -- docs/en_US/release_notes_4_9.rst

Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button

2019-06-10 Thread Dave Page
Thanks, applied! On Mon, Jun 10, 2019 at 10:35 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Mon, Jun 10, 2019 at 2:34 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 5, 2019 at 1:39 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>

pgAdmin 4 commit: Ensure that the Return key can be used to submit the

2019-06-10 Thread Dave Page
Ensure that the Return key can be used to submit the Master Password dialogue. Fixes #4310 Ensure that browser auto-fill doesn't cause Help pages to be opened unexpectedly. Fixes #4317 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ca11c84e

Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs

2019-06-10 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch with fixes. On Mon, Jun 10, 2019 at 12:58 PM Akshay Joshi wrote: > Hi Aditya > > Following are the review comments: > >- "Set breakpoint" option not working, when click it throws an error. > > Fixed. > >- Create an empty function and try to deb

pgAdmin 4 commit: Fix keyboard navigation in "inner" tabsets such as th

2019-06-10 Thread Dave Page
Fix keyboard navigation in "inner" tabsets such as the Query Tool and Debugger. Fixes #4195 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f561c0cee6a6d9d3f8212657b7da701faf1f35d3 Author: Aditya Toshniwal Modified Files -- docs/

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-06-10 Thread Dave Page
Thanks, applied! On Wed, Jun 5, 2019 at 1:18 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated, rebased patch. I was using the wrong key code for > "[" and "]" while registering, but strangely it was working for me. I have > corrected that.

Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button

2019-06-10 Thread Aditya Toshniwal
Hi, On Mon, Jun 10, 2019 at 2:34 PM Dave Page wrote: > Hi > > On Wed, Jun 5, 2019 at 1:39 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, Jun 5, 2019 at 4:48 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal < >>> adit

Re: french translation for 4.8 release

2019-06-10 Thread Dave Page
Thanks - update committed! On Thu, Jun 6, 2019 at 12:36 PM wrote: > hi > ... too late :-) > but done > Fred > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Update French translation.

2019-06-10 Thread Dave Page
Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=321b445a7e61031e7bed86dbad569c586ac453b8 Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 159456 -> 15959

Re: [pgAdmin][RM4310] User can not connect to the Master Password with Enter button

2019-06-10 Thread Dave Page
Hi On Wed, Jun 5, 2019 at 1:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 5, 2019 at 4:48 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 5, 2019 at 8:14 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attache

Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs

2019-06-10 Thread Akshay Joshi
Hi Aditya Following are the review comments: - "Set breakpoint" option not working, when click it throws an error. - Create an empty function and try to debug that. It should show proper error message. - Got the following backend error when closing the connection, please fix this: