[pgAdmin][RM3782] Debugger title should show connection and object details

Hi Hackers, Attached is the patch to add more information on connection details to debugger panel title and content title similar to Query Tool and View/Edit data. Adding the object name with arguments is not a good idea for the panel title, so I have kept to connection details similar to query to

Re: [GSoC] Check if a query resultset is update-able

Hi On Tue, Jun 11, 2019 at 3:06 PM Yosry Muhammad wrote: > Hi, > > On Tue, Jun 11, 2019 at 10:21 AM Dave Page wrote: > >> Hi >> >> On Mon, Jun 10, 2019 at 10:51 PM Yosry Muhammad >> wrote: >> >>> Dear all, >>> >>> After some research and review of the code, I have arrived at this >>> method to

Re: [pgAdmin][RM4228] Incorrect table listed in panel header

Thanks, applied. On Tue, Jun 11, 2019 at 11:22 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > It is failing irrespective of patch applied or not. :) > However, I have fixed it. Attached is the updated patch. > I have also flag for chromedriver 75. > > Just to add, I hav

pgAdmin 4 commit: Ensure the correct label is used in panel headers whe

Ensure the correct label is used in panel headers when viewing filtered rows. Fixes #4228 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=23364464c2b4990da52b9016176e64ccc99b82f8 Author: Aditya Toshniwal Modified Files -- docs/en

Re: [GSoC] Check if a query resultset is update-able

Hi, On Tue, Jun 11, 2019 at 10:21 AM Dave Page wrote: > Hi > > On Mon, Jun 10, 2019 at 10:51 PM Yosry Muhammad > wrote: > >> Dear all, >> >> After some research and review of the code, I have arrived at this method >> to check whether a query resultset is update-able. I would like to know >> yo

pgAdmin 4 commit: Fix issue where property dialog of column should open

Fix issue where property dialog of column should open properly for EPAS v12. Fixes #4343 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d774a0ff6766f410fa8c1aaad460700d53cf03e7 Modified Files -- docs/en_US/release_notes_4_9.rst

Re: [pgAdmin][RM4228] Incorrect table listed in panel header

Hi, It is failing irrespective of patch applied or not. :) However, I have fixed it. Attached is the updated patch. I have also flag for chromedriver 75. Just to add, I have also changed "Filtered Rows" dialog title to add table details also. Kindly review. On Tue, Jun 11, 2019 at 2:50 PM Dave

Re: [pgAdmin][RM4228] Incorrect table listed in panel header

Hi This doesn't pass the feature tests: == ERROR: runTest (pgadmin.feature_tests.browser_tool_bar_test.BrowserToolBarFeatureTest) Browser tool bar feature test -

Re: [GSoC] Check if a query resultset is update-able

Hi On Mon, Jun 10, 2019 at 10:51 PM Yosry Muhammad wrote: > Dear all, > > After some research and review of the code, I have arrived at this method > to check whether a query resultset is update-able. I would like to know > your feedback before I start implementing this technique: > > - Query re

[pgAdmin][RM4228] Incorrect table listed in panel header

Hi Hackers, Attached is the patch to fix incorrect label on panels when using filtered rows. I've also moved redundant code for filter data in datagrid.js to show_data.js, reusing the existing code of view/edit data. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | Ent