Re: Bug in Database Nodes in the Tree

Hi, On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Yosry, > > On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad > wrote: > >> Hi Khushboo, >> >> There's a minor bug that I noticed a while back that when you right click >> a disconnected database (to dro

Re: Bug in Database Nodes in the Tree

Hi Yosry, On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad wrote: > Hi Khushboo, > > There's a minor bug that I noticed a while back that when you right click > a disconnected database (to drop it for example) it automatically connects > to the database and expands the node. This behaviour is a l

Bug in Database Nodes in the Tree

Hi Khushboo, There's a minor bug that I noticed a while back that when you right click a disconnected database (to drop it for example) it automatically connects to the database and expands the node. This behaviour is a little annoying to users (me too), I am trying to fix it. I looked around the

pgAdmin 4 commit: Randomise table names for tests.

Randomise table names for tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5b927b9254beafd1e99027a1d22fe532615af57 Author: Yosry Muhammad Modified Files -- .../tests/test_is_query_resultset_updatable.py | 28 +++

pgAdmin 4 commit: Ensure Selenium is started only when it's needed.

Ensure Selenium is started only when it's needed. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d78dfbd30f0dbead00873f85ec3ae424a62637c7 Author: Akshay Joshi Modified Files -- web/regression/runtests.py | 14 +++--- 1 fil

Re: Subtle test problem

Working on it right now. On Wed, Jul 17, 2019, 2:35 PM Dave Page wrote: > Hi Yosry, > > Now that your patch is committed we're seeing a subtle failure on our > internal (at EDB) CI/CD system. Essentially we have multiple tests running > concurrently, and it looks like you're using a fixed table

Subtle test problem

Hi Yosry, Now that your patch is committed we're seeing a subtle failure on our internal (at EDB) CI/CD system. Essentially we have multiple tests running concurrently, and it looks like you're using a fixed table name. In other tests we make sure we have a random number on the end of the table na

Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node

Thanks, patch applied. On Tue, Jul 16, 2019 at 12:01 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Jul 16, 2019 at 2:05 PM Dave Page wrote: > >> Hi >> >> On Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Constraints. Fix

Add Reverse Engineered SQL tests for Constraints. Fixes #4475 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8168f623c436ae586cb63f36859cca902690b032 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_11.rst

Re: [GSoC] Finalized First Patch

Patch committed (with some trivial editorial work on the docs). Congratulations - that's impressive work! On Tue, Jul 16, 2019 at 6:03 AM Yosry Muhammad wrote: > Hi all, > > Please find attached an updated patch with the following modifications: > > - Fixed the bug noticed by Khushboo, it was c

pgAdmin 4 commit: Add support for editing of resultsets in the Query To

Add support for editing of resultsets in the Query Tool, if the data can be identified as updatable. Fixes #1760 When a query is run in the Query Tool, check if the source of the columns can be identified as being from a single table, and that we have all columns that make up the primary key. If