Re: Working on issues #4530, #4529, #4520, #4524

2019-07-29 Thread Yosry Muhammad
In addition, #4476 was already resolved in later versions. I commented on that too, please check. On Tue, Jul 30, 2019, 1:38 AM Yosry Muhammad wrote: > > > On Tue, Jul 30, 2019, 1:22 AM Akshay Joshi > wrote: > >> Hi Yosry >> >> On Tue, Jul 30, 2019 at 4:55 AM Yosry Muhammad >> wrote: >> >>>

Re: Query Auto Completion

2019-07-29 Thread Avin Kavish
Oh okay, it seems that the connection to the database needs to be alive in order for auto-completion to appear. I have been trying the hotkeys while the connection was down. To be honest, it's more of a search when one forgets something, rather than a "let me help you type faster". I was thinking m

Working on issues #4530, #4529, #4520, #4524

2019-07-29 Thread Yosry Muhammad
Hi Dave, I am working on issues #4529 and #4520 (related to the missing command tag in query tool messages panel) as you asked me. I am also working on issues #4530 and #4524 as they are related to a previous patch I sent. Could you please assign them to me so that other developers know someone i

pgAdmin 4 commit: Add a warning to notify packagers of dependency updat

2019-07-29 Thread Dave Page
Add a warning to notify packagers of dependency updates. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3cb02bcdc323618f0256947061ada8737acd51eb Modified Files -- requirements.txt| 11 +++ web/package.json

Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-29 Thread Yosry Muhammad
On Mon, Jul 29, 2019, 4:26 AM Dave Page wrote: > Hi Yosry and Akshay > > On Fri, Jul 26, 2019 at 1:02 PM Dave Page wrote: > >> Akshay; can you take a look at this and commit if appropriate please? I'm >> somewhat busy at the moment :-( >> >> On the subject of the regression test - I assume at on

Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-29 Thread Dave Page
Hi Yosry and Akshay On Fri, Jul 26, 2019 at 1:02 PM Dave Page wrote: > Akshay; can you take a look at this and commit if appropriate please? I'm > somewhat busy at the moment :-( > > On the subject of the regression test - I assume at one point the messages > window was including the command tag

Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-29 Thread Akshay Joshi
Thanks patch applied. On Mon, Jul 29, 2019 at 11:12 AM Akshay Joshi wrote: > > On Fri, Jul 26, 2019 at 5:33 PM Dave Page wrote: > >> Akshay; can you take a look at this and commit if appropriate please? I'm >> somewhat busy at the moment :-( >> > >Sure, I am looking it. > >> >> On the subje

pgAdmin 4 commit: Added support for editing of result sets from tables

2019-07-29 Thread Akshay Joshi
Added support for editing of result sets from tables with OIDs in query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82d209946f6967a45238364659fe2d20313fcaae Author: Yosry Muhammad Modified Files -- docs/en_US/query_tool.