Re: pgAdmin 4 commit: Swap the Schema and Schemas icons and Catalog and Cat

2019-07-31 Thread Akshay Joshi
Hi Hackers I am extremely sorry for the wrong commit message. Correct commit message is "*Swap the Trigger and Triggers icons that had been used the wrong way around.*" I have tried to amend that message using git commit --amend command but not able to push that for some reason. On Thu, Aug 1, 20

pgAdmin 4 commit: Swap the Schema and Schemas icons and Catalog and Cat

2019-07-31 Thread Akshay Joshi
Swap the Schema and Schemas icons and Catalog and Catalogs icons that had been used the wrong way around. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ff007d1cbde81498101951e122e70138060927b Modified Files -- .../databases/sch

Re: [pgAdmin][RM4229] Missing "Copy" (and other edit menu items) from data panels

2019-07-31 Thread Aditya Toshniwal
Hi Hackers, Kindly ignore the previous patch. Attached it the updated patch to move wcDocker to latest version. This will also solve #4489 - Empty modal window. On Thu, Aug 1, 2019 at 10:56 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > The pull request https:/

Re: [pgAdmin][RM4489] Empty modal window

2019-07-31 Thread Aditya Toshniwal
Kindly ignore this patch. The version in this outdated and is updated to latest in RM4229. On Thu, Aug 1, 2019 at 10:36 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > With the pull request https://github.com/EnterpriseDB/wcDocker/pull/11 merged, > updating the v

[pgAdmin][RM4229] Missing "Copy" (and other edit menu items) from data panels

2019-07-31 Thread Aditya Toshniwal
Hi Hackers, The pull request https://github.com/EnterpriseDB/wcDocker/pull/12 is merged. This will limit the wcDocker context menu to frame/panel titles. This pull request also changes the tab scroller icon from arrows to chevron and fixing the position of the icons which are not centred currently

[pgAdmin][RM4489] Empty modal window

2019-07-31 Thread Aditya Toshniwal
Hi Hackers, With the pull request https://github.com/EnterpriseDB/wcDocker/pull/11 merged, updating the version for wcDocker will solve this issue. Attached is the patch to update the version. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain a

Re: Query Tool Fix

2019-07-31 Thread Yosry Muhammad
Please find separate patch files attached. I believe there isn't any dependency between the patches. #4525 and #4529 are duplicates - both are fixed by the patch. On Wed, Jul 31, 2019 at 3:49 PM Dave Page wrote: > Hi > > On Wed, Jul 31, 2019 at 6:05 AM Aditya Toshniwal < > aditya.toshni...@ente

Re: Query Tool Fix

2019-07-31 Thread Dave Page
Hi On Wed, Jul 31, 2019 at 6:05 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > The changes to fix 4520 are in python side. I would suggest if you can > separate it out from this patch, so that we can ask the users(affected by > 4520) to just replace the python fil

[RM#4546] Add RE-SQL tests for Column node

2019-07-31 Thread Murtuza Zabuawala
Hi, PFA patch to add RE-SQL tests for Column node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company column_resql_tests.diff Description: Binary data