[pgAdmin4][Patch] - RM 4581 - Can not edit comments of primary key constraint under table node

Hi, Please find the attached patch to fix the RM #4581 - Can not edit comments of primary key constraint under table node. Thanks, Khushboo RM_4581.patch Description: Binary data

pgAdmin 4 commit: Fix generation of reverse engineered SQL for partitio

Fix generation of reverse engineered SQL for partition table, partitions were shown as a child of indexes. Fixes #4414 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f53e13aa728298a2adb31ab28624b04b4332166 Modified Files -- docs

pgAdmin 4 commit: Browser window was not closing - Fixed.

Browser window was not closing - Fixed. App should quit on all windows closed. Added linter config from pgadmin and fixed linter issues. Other cleanup. Branch -- electron2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=551bf9459faf679977f5673dcc901cdd5ecee1de

Re: [pgAdmin][RM4144] Compound Trigger support for EPAS-v12

I'll do. On Wed, Aug 7, 2019 at 3:34 PM Dave Page wrote: > Thanks Akshay. I want to do a pass over the docs before this is committed. > Otherwise, I don't see any obvious issues - however, it's a pretty big > patch, so can you have one of the others on the team do a review/test as > well please?

pgAdmin 4 commit: Stupid tabs

Stupid tabs Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1530015eecb89dd09d56b2e69cca1c0fa1a93cc Modified Files -- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Improve consistency of the regression README. Fixes #

Improve consistency of the regression README. Fixes #4579 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=228d3dde5b279e194c7e932ee7f891e849a2634a Author: Fahar Abbas Modified Files -- web/regression/README | 13 +++-- 1 fi

[RM4579]Regression/README file modifications

Hi Hackers, Please find attached the patch for README file in regression folder. I have done the following: - Added new subject line. - Added Example in reverse engineering. - Placed it at appropriate place. Please review and apply the patch. Kind Regards. -- Fahar Abbas QMG Enterpri

pgAdmin 4 commit: Display the row count in the popup message when count

Display the row count in the popup message when counting table rows, not just in the properties list. Fixes #4574 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a5464b278721b089d9e4758564813ab22d5c70a Modified Files -- docs/en_U

pgAdmin 4 commit: Make sure the package-lock.json file is removed.

Make sure the package-lock.json file is removed. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9d5e08e8f998e797b0ff2ece0ce28fa57e8a003 Modified Files -- Makefile | 1 + 1 file changed, 1 insertion(+)

Re: [pgAdmin][RM4144] Compound Trigger support for EPAS-v12

Thanks Akshay. I want to do a pass over the docs before this is committed. Otherwise, I don't see any obvious issues - however, it's a pretty big patch, so can you have one of the others on the team do a review/test as well please? On Wed, Aug 7, 2019 at 8:08 AM Akshay Joshi wrote: > Hi Hackers

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Will work on that too. On Wed, Aug 7, 2019, 11:06 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > Users have also raised issue where they are not able to double click the > cell and see the content. Now, if the result set is not updatable, double > click does nothi

Re: [pgAdmin][RM4554] RE-SQL for trigger functions

Thanks, applied. On Wed, Aug 7, 2019 at 6:19 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > I've improved the output messages to add more detail for trigger functions > RE-SQL test cases. Attached is the patch. > > On Tue, Aug 6, 2019 at 6:58 PM Dave Page wrote

pgAdmin 4 commit: Improve test messages

Improve test messages Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4067d65a30066f20e33f430f1413a067c77ee22c Author: Aditya Toshniwal Modified Files -- .../schemas/functions/tests/pg/default/test_trigger_functions.json | 6 +++-

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi Yosry, Users have also raised issue where they are not able to double click the cell and see the content. Now, if the result set is not updatable, double click does nothing. If the data is JSON, there is no way to see the content. It should show the editor without the Save button if the result

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi, On Wed, Aug 7, 2019, 10:31 AM Dave Page wrote: > Hi > > On Tue, Aug 6, 2019 at 5:46 PM Yosry Muhammad wrote: > >> Hi, >> >> On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: >> >>> Hi >>> >>> Seems to work well :-). A few comments: >>> >>> - Should we have an icon by the non-generated queries

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi On Tue, Aug 6, 2019 at 5:46 PM Yosry Muhammad wrote: > Hi, > > On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > >> Hi >> >> Seems to work well :-). A few comments: >> >> - Should we have an icon by the non-generated queries (the lightning >> flash) and the COMMITs etc (the commit/rollback ico

Re: New versions "What's new"

I'm not against the idea if someone wants to come up with a patch. Maybe just a message flash that appears the first time a new version is run, with a message saying "Welcome to pgAdmin 4 vX.Y. Click to see what has changed in this version.", with linking to the release notes in the docs? On Wed