Re: [pgAdmin][RM4461] FORCE_NOT_NULL syntax error

2019-09-02 Thread Akshay Joshi
Thanks patch applied. On Mon, Sep 2, 2019 at 6:04 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix a small error while importing data to a table > using Import/Export dialog and providing "Not null columns" option. > Kindly review. > -

pgAdmin 4 commit: Fix error while importing data to a table using Impor

2019-09-02 Thread Akshay Joshi
Fix error while importing data to a table using Import/Export dialog and providing Not null columns option. Fixes #4461. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=04357b7a55f758109e6bf7306950dbe9f659ea34 Author: Aditya Toshniwal Modifi

Re: [RM#4690] MSQL tests for Resource group node

2019-09-02 Thread Akshay Joshi
Thanks patch applied. On Mon, Sep 2, 2019 at 6:22 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add MSQL tests for Resource group node. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Compan

Re: RE-SQL tests patch for FTS parsers node

2019-09-02 Thread Akshay Joshi
Thanks patch applied. On Mon, Sep 2, 2019 at 6:35 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > PFA patch for M-SQL test cases for FTS parsers. > > Thanks & Regards, > Shubham Agarwal > > On Mon, Jul 15, 2019 at 4:33 PM Dave Page wrote: > >> Thanks, applied. >> >> O

pgAdmin 4 commit: Add MSQL test cases for FTS Parser.

2019-09-02 Thread Akshay Joshi
Add MSQL test cases for FTS Parser. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0f6e5272aa17739d4d492a0f44eabd037fe1b2d Author: Shubham Agarwal Modified Files -- .../fts_parsers/tests/default/alter_fts_parser_msql.sql |

Re: [pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undo an edit

2019-09-02 Thread Aditya Toshniwal
On Mon, Sep 2, 2019 at 6:28 PM Dave Page wrote: > Hi > > On Mon, Sep 2, 2019 at 11:05 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to: >> 1) Optimise code folding code for better performance. >> 2) Moved all editor related preferen

pgAdmin 4 commit: Add Modified SQL tests for Resource Group. Fixes #469

2019-09-02 Thread Akshay Joshi
Add Modified SQL tests for Resource Group. Fixes #4690 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eeeb350ed224b51300de58392fc7ca22ceb1d01c Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_13.rst

Re: [pgAdmin][RM4584] HTML entities aren't escaped in database names

2019-09-02 Thread Dave Page
Thanks, applied. On Mon, Sep 2, 2019 at 12:16 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will fix issue where HTML entities aren't escaped in > database names. > This was fixed previously, but seems to be broken again now :/ > > Kindly review.

pgAdmin 4 commit: Re-fix database name unescaping the query tool title

2019-09-02 Thread Dave Page
Re-fix database name unescaping the query tool title bar. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a68f0702e219306d66557863a43885b45b5aa42c Author: Aditya Toshniwal Modified Files -- web/pgadmin/tools/datagrid/static/js/dat

Re: [pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undo an edit

2019-09-02 Thread Dave Page
Hi On Mon, Sep 2, 2019 at 11:05 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to: > 1) Optimise code folding code for better performance. > 2) Moved all editor related preferences like Font size, Tab size, Brace > matching, etc. from optio

Re: RE-SQL tests patch for FTS parsers node

2019-09-02 Thread Shubham Agarwal
Hi Team, PFA patch for M-SQL test cases for FTS parsers. Thanks & Regards, Shubham Agarwal On Mon, Jul 15, 2019 at 4:33 PM Dave Page wrote: > Thanks, applied. > > On Mon, Jul 15, 2019 at 11:42 AM Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> >> PFA patch for RE-

[RM#4690] MSQL tests for Resource group node

2019-09-02 Thread Murtuza Zabuawala
Hi, PFA patch to add MSQL tests for Resource group node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company msql_resource_group_node.diff Description: Binary data

Re: Italian translation

2019-09-02 Thread Dave Page
Thank you - translation committed! On Sun, Sep 1, 2019 at 11:50 AM Domenico Sgarbossa wrote: > Hi, here the files ;-) > > Il domenica 25 agosto 2019, 16:24:38 CEST, Fred > ha scritto: > > > Hello > Attach your .po and .mo files in a main sent to the mailing list. They > will be merged by a memb

pgAdmin 4 commit: Add an Italian translation.

2019-09-02 Thread Dave Page
Add an Italian translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=60a6c501fb7373f3dc6fc7ffecca824fb5906fd8 Author: Domenico Sgarbossa Modified Files -- docs/en_US/release_notes_4_13.rst | 1 + web/con

[pgAdmin][RM4461] FORCE_NOT_NULL syntax error

2019-09-02 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix a small error while importing data to a table using Import/Export dialog and providing "Not null columns" option. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"

Re: RE-SQL tests patch for packages node

2019-09-02 Thread Akshay Joshi
Hi Navnath Following are the review comments: - GRANT statement is not visible in RE-SQL for create and alter both. (May be bug in Packages please fix that too) - Delete packages is missing in json file. - Add test cases to revoke privileges(delete all the privileges). Check Langua

Re: RE-SQL tests patch for packages node

2019-09-02 Thread navnath gadakh
Hi Dave, Please find the patch for M-SQL test cases for *Packages* module. Thanks! On Fri, Jul 12, 2019 at 4:02 PM Dave Page wrote: > Thanks, applied. > > On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find th

[pgAdmin][RM4584] HTML entities aren't escaped in database names

2019-09-02 Thread Aditya Toshniwal
Hi Hackers, Attached patch will fix issue where HTML entities aren't escaped in database names. This was fixed previously, but seems to be broken again now :/ Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a

[pgAdmin][RM4631] PgAdmin IV browser locks up when trying to undo an edit

2019-09-02 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to: 1) Optimise code folding code for better performance. 2) Moved all editor related preferences like Font size, Tab size, Brace matching, etc. from options to a new category "Editor" . 3) Added two new preferences - Plain editor mode (text/plain), Disable code f

pgAdmin 4 commit: Add Reverse Engineered and Modified SQL tests for FTS

2019-09-02 Thread Akshay Joshi
Add Reverse Engineered and Modified SQL tests for FTS Templates. Fixes #4619 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ff3f40116bb2cc8b838541f20d6db44a851e1a9 Modified Files -- docs/en_US/release_notes_4_13.rst

pgAdmin 4 commit: Added MSQL test cases for Cast and Language.

2019-09-02 Thread Akshay Joshi
Added MSQL test cases for Cast and Language. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=662266a367bc4fb14b08983e9ae1ba8a2897306e Modified Files -- .../tests/default/alter_explicit_cast_msql.sql | 2 + .../tests/default/alt

Re: RM 4463 - MSQL test cases for domain node

2019-09-02 Thread Akshay Joshi
Thanks patch applied. On Mon, Sep 2, 2019 at 11:43 AM Neel Patel wrote: > Hi, > > Please find attached updated patch. I have tested with PG 9.4, PG 10 & > EPAS 10. > Do review it and let me know in case of any failures. > > Thanks, > Neel Patel > > On Fri, Aug 23, 2019 at 1:52 PM Dave Page wrot