Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-12 Thread Aditya Toshniwal
Looks good to me. On Fri, Sep 13, 2019 at 8:05 AM Akshay Joshi wrote: > Can someone please review this. > > On Mon, 9 Sep, 2019, 18:06 Akshay Joshi, > wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the RM #4642 "port should not be mandatory >> when a service is provided". *Cyril Jou

pgAdmin 4 commit: Ensure port and username should not be mandatory when

2019-09-12 Thread Akshay Joshi
Ensure port and username should not be mandatory when a service is provided. Fixes #4642 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da553eec9b2324dde5259457bd654683e2133190 Modified Files -- docs/en_US/release_notes_4_13.rst

pgAdmin 4 commit: Fix webpack issue where multiple assets emit to the s

2019-09-12 Thread Akshay Joshi
Fix webpack issue where multiple assets emit to the same file. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9a69d27009967a10fc89419d8ce664f7c5339e56 Author: Aditya Toshniwal Modified Files -- web/pgadmin/misc/file_manager/stati

Re: [pgAdmin][RM4642] port should not be mandatory when a service is provided

2019-09-12 Thread Akshay Joshi
Can someone please review this. On Mon, 9 Sep, 2019, 18:06 Akshay Joshi, wrote: > Hi Hackers, > > Attached is the patch to fix the RM #4642 "port should not be mandatory > when a service is provided". *Cyril Jouve* has sent the initial patch, > but that only removes the validation on GUI, when w

Re: [pgAdmin][RM4408] Show validation errors for slickgrid cells

2019-09-12 Thread Dave Page
Thanks, patch applied. On Tue, Sep 10, 2019 at 7:52 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to show the validation error message in case a > user enters syntactically incorrect data in cell editors. > Note that, the validation is

pgAdmin 4 commit: Fix display of validation error message in SlickGrid

2019-09-12 Thread Dave Page
Fix display of validation error message in SlickGrid cells. Fixes #4408 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=83170a0e94935544d6dd8d9617f306e791d702b6 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4

Re: Italian translation

2019-09-12 Thread Akshay Joshi
Thanks, Domenico I have committed the file. On Thu, Sep 12, 2019 at 5:07 PM Domenico Sgarbossa wrote: > Thank you Akshay! > It seems all ok! > > Sorry... it was my mistake :-( > Typically PoEdit reports these errors but it seems that this time > something went wrong I'll I pay more attentio

pgAdmin 4 commit: Fix query tool and view data issue with the Italian l

2019-09-12 Thread Akshay Joshi
Fix query tool and view data issue with the Italian language. Fixes #4736 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d8c53bffd8ffccd7377bf6cc39ee07992fcc255 Modified Files -- docs/en_US/release_notes_4_13.rst

Re: Italian translation

2019-09-12 Thread Domenico Sgarbossa
Thank you Akshay!It seems all ok! Sorry... it was my mistake :-(Typically PoEdit reports these errors but it seems that this time something went wrong I'll I pay more attention in the future, I'll promise. Il giovedì 12 settembre 2019, 13:19:05 CEST, Akshay Joshi ha scritto: Hi D

Re: Italian translation

2019-09-12 Thread Akshay Joshi
Hi Domenico/Dave There is some problem with the translation file. RM #4736 has been created. I have analyzed the issue and found the problem in the translation of the string "*%s.*" is translated to "*% s.*". Space between % and s is the problem. For ex

pgAdmin 4 commit: Ensure sequence with negative value should be created

2019-09-12 Thread Akshay Joshi
Ensure sequence with negative value should be created. Fixes #4726 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7944e75695960c5696bc83e06c80a8c01eae8727 Modified Files -- docs/en_US/release_notes_4_13.rst | 3 +