Re: Fixes for pgAdmin feature tests

2019-11-15 Thread Akshay Joshi
Thanks, patch applied On Fri, Nov 15, 2019 at 5:59 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > > PFA feature test fixture patch containing the following fixes: > 1. Process watcher loading logs fix > 2. Auto commit/rollback issue in query_tool_tests > 3. Fixed the s

pgAdmin 4 commit: Fixed following feature tests:

2019-11-15 Thread Akshay Joshi
Fixed following feature tests: 1. Process watcher loading logs fix 2. Auto commit/rollback issue in query_tool_tests 3. Fixed the scrolling issue while verifying values in a table. 4. Modified some functions in pgadmin_page.py Branch -- master Details --- https://git.postgresql.org/gitweb

Re: Fixes for pgAdmin feature tests

2019-11-15 Thread Shubham Agarwal
Hi Team, PFA feature test fixture patch containing the following fixes: 1. Process watcher loading logs fix 2. Auto commit/rollback issue in query_tool_tests 3. Fixed the scrolling issue while verifying values in a table. 4. Modified some functions in pgadmin_page.py On Wed, Nov 13, 2019 at 11:19

pgAdmin 4 commit: Refactored code of table and it's child nodes.

2019-11-15 Thread Akshay Joshi
Refactored code of table and it's child nodes. 1) Remove duplicate logic. 2) Child node specific logic should be inside the child node and table node gets the required information from the respective child node. Note:- Refactoring of columns node still in progress. Fixes #4807 Branch -- mas

Re: [pgAdmin][RM4818] Unable to handle loss of connection to server

2019-11-15 Thread Akshay Joshi
Hi Aditya Following are the review comments: 1. The default connection timeout should be *10* seconds. 2. In case the network is disabled and when we expand the "Servers" node the database server(for which network is disabled) should be shown in the disconnected state. 3. For the

Re: Refactored code for Table and its child nodes.

2019-11-15 Thread Khushboo Vashi
Hi Akshay, On Thu, Nov 14, 2019 at 5:52 PM Akshay Joshi wrote: > Hi Khushboo > > Attached is the patch to fix Python 2.7 issue. > Looks good to me. Thanks, Khushboo > > On Thu, Nov 14, 2019 at 2:48 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Everything w