Re: Fixes for pgAdmin feature tests

2019-11-19 Thread Akshay Joshi
Thanks, patch applied. On Wed, Nov 20, 2019 at 12:34 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > PFA feature test fixture patch containing the following things: > > 1. Added an attribute 'data-click-counter' in query execute button which > gets incremented once quer

pgAdmin 4 commit: Fix some more feature tests:

2019-11-19 Thread Akshay Joshi
Fix some more feature tests: 1. Added an attribute 'data-click-counter' in query execute button which gets incremented once query button is clicked up to 9 and then reset to 0. This is added just to support automation. 2. Locator for login_group_role is added and used to expand tree. 3. Functi

Re: Fixes for pgAdmin feature tests

2019-11-19 Thread Shubham Agarwal
Hi Team, PFA feature test fixture patch containing the following things: 1. Added an attribute 'data-click-counter' in query execute button which gets incremented once query button is clicked up to 9 and then reset to 0. This is added just to support automation. 2. Locator for login_group_role is

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

2019-11-19 Thread Aditya Toshniwal
Hi Hackers, pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run bundle" and is copied to generated directory also. This file is required for themes to show up. Currently, pgadmin.themes.json file is referred from web/pgadmin/misc/themes directory by the app. It is better to refe

Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View

2019-11-19 Thread Akshay Joshi
Hi Rahul Test cases failing on all EPAS servers. Please fix and send the patch again. On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > I have attached the patch for RE-SQL/MSQL test cases for View as well as > Materialized View. > > -- > *