[pgAdmin][RM4975] Cannot switch UI language

Hi Hackers, Attached is the patch to fix the issue where user language was not changing. This is a regression of the theme customization patch - #4348 -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4975.patc

Re: [pgAdmin][RM4674] User can not launch query tool window if user name contain html characters

Thanks, patch applied. On Thu, Dec 5, 2019 at 12:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > This issue seems to have reappeared. Kindly review the attached patch to > fix it again. > > On Wed, Aug 28, 2019 at 10:47 AM Akshay Joshi < > akshay.jo...@enterpr

pgAdmin 4 commit: Fix reverse engineering SQL issue for partitions when

Fix reverse engineering SQL issue for partitions when specifying digits as comments. Fixes #4893. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8e1973bc2d034ad45d4b79ea4972fd4f45bbd7f Modified Files -- docs/en_US/release_notes_

pgAdmin 4 commit: Fix query tool launch error if user name contains HTM

Fix query tool launch error if user name contains HTML characters. It's a regression. Fixes #4674. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0bd26222d82d7a1e022ab8ce637f6ddc47f66397 Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin][RM4674] User can not launch query tool window if user name contain html characters

Hi Hackers, This issue seems to have reappeared. Kindly review the attached patch to fix it again. On Wed, Aug 28, 2019 at 10:47 AM Akshay Joshi wrote: > Thanks patch applied. > > On Tue, Aug 27, 2019 at 4:44 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >>

pgAdmin 4 commit: Fix reverse engineering SQL issue for triggers when p

Fix reverse engineering SQL issue for triggers when passed a single argument to trigger function. Fixes #4958. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c7fe644e59486e4060b6d8712ad9ddc0b1b0611 Modified Files -- docs/en_US/r

Re: [pgAdmin4] Fix context menu CSS

Thanks, patch applied. On Wed, Dec 4, 2019 at 6:00 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Dec 4, 2019 at 4:22 PM Dave Page wrote: > >> Hi >> >> Is there an RM for this? >> > > I've created RM#4991 > Th

pgAdmin 4 commit: Fix an issue where context menu is open along with su

Fix an issue where context menu is open along with submenu and the focus is not on context menu or submenu. Fixes #4991. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f901eeeb4a76feff629194c1da42bf421fb36494 Author: Murtuza Zabuawala Modif

Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

Dave, Any update on this? Should I commit the patch? On Wed, 4 Dec, 2019, 11:57 Akshay Joshi, wrote: > Hi Dave, > > Should I commit this patch, are you happy with the new icons? > > On Tue, Dec 3, 2019 at 4:13 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >>

Re: [pgAdmin][RM4772][Accessibility] Provide aria-label to an invisible label where a visible label cannot be used

Thanks, patch applied. On Wed, Dec 4, 2019 at 3:00 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the feature tests which were failing after > the commit. The reason being, the span elements which was used to show > properties tab da

pgAdmin 4 commit: Fix the feature tests which were failing after the ac

Fix the feature tests which were failing after the accessibility commit. The reason being, the span elements which was used to show properties tab data are changed to input now as per accessibility requirements. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.gi

Re: [pgAdmin4] Fix context menu CSS

Hi Dave, On Wed, Dec 4, 2019 at 4:22 PM Dave Page wrote: > Hi > > Is there an RM for this? > I've created RM#4991 Thanks, Murtuza > > On Wed, Dec 4, 2019 at 4:06 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA

Re: [pgAdmin4] Fix context menu CSS

Hi Is there an RM for this? On Wed, Dec 4, 2019 at 4:06 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where we have context menu open along with > submenu and the focus is not on context menu or submenu then it was picking > the CSS from j

Re: [pgAdmin][RM4772][Accessibility] Provide aria-label to an invisible label where a visible label cannot be used

Hi Hackers, Attached is the patch to fix the feature tests which were failing after the commit. The reason being, the span elements which was used to show properties tab data is changed to input now as per accessibility requirements. Also, there is no way now to check XSS of input because the inpu

[pgAdmin4] Fix context menu CSS

Hi, PFA patch to fix the issue where we have context menu open along with submenu and the focus is not on context menu or submenu then it was picking the CSS from jquery.contextMenu.scss and displaying different color then the selected theme. -- Regards, Murtuza Zabuawala EnterpriseDB: http://ww