[pgAdmin][RM5096] Replace node-sass with sass for SCSS compilation

2020-01-15 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to replace node-sass with sass for SCSS compilation, along with changes required in pgAdmin files. It will fix the issues reported by yarn audit. sass is better maintained library than node-sass. Kindly review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Ha

Re: [pgAdmin][RM5000] Logout the inactive session

2020-01-15 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jan 15, 2020 at 3:18 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to disable user inactivity timeout for > desktop mode along with updated wordings in config file. > Kindly review. > > On Wed, Jan 15

pgAdmin 4 commit: Logout the pgAdmin session when no user activity of m

2020-01-15 Thread Akshay Joshi
Logout the pgAdmin session when no user activity of mouse move, click or keypress. Fixes #5000. Introduced two config params: 1. USER_INACTIVITY_TIMEOUT - Interval in seconds for the timeout. Default is 0-Zero which means disabled. 2. OVERRIDE_USER_INACTIVITY_TIMEOUT - If set to true, tools like

Re: [pgAdmin][RM5000] Logout the inactive session

2020-01-15 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch to disable user inactivity timeout for desktop mode along with updated wordings in config file. Kindly review. On Wed, Jan 15, 2020 at 2:54 PM Akshay Joshi wrote: > Hi Aditya > > We should not detect the user inactivity when SERVER_MODE = False. I have

Re: [pgAdmin][RM5000] Logout the inactive session

2020-01-15 Thread Akshay Joshi
Hi Aditya We should not detect the user inactivity when SERVER_MODE = False. I have tested it with SERVER_MODE = False and it refreshed the complete pgAdmin page after USER_INACTIVITY_TIMEOUT. Please fix that and resend the patch. On Wed, Jan 15, 2020 at 1:27 PM Dave Page wrote: > Hi > > On Mon

Re: RM5049 Patch

2020-01-15 Thread Yogesh Mahajan
Hi, Please find updated patch - Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Wed, Jan 15, 2020 at 1:49 PM Neel Patel wrote: > Patch only covers removal of the code and change in "coveragerc.in". I > guess you missed to add the new files in the patch. Ca

[pgAdmin][RM5050] Language node code coverage.

2020-01-15 Thread Pradip Parkale
Hi All, Attached is a patch for language node code coverage. This increases the code coverage of the language node from 45% to 69%. Command to run the tests - - python runtests.py --pkg browser.server_groups.servers.databases.languages.tests -- Thanks & Regards, Pradip Parkale QMG, Ent

Re: RM5049 Patch

2020-01-15 Thread Neel Patel
Patch only covers removal of the code and change in "coveragerc.in". I guess you missed to add the new files in the patch. Can you please verify ? Thanks, Neel Patel On Wed, Jan 15, 2020 at 1:16 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for