pgAdmin 4 commit: Fix an issue where refreshing a package results in th

2020-01-16 Thread Akshay Joshi
Fix an issue where refreshing a package results in the change in the object completely. Fixes #5066. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af56b92af4630806312ab7c2b8cb3316fc258736 Modified Files -- docs/en_US/release_not

pgAdmin 4 commit: Updated the incorrect icon used for the cast node on

2020-01-16 Thread Akshay Joshi
Updated the incorrect icon used for the cast node on refresh. Fixes #5065. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=430e9ae994006fa7669a73f60cf523ac6dde12d3 Modified Files -- docs/en_US/release_notes_4_18.rst

Re: [pgAdmin][RM5050] Language node code coverage.

2020-01-16 Thread Akshay Joshi
Hi Pradip Below are the review comments: - Format the JSON file. Rename the JSON file from 'language_testcases.json' to 'language_test_data.json'. - For consistency please follow the naming convention used in ' *cast_test_data.json*' file. For example, in Cast we have used 'name' a

Re: RM5049 Patch

2020-01-16 Thread Akshay Joshi
Thanks, patch applied with some modification as verify cast logic is not working. On Wed, Jan 15, 2020 at 2:45 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find updated patch - > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-974

pgAdmin 4 commit: Improve code coverage and API test cases for the CAST

2020-01-16 Thread Akshay Joshi
Improve code coverage and API test cases for the CAST module. Fixes #5049. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ab3bbeb82ca282327b1823205f9f9b2376ff396 Author: Yogesh Mahajan Modified Files -- docs/en_US/release_notes_

Re: [pgAdmin][RM5096] Replace node-sass with sass for SCSS compilation

2020-01-16 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jan 16, 2020 at 12:00 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to replace node-sass with sass for SCSS compilation, > along with changes required in pgAdmin files. It will fix the issues > reported by ya

pgAdmin 4 commit: Replace node-sass with sass for SCSS compilation. Fix

2020-01-16 Thread Akshay Joshi
Replace node-sass with sass for SCSS compilation. Fixes #5096 This will fix issues reported by the yarn audit. sass is better-maintained library than node-sass. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2bfac9e42938af97b091a41f755e3c40