Re: [pgAdmin4] RESQL tests for Column & Type nodes

Hi Murtuza, Patch looks good to me. Thanks! On Wed, Apr 29, 2020 at 2:38 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > I will review and test it. > > On Wed, Apr 29, 2020 at 2:27 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Hi, On Thu, Apr 30, 2020 at 10:48 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Apr 30, 2020 at 10:14 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> >> On Thu, Apr 30, 2020 at 9:41 AM Satish V >> wrote: >> >>> Hi Kushboo, >>> >>>

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

On Thu, Apr 30, 2020 at 10:14 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > > On Thu, Apr 30, 2020 at 9:41 AM Satish V > wrote: > >> Hi Kushboo, >> >> Thanks for the update. I will check the same and make appropriate changes. >> >> Thanks, >> Sathish >> >> On Thu, Apr

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Hi, On Thu, Apr 30, 2020 at 9:41 AM Satish V wrote: > Hi Kushboo, > > Thanks for the update. I will check the same and make appropriate changes. > > Thanks, > Sathish > > On Thu, Apr 30, 2020 at 9:20 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Satish, >> >> As per the

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Hi Satish, As per the RM, the fix is supposed to be at the front-end but it seems difficult at the moment as on the selection of the database, we connect it and at the same time the context menu is being called. As you have tried to fix at the backend, some of the review comments are below. 1.

pgAdmin 4 commit: Another attempt at fixing the 'do we need the --embed

Another attempt at fixing the 'do we need the --embed flag for Python' problem. This change looks at the output from python-config --help (which may go to stderr or stdout), and if it includes --embed, adds it to the later call to get the libs string. Branch -- master Details ---

pgAdmin 4 commit: Don't rely on python-config sending the help message

Don't rely on python-config sending the help message to stderr, as older versions seem to use stdout. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=97be3d8179637d946a93d7bb778a6fd6e7e69a8d Modified Files -- runtime/pgAdmin4.pro

RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Hi Hackers, In the patch attached, we are gracefully informing the end user, using an alert message, that the database is already connected when they click "Connect Database..." after right clicking on a disconnected database. As this problem deals with racing conditions, it is highly complex to

pgAdmin 4 commit: OK, another attempt at this as it fails on non-Linux

OK, another attempt at this as it fails on non-Linux non-Python 3.8. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=505956d1faffe2ed1f5d88169eade47c86be5eb7 Modified Files -- runtime/pgAdmin4.pro | 2 +- 1 file changed, 1

pgAdmin 4 commit: Sigh. Remove extraneous closing bracket. It's always

Sigh. Remove extraneous closing bracket. It's always a bracket. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f7ef86dcedaf3630002b54aaeacf0da86bec71de Modified Files -- runtime/pgAdmin4.pro | 2 +- 1 file changed, 1 insertion(+),

pgAdmin 4 commit: Fix the runtime build with Python 3.8 on Linux

Fix the runtime build with Python 3.8 on Linux Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3138f36e05ba843d1c386fc59d597049fb82446d Modified Files -- runtime/pgAdmin4.pro | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin][RM4279] : Issue with File Browser Home button

Hi all, Here is an updated patch as per the review comments mentioned above. Please review the updated patch. PFA. RM4279v4.patch Description: Binary data

Re: Raise an exception under Python < 3.4

Hi, On Wed, Apr 29, 2020 at 2:52 PM Dave Page wrote: > Hi > > On Wed, Apr 29, 2020 at 10:13 AM Neel Patel > wrote: > >> Hi Dave, >> >> Patch looks good to me except one condition as we do support from Python >> 3.4 onwards. I have modified that condition and attached the updated patch. >> > >

Re: Raise an exception under Python < 3.4

Hi On Wed, Apr 29, 2020 at 10:13 AM Neel Patel wrote: > Hi Dave, > > Patch looks good to me except one condition as we do support from Python > 3.4 onwards. I have modified that condition and attached the updated patch. > What did you change exactly (curious about what I missed)? > > I have

Re: Raise an exception under Python < 3.4

Hi Dave, Patch looks good to me except one condition as we do support from Python 3.4 onwards. I have modified that condition and attached the updated patch. I have also removed the other references of Python2. Attached is the patch. Do review it and let me know for comments. Thanks, Neel Patel

Re: [pgAdmin4] RESQL tests for Column & Type nodes

I will review and test it. On Wed, Apr 29, 2020 at 2:27 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add RESQL tests for Column and Type nodes. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise

[pgAdmin4] RESQL tests for Column & Type nodes

Hi, PFA patch to add RESQL tests for Column and Type nodes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company msql_tests_columns_types.diff Description: Binary data

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

Hi Navnath, On Wed, Apr 29, 2020 at 12:16 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Khushboo, > > Patch looks good to me except there are no API test cases written for > dependents and dependencies. > > Thanks for the review. We don't have API test cases for dependents

Re: [pgAdmin4][Patch] - RM 5422 - Synonym Dependencies tab shows incorrect data

Hi Khushboo, Patch looks good to me except there are no API test cases written for dependents and dependencies. Thanks! On Wed, Apr 29, 2020 at 10:40 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi , > > I'm reviewing this task. > > On Wed, Apr 29, 2020 at 9:36 AM Khushboo