Cleanup runtime qmake code

2020-05-01 Thread Dave Page
The attached patch tidies up the qmake code for configuring the runtime build so that it's consistent on all platforms, and simply requires that the PGADMIN_PYTHON_DIR environment variable points to the Python installation to be used. Please review, but don't commit, as this change will probably b

pgAdmin 4 commit: Rename README

2020-05-01 Thread Dave Page
Rename README Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9bdf900b257596d2d600ba827a375db17508152c Modified Files -- pkg/mac/README.txt | 32 1 file changed, 32 deletions(-)

pgAdmin 4 commit: Minor cleanup and modernisation.

2020-05-01 Thread Dave Page
Minor cleanup and modernisation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ec60a6f85c1b0a5ca1686d1225d2bb3b970b512 Modified Files -- pkg/mac/codesign.conf.in | 2 +- pkg/mac/framework.conf.in | 12 ++-- 2 files chang

pgAdmin 4 commit: Rename the README and fix it up to match modern reali

2020-05-01 Thread Dave Page
Rename the README and fix it up to match modern reality. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=70e24ba0591a057028ffdedd9d4c30f573eb0244 Modified Files -- pkg/mac/README | 42 ++ 1 fi

Re: Patch to remove Python 2.7 support in the macOS Appbundle

2020-05-01 Thread Dave Page
Akshay, are you happy with this patch? On Mon, Apr 27, 2020 at 3:30 PM Dave Page wrote: > > > On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> The code looks good to me. The package building was tested by Neel and we >> found that the venv

Re: [pgAdmin][RM5455] Cleanup pgAdmin.py

2020-05-01 Thread Dave Page
Hi On Thu, Apr 30, 2020 at 2:31 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to restructure pgAdmin4.py so that the startup code > can be imported by setup_pip.py. > Code is also changed to tidy and restructure the code a bit. Changes won

Re: [pgAdmin][RM5455] Cleanup pgAdmin.py

2020-05-01 Thread Akshay Joshi
Hi Dave Can you please review it and check whether it fulfills your requirement or not. On Thu, Apr 30, 2020 at 7:01 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to restructure pgAdmin4.py so that the startup code > can be imported by se