Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop, Variables should be declared

Hi Yogesh Please fix the linter error and send the patch again. On Thu, Jun 25, 2020 at 12:26 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find patch fixing the issues related to below rules - > 1.A conditionally executed single line should be denoted by indentati

pgAdmin 4 commit: Fixed SonarQube issues with the tag unused. All the u

Fixed SonarQube issues with the tag unused. All the unused variables, assignments, code comments are fixed. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3b3d07f2e8864d8bd3a1595e4679ea77e632708 Author: Aditya Toshniwal Modified Files

Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

Hi Yogesh Jasmin tests are failing, please fix and resend the patch. On Thu, Jun 25, 2020 at 11:52 AM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find an updated patch. > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 >

[pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop, Variables should be declared exp

Hi, Please find patch fixing the issues related to below rules - 1.A conditionally executed single line should be denoted by indentation, 2.A "while" loop should be used instead of a "for" loop, \ 3.Variables should be declared explicitly) Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation

Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

Hi Rahul I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code *without* applying your patch: BEGIN SELECT 1; END; Then apply your patch and check the SQL tab. On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat < rahul.shir..

Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

Hi, Please find an updated patch. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Wed, Jun 24, 2020 at 12:31 PM Akshay Joshi wrote: > Hi Yogesh > > After applying your patch a new sonarqube issue has been found "Change > this argument to the documented typ

[pgAdmin][patch] SonarQube reported issues tagged - unused

Hi Hackers, Attached is the patch to fix SonarQube issues with the tag "unused". All the unused variables, assignments, code comments are fixed. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"

Re: Reg-[pgAdmin4][Patch] - SonarQube - Extra semicolons should be removed and Method names should comply with a naming convention

Thanks, patch applied. On Wed, Jun 24, 2020 at 1:18 PM Satish V wrote: > Hi Hackers, > > Please find the patch which solves the problem related to extra semicolons > and function naming convention. > > Please review. > > Thanks, > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *Sr. Softwar

Re: Patch for SonarQube code scan.

Thanks, patch applied. On Wed, Jun 24, 2020 at 2:27 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > fixed some code smell in the database init file from the SonarQube scan. > > PFA patch. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB So

pgAdmin 4 commit: Fixed following SonarQube issues:

Fixed following SonarQube issues: 1) TypeError can be thrown as might be null or undefined here. 2) Unexpected duplicate "white-space". 3) Unexpected missing generic font family. 4) Unexpected shorthand "padding" after "padding-left". Branch -- master Details --- https://git.postgresql.o

pgAdmin 4 commit: Fixed issue related to extra semicolons and function

Fixed issue related to extra semicolons and function naming convention reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a1fd9ea3ce1508d395cb1b5741dc5e1a4e3d36a9 Author: Satish V Modified Files -- web/pgadmin

pgAdmin 4 commit: Fixed 'Rename local variable to match the regular exp

Fixed 'Rename local variable to match the regular expression' issue reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db9d684524b88afcc55cdd2046870b4179dabdf5 Author: Nikhil Mohite Modified Files -- .../serve

Patch for SonarQube code scan.

Hi Team, fixed some code smell in the database init file from the SonarQube scan. PFA patch. code_smell_fixes_for_databse.patch Description: Binary data

Reg-[pgAdmin4][Patch] - SonarQube - Extra semicolons should be removed and Method names should comply with a naming convention

Hi Hackers, Please find the patch which solves the problem related to extra semicolons and function naming convention. Please review. Thanks, Sathish V scss_and_function_name.patch Description: Binary data

Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

Hi Yogesh After applying your patch a new sonarqube issue has been found "Change this argument to the documented type: Number." in sqleditor_utils.js Please fix that and resend the patch. On Mon, Jun 22, 2020 at 4:36 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > P