Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Wed, Jul 8, 2020 at 3:00 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch to fix the SonarQube Code smells having > Rule "Refactor this function to reduce its Cognitive Complexity from 18 > to the 15 allowed". > > -- > *Rahul Shirsat* > Software

Re: [pgAdmin][SonarQube] Critical issue fixes - servers

Thanks, patch applied. On Thu, Jul 9, 2020 at 7:15 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the updated patch below which fixes the issue in > sslcompression changes. > > On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> P

Re: [pgAdmin] Regarding Alert-box on login page

Thanks, patch applied. On Fri, Jul 10, 2020 at 10:59 AM Yogesh Jain wrote: > Hi Hackers, > > In case, if we have more than one flash messages/alert box on the pgAdmin > login page and if we click on any alert box close button then it will close > all alerts as each div has the same ID. > > PFA t

pgAdmin 4 commit: Ensure that closing the alert box on the login page w

Ensure that closing the alert box on the login page will close multiple alert boxes if opened. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92858e40bf009f8d05a57eeb75317cbff0ecbf3f Author: Yogesh Jain Modified Files -- web/pga

pgAdmin 4 commit: Improve code coverage and API test cases for FTS Conf

Improve code coverage and API test cases for FTS Configuration, FTS Parser, FTS Dictionaries, and FTS Template. Fixes #5329. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7420673a0f23fa14291f8574a47131929b233da5 Author: Nikhil Mohite Modif

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e8b81db9778e89203734fe3b80578c47ff8f379e Author: Rahul Shirsat Modified Files -- .../browser/server_groups/servers/__init__.p

[pgAdmin] Regarding Alert-box on login page

Hi Hackers, In case, if we have more than one flash messages/alert box on the pgAdmin login page and if we click on any alert box close button then it will close all alerts as each div has the same ID. PFA to fix the potential issue. -- Thanks, Yogesh Jain Ph:+91-8982696654 alertBoxLogin.patch

Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

Hi Rahul, I am getting errors while applying the patch, please rebase the patch and send it again. Thanks, Khushboo On Thu, Jul 9, 2020 at 1:25 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please review it. > > On Wed, Jul 8, 2020 at 6:12 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com

Re: [pgAdmin][SonarQube] Critical issue fixes - servers

Hi Hackers, Please find the updated patch below which fixes the issue in sslcompression changes. On Thu, Jul 9, 2020 at 4:46 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch which includes sonarqube fixes : > > 1. Refactor this function to reduce its Cognitive Complexity

Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code

Thanks, patch applied. On Thu, Jul 9, 2020 at 4:37 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Patch looks good to me. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > > > On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi > wrote

Re: [pgAdmin4][Patch] - SonarQube Issues - 10 (Variables should not be shadowed)

Thanks, patch applied. On Thu, Jul 9, 2020 at 6:07 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find a patch which fixes issues related to rule - >a.Variables should not be shadowed. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone:

Re: Re- [pgAdmin][SonarQube] Variables should not be shadowed

Thanks, patch applied. On Thu, Jul 9, 2020 at 12:59 PM Satish V wrote: > Hi Hackers, > > Please find the patch which fixes 10 issues related to the Variables > should not be shadowed. > Kindly review and share the comments. > > Thanks, > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *Sr.

Re: Patch for SonarQube code scan fixes

Thanks, patch applied. On Thu, Jul 9, 2020 at 4:11 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Table files(utils): > >- Refactor this function to reduce its Cognitive Complexity from 34 to >the 15

Re: [pgAdmin][patch] SonarQube "convention" tagged fixes

Thanks, patch applied. On Thu, Jul 9, 2020 at 11:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for a few more "convention" tagged fixes. The patch > also fixes a regression caused by the previous patch in file dialog. > > On Mon, Jul 6,

Re: [pgAdmin][RM5633]:Create RLS Policy option enabled for catalog objects

Thanks, patch applied. On Wed, Jul 8, 2020 at 7:28 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch. I have disabled creating an RLS policy > option for catalog objects. > > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

Thanks, patch applied. On Thu, Jul 9, 2020 at 3:25 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find an updated patch with the above comment. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > > > On Thu, Jul 9, 2020

Re: [SonarQube]: Rename function and variable name to match the regular expression

Thanks, patch applied. On Thu, Jul 9, 2020 at 11:56 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find another patch variable naming convention. > > On Wed, Jul 1, 2020 at 1:54 PM Akshay Joshi > wrote: > >> Thanks, patch applied. >> >> On Wed, Jul 1, 2020 a

pgAdmin 4 commit: Fixed code smell for variable naming convention.

Fixed code smell for variable naming convention. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=916182f80f3521169a59179ae030c5d400efe28f Author: Pradip Parkale Modified Files -- web/pgAdmin4.py

pgAdmin 4 commit: Fixed code smell to reduce cognitive complexity.

Fixed code smell to reduce cognitive complexity. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e1168f8de0f30faebf95fd1359dec2a62be85b27 Author: Nikhil Mohite Modified Files -- .../servers/databases/schemas/tables/utils.py |

pgAdmin 4 commit: Fixed code smell 'Variables should not be shadowed'.

Fixed code smell 'Variables should not be shadowed'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=290cf8271be46701d3f8aff5f2577189290bdf37 Author: Satish V Modified Files -- web/pgadmin/misc/file_manager/static/js/utility.js |

pgAdmin 4 commit: Fixed accessibility issue where few dialogs are not r

Fixed accessibility issue where few dialogs are not rendering properly when we zoomed in browser window 200% and screen resolution is low. Fixes #5662 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2db9242f5c256ba2f1187bede5b127c1c077e994 Aut

pgAdmin 4 commit: Ensure that create RLS Policy menu should not be visi

Ensure that create RLS Policy menu should not be visible for catalog objects. Fixes #5633 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c58fda0a70134bde31c712ccd85f9825f088053a Author: Pradip Parkale Modified Files -- docs/en_U

pgAdmin 4 commit: Fixed an issue where CSV download quotes numeric colu

Fixed an issue where CSV download quotes numeric columns. Fixes #5463 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c08e618bd31587f98e6653286b0914661b65cc4 Author: Yogesh Mahajan Modified Files -- docs/en_US/release_notes_4_24.

pgAdmin 4 commit: Fixed convention related issues reported by SonarQube

Fixed convention related issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=357a9179b145d1bc15902781cecc9603ed48be71 Author: Aditya Toshniwal Modified Files -- web/pgAdmin4.py

pgAdmin 4 commit: Fixed code smell 'Variables should not be shadowed'.

Fixed code smell 'Variables should not be shadowed'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2cefa9afca4d0a5c0e389e9512fad7f5e88327d1 Author: Yogesh Mahajan Modified Files -- .../tools/debugger/static/js/debugger_ui.js

[pgAdmin4][Patch] - SonarQube Issues - 10 (Variables should not be shadowed)

Hi, Please find a patch which fixes issues related to rule - a.Variables should not be shadowed. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix10_v1.patch Description: Binary data

[pgAdmin][SonarQube] Critical issue fixes - servers

Hi Hackers, Please find the attached patch which includes sonarqube fixes : 1. Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed for *check_ssl_fields* in servers/__init__.py 2. Refactor this function to reduce its Cognitive Complexity from 25 to the 15 allow

Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code

Hi, Patch looks good to me. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi wrote: > Hi Yogesh > > Can you please review it. > > On Thu, Jul 9, 2020 at 11:56 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.co

Patch for SonarQube code scan fixes

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Table files(utils): - Refactor this function to reduce its Cognitive Complexity from 34 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 25 to the 1

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

Hello, Please find an updated patch with the above comment. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Thu, Jul 9, 2020 at 2:27 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yogesh, > > The patch looks good to me except that the n

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

Hi Yogesh, The patch looks good to me except that the newly added import can be clubbed with the existing one. +from psycopg2.extensions import DECIMAL as _DECIMAL import psycopg2 from psycopg2.extensions import encodings On Thu, Jul 9, 2020 at 1:24 PM Akshay Joshi wrote: > Hi Aditya > > C

Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

Hi Khushboo Can you please review it. On Wed, Jul 8, 2020 at 6:12 PM Rahul Shirsat wrote: > Hi Hackers, > > Following patch includes fix for : > > Storage parameters should be displayed in parent tables's SQL. > > As the code will be upgraded in feature #5649 >

Re: [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns

Hi Aditya Can you please review it. On Wed, Jul 8, 2020 at 4:17 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find a patch which fixes the issue of quoting values of > numeric data types like 'bigint, numeric, double precision & real'. > > The issue was caused beca

Re: [pgAdmin4][RM#5662] [Accessibility] File manager dialog was not rendering properly due to fixed width and height set in the code

Hi Yogesh Can you please review it. On Thu, Jul 9, 2020 at 11:56 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where few dialogs are not rendering properly > when we zoomed in browser window 200% and screen resolution is low. > > -- > Rega

Re- [pgAdmin][SonarQube] Variables should not be shadowed

Hi Hackers, Please find the patch which fixes 10 issues related to the Variables should not be shadowed. Kindly review and share the comments. Thanks, Sathish V variable_shadow2.patch Description: Binary data