Re: Sonarqube fixes - test_utils.py

Hi Shubham The patch is not applied because the changes that you have added in the patch is already there. On Wed, Jul 29, 2020 at 6:33 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > Attached is the patch containing a fix for the SonarQube Bug in the > test_utils.py f

Re: WIP: SQL Formatter

Hi Dave, On Wed, Jul 29, 2020 at 9:34 PM Dave Page wrote: > The attached WIP patch adds a menu option to the Query Tool to format the > SQL in the editor. It does so per options that can be set in the > Preferences panel (essentially, most of these: > https://sqlparse.readthedocs.io/en/latest/ap

WIP: SQL Formatter

The attached WIP patch adds a menu option to the Query Tool to format the SQL in the editor. It does so per options that can be set in the Preferences panel (essentially, most of these: https://sqlparse.readthedocs.io/en/latest/api/#formatting-of-sql-statements) Some thoughts before I continue: -

Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

Thanks, patch applied. On Wed, Jul 29, 2020 at 3:52 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Ignore the previous patch. Find below the rebased patch. > > On Wed, Jul 29, 2020 at 2:36 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Hackers, >>

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Wed, Jul 29, 2020 at 4:24 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > Foreign key init: > >- Refactor this function to reduce its Cognitive Co

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=89fa85d650674cdab9fa5765e02d7727bca7f4fa Author: Nikhil Mohite Modified Files -- .../databases/schemas/foreign_tables/__init_

pgAdmin 4 commit: Fixed code smells in runtime code reported by SonarQu

Fixed code smells in runtime code reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=099fea15ae0b847ec9802bdb36df4473af3f1e46 Modified Files -- runtime/Logger.cpp | 2 +- runtime/Logger.h| 2 +- runti

pgAdmin 4 commit: Ensure that the user will be able to modify the start

Ensure that the user will be able to modify the start value of the Identity column. Fixes #5632 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=74fd5dfe9604d89f4ce157743ec09129d0dc1844 Author: Rahul Shirsat Modified Files -- .git

Patch for SonarQube code scan fixes.

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: Foreign key init: - Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed. Constraints: 1. Index constraints: 1. Refactor this function to reduce its

Re: [pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

Hi Hackers, Ignore the previous patch. Find below the rebased patch. On Wed, Jul 29, 2020 at 2:36 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch below which fixes the issue of Start value while > updating the identity column. > > *Some additiona

Re: [pgAdmin 4 - Housekeeping #5336][Code Coverage] Improve API test cases for Types

Thanks, patch applied. On Wed, Jul 29, 2020 at 3:15 PM Satish V wrote: > Hi Hackers, > > Please find the patch attached which improves the code coverage percentage > of Types from 53% to 76%. Kindly review the patch. > > Thanks, > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hack

Re: [pgAdmin][RM3904] Replace charting library Flotr2 with ChartJS using React

Thanks, patch applied. On Mon, Jul 27, 2020 at 5:50 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch to resolve the raised concerns. > > On Fri, Jul 24, 2020 at 5:37 PM Dave Page wrote: > >> Hi >> >> Some further thoughts/comments: >

pgAdmin 4 commit: Replace charting library Flotr2 with ChartJS using Re

Replace charting library Flotr2 with ChartJS using React. Fixes #3904 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f715373218002cea42d711c0abc6eb753c4efcab Author: Aditya Toshniwal Modified Files -- DEPENDENCIES

pgAdmin 4 commit: Improve code coverage and API test cases for Types. F

Improve code coverage and API test cases for Types. Fixes #5336 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=287a6628ed570f21eb6c6e28d3938fc300933e63 Author: Satish V Modified Files -- docs/en_US/release_notes_4_25.rst

pgAdmin 4 commit: 1) Fixed pgAdmin hang issue when the user clicks on '

1) Fixed pgAdmin hang issue when the user clicks on 'View Log' menu option. 2) Fixed some code smell in runtime code. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=510dd5c047609a07843241c1cfc819ad80acb5ca Modified Files -- runtim

[pgAdmin 4 - Housekeeping #5336][Code Coverage] Improve API test cases for Types

Hi Hackers, Please find the patch attached which improves the code coverage percentage of Types from 53% to 76%. Kindly review the patch. Thanks, Sathish V RM5336s1.patch Description: Binary data

[pgAdmin][RM5632] Cannot specify start with value during setup of an identity column

Hi Hackers, Please find the patch below which fixes the issue of Start value while updating the identity column. *Some additional issues were also found during development, which are too fixed now :* 1. While changing of identity (*ALWAYS / BY DEFAULT*) including *sequence options, it onl

pgAdmin 4 commit: Make sure the version check is compatible with older

Make sure the version check is compatible with older versions of Qt Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5820b9521e6a227325e04eb455f424584ac71343 Modified Files -- runtime/pgAdmin4.pro | 2 +- 1 file changed, 1 insertion(

pgAdmin 4 commit: Correct TLS certificate filename in the container dep

Correct TLS certificate filename in the container deployment docs. Fixes #5708 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fc6ec1cda3e710ab8fda4faa1081679e5601e95 Modified Files -- docs/en_US/container_deployment.rst | 4 ++--